From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7665C5AD49 for ; Mon, 2 Jun 2025 14:25:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1003513.1383084 (Exim 4.92) (envelope-from ) id 1uM65s-00049R-Bl; Mon, 02 Jun 2025 14:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1003513.1383084; Mon, 02 Jun 2025 14:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uM65s-00049K-8x; Mon, 02 Jun 2025 14:24:52 +0000 Received: by outflank-mailman (input) for mailman id 1003513; Mon, 02 Jun 2025 14:24:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uM65q-00049E-5X for xen-devel@lists.xenproject.org; Mon, 02 Jun 2025 14:24:50 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 566e3d95-3fbd-11f0-b894-0df219b8e170; Mon, 02 Jun 2025 16:24:48 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so13177465e9.1 for ; Mon, 02 Jun 2025 07:24:48 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506bc8b0fsm71255915ad.7.2025.06.02.07.24.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 07:24:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 566e3d95-3fbd-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748874287; x=1749479087; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=+xSc7AvOYJ5oAG7rtbkBJTkVM+vaBHZuRstLmwn9AGM=; b=cD8goVFI6yk2r0TTvrtd53Pcfha0VJcNiIJAOvhcRRMCN4AYNSARpjxp6ZlffOg6sW fY8na3ZFzdkeDCESiyoKF1Q1PvHktJlliVDsU4kh2cfdpZoH4do7QnimXr5kUYHIhQPc ktSK5VhVIqV8kgHQmmY7RWK3awHer8oDy5+JRsVK6qhw/1fhWTiNyJz82U2yv07JGqie nWth776Se6guIMfSrBV4KHp4LY037208wB1IzDC80rjYwqF8LPvfrt/bKvNQYvSiJRzH Cn7m+nZHknakFkN/4RbrJ+tlBygPaBKhXGbmnDGrOkoQ85d3txWYxyUwvh3hmqdjsmG7 13xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748874287; x=1749479087; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+xSc7AvOYJ5oAG7rtbkBJTkVM+vaBHZuRstLmwn9AGM=; b=T6VPXxdrpON6CwxVxkcFcBkoR1oUXpjYs4fL8oHY/utin3SCz9zK6vSNvQUEx9VqkK 1j1h/JWuez8nCO/uaBgxpxMFvifThSVqpnh4evitWObxauG8SMIsJbb4FExytEh6UIMG 0wEZJOVZJHdugi1BZcqqFZYXwUwbBf2/up+OLQQL2NqTQq0Vpc+adqXmAS0WeFfG5J0q vs67cRf/Jb8td0AmpOSBqSvTBBsUr6zhu/3UQCLHBOcISY4wfJrRfeWwW4/9RBsoDkPv 1ybtiwQt0ksaWhCVt180UNzdsqfIueDNZEmYUg0ap/2F+yEDjZzbOKhC5pI8RUNb+rIU bvDA== X-Forwarded-Encrypted: i=1; AJvYcCXy3hPJXieIYRZgyBZuVSd+4uFabCH/v2igs3/u0bvTbXuhEcusO4pYJAdYuUMwn9mA+exbuE73LFU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yye9N+guMLslXN4TrDoDK7vnMHF8iPNlExLhLQ20ZIweK+MIo3g 1W0AN0+eyHy8ibPqWvMJUrEzGkgaB52Z78XaD7m2NOKs6HKmROHEpLW7IGhv/ER89g== X-Gm-Gg: ASbGncuPVS81Q/vhqmbGd1R9qlDuzL2t8jJW4oRXZHTn7+yKdGQGzjfyWItW8AmrEDJ ihGk1fXpE9psAHrkUCg0ooN62/ylpE7ADUUIYy2d9T/2vyKlQJJCD3a5RSOF5JLlZKjn5dODsu4 RhpN1fHBXxYiWDkQ3PBPmA+5LWLIdyaobevsu9F4hwO4dlclqE7LAwyDFVtPJgcr/SO4lLcovE/ 7R+8NSMEf+ue67ZO5NOyTeOcuXovU+IthTwIhSJzKVN2rM1vGiNHk4+rz/nrnZvDPgxNbc+/x+I +ufxYluMoez84tlg4eu4MlYDZz9NfU/5AE5ANO/Hxvnzxn3j6znea6M7Ni2R1Xxh5N0Jit/BobJ aU8VJF5xALGxD0+x5e79vCiOaGVSSH2+w7Ynczh8tACtnKMI= X-Google-Smtp-Source: AGHT+IHG7eP42v2dgk428z3sGHrVSCKO9+ajlpz8VQ1N2OLEqLJtP5jPewMdY+CQ2Sfo99qOIWVtwQ== X-Received: by 2002:a05:6000:2c12:b0:3a4:d64a:3df0 with SMTP id ffacd0b85a97d-3a4f7a025bdmr10826143f8f.4.1748874287541; Mon, 02 Jun 2025 07:24:47 -0700 (PDT) Message-ID: Date: Mon, 2 Jun 2025 16:24:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/19] xen: Clean up asm-generic/device.h To: Alejandro Vallejo Cc: Alistair Francis , Bob Eshleman , Connor Davis , Oleksii Kurochko , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <20250530120242.39398-1-agarciav@amd.com> <20250530120242.39398-7-agarciav@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02.06.2025 16:19, Alejandro Vallejo wrote: > On Mon Jun 2, 2025 at 9:51 AM CEST, Jan Beulich wrote: >> On 30.05.2025 14:02, Alejandro Vallejo wrote: >>> --- a/xen/include/asm-generic/device.h >>> +++ b/xen/include/asm-generic/device.h >>> @@ -6,9 +6,7 @@ >>> >>> enum device_type >>> { >>> -#ifdef CONFIG_HAS_DEVICE_TREE >>> DEV_DT, >>> -#endif >> >> Why would this enumerator need exposing on a non-DT arch? In fact I would have >> hoped for ... > > A non-DT arch would not include this. x86 doesn't. Both here and ... >>> DEV_PCI >> >> ... this to be hidden for arch-es not supporting PCI. >> >> Similar concerns elsewhere in this change. > > This file is exclusively used by arches supporting DT to abstract away where > the device came from. x86 does not use it at all, and while it wouldn't be > impossible to compile-out DEV_PCI, it would needlessly pollute the codebase with > no measurable gain, because the abstractions still need to stay. ... here: In "xen/include/asm-generic/device.h" there's nothing at all saying that this file is a DT-only one. Instead there is something in there saying that it's suitable to use in the entirely "generic" case. Jan