From: darkpenguin <darkpenguin@posteo.de>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Add support for specifying the boot device by label
Date: Tue, 26 Sep 2023 07:28:48 +0000 [thread overview]
Message-ID: <daa84538-80ef-e215-015d-e59bbcb963d2@posteo.de> (raw)
In-Reply-To: <CAEaD8JOmzNpjx_N6WRHQHgFMAQwB6Q4Ywh9jjHotq-SV-KL0aw@mail.gmail.com>
On 11/09/23 01:20, Vladimir 'phcoder' Serbinenko wrote:
> Unlike UUID, label may contain spaces. AFAICT your code fails with spaces
It fails indeed. However, I can't even figure out how to make spaces in
labels work for *anything* - not only grub.cfg, but also fstab. Neither
quoting nor escaping them works. Also, it can probably contain other
symbols that get mangled into escaped sequences in /dev/disk/by-label/.
So, seeing that supporting spaces and other symbols in the boot device
is barely possible, wouldn't it be better to just fall back to UUID if
the label is too "unusual" to not require any "mangling" into escape
sequences?
If not, then how should I approach this for both grub.cfg and fstab?
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2023-09-26 7:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 9:30 [PATCH] Add support for specifying the boot device by label darkpenguin
2023-09-10 21:12 ` Oskari Pirhonen
2023-09-11 6:48 ` darkpenguin
2023-09-12 2:54 ` Oskari Pirhonen
2023-09-12 7:42 ` darkpenguin
2023-09-12 13:02 ` Nicholas Vinson
2023-09-12 15:10 ` darkpenguin
2023-09-10 21:20 ` Vladimir 'phcoder' Serbinenko
2023-09-11 6:28 ` darkpenguin
2023-09-26 7:28 ` darkpenguin [this message]
2023-09-27 6:51 ` darkpenguin
2023-09-27 10:16 ` Daniel Kiper
2023-09-27 11:05 ` darkpenguin
2023-09-27 15:22 ` Vladimir 'phcoder' Serbinenko
2023-09-27 15:42 ` darkpenguin
2023-09-27 20:33 ` Vladimir 'phcoder' Serbinenko
2023-09-11 10:44 ` Olaf Hering
2023-09-11 11:15 ` darkpenguin
2023-09-12 12:10 ` Nicholas Vinson
2023-09-12 14:17 ` darkpenguin
2023-09-12 19:06 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daa84538-80ef-e215-015d-e59bbcb963d2@posteo.de \
--to=darkpenguin@posteo.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.