All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: "David Hildenbrand" <david@redhat.com>,
	"Hugh Dickins" <hughd@google.com>,
	"Patryk Kowalczyk" <patryk@kowalczyk.ws>,
	da.gomez@samsung.com, baohua@kernel.org,
	wangkefeng.wang@huawei.com, ioworker0@gmail.com,
	willy@infradead.org, ryan.roberts@arm.com,
	akpm@linux-foundation.org, eero.t.tamminen@intel.com,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: regression - mm: shmem: add large folio support for tmpfs affect GPU performance.
Date: Thu, 24 Jul 2025 21:47:48 -0700 (PDT)	[thread overview]
Message-ID: <dab283bf-a9cf-30be-02ed-da0d7c8ffcf0@google.com> (raw)
In-Reply-To: <da2ab844-98c9-4eb2-82ac-01d01bec30f3@linux.alibaba.com>

On Fri, 25 Jul 2025, Baolin Wang wrote:
> > 
> > I hope to correct the logic of i915 driver's shmem allocation, by extending
> > the shmem write length in the i915 driver to allocate PMD- sized THPs. IIUC,
> > some sample fix code is as follows (untested). Patryk, could you help test
> > it to see if this resolves your issue? Thanks.

This patch cannot be the right fix.  It may be a very sensible workaround
for some in-kernel drivers (I've not looked or tried); but unless I
misunderstand, it does nothing to restore userspace behaviour on a
huge=always tmpfs.

Please reread my comment earlier in the thread, in particular,
Passing a new SIGBUS xfstest does not excuse a regression: strict PAGE_SIZE
SIGBUS behaviour is fine for the newly-featured mTHPs or large folios,
but not for the long-established huge=always.

Thanks,
Hugh


  reply	other threads:[~2025-07-25  4:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJCW39JCDX6_S2Ojt1HMmX-h_qAKm2eBRzxX5kOHNJz60Zu=vw@mail.gmail.com>
     [not found] ` <d5c6ac93-1af0-4093-afea-94a29a387903@redhat.com>
     [not found]   ` <63b69425-2fd1-2c77-06d6-e7ea25c92f34@google.com>
     [not found]     ` <3f204974-26c8-4d5f-b7ae-4052cbfdf4ac@redhat.com>
     [not found]       ` <a8ac7ec3-4cb3-4dd8-8d02-ede6905f322e@linux.alibaba.com>
2025-07-25  2:38         ` regression - mm: shmem: add large folio support for tmpfs affect GPU performance Baolin Wang
2025-07-25  4:47           ` Hugh Dickins [this message]
2025-07-25  6:05             ` Baolin Wang
2025-07-25  8:36               ` Patryk Kowalczyk
2025-07-25  9:17                 ` Baolin Wang
2025-07-28  5:35               ` Hugh Dickins
2025-07-28  6:29                 ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dab283bf-a9cf-30be-02ed-da0d7c8ffcf0@google.com \
    --to=hughd@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=da.gomez@samsung.com \
    --cc=david@redhat.com \
    --cc=eero.t.tamminen@intel.com \
    --cc=ioworker0@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=patryk@kowalczyk.ws \
    --cc=ryan.roberts@arm.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.