From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21937C433F5 for ; Thu, 9 Sep 2021 06:55:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF3236113E for ; Thu, 9 Sep 2021 06:55:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF3236113E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12ADC6E44A; Thu, 9 Sep 2021 06:55:49 +0000 (UTC) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2045.outbound.protection.outlook.com [40.107.236.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id E24936E44A for ; Thu, 9 Sep 2021 06:55:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8hi416SYQ8OmtSXb2elLen7azLgACPET8/naLugxb7qCJ648k+e6NAgIROY1xS2ffNDE6walsPwHoqJ4rMfFhMwMnuq4vR+qhPc3mUmU7nzj3zNgCqBkUVwBXKw+qauyrgHO7iGPGhPekL7PpSU7rdZ9ZR0+71JZ/jMA2vuu9xVVUXSHgLrTB6WdD1XZdM6i6zvlZ0OdFxN2s2yT6YcxSQ4gON1mUy5z1F85FT5DDRETxbTlUHZpFBd2JUu/zMBkYFA3WwvUFYd0WOnKSaCZqbqNVnMU4JQexisUz7FbmofvK/AeXBcwEOedGyindK70OA56+4CVTQ6jTrdHomppg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=teFepYySKYD2C48iFNbnpJ3EzklsUFTx0ylm39NuI5s=; b=NCbtHPW3IKxiYFrEgemV6f8sHy2+Oybgq3Eck0MdP3fVmld/C+Gl5EK2waWIYhHr6x1thM6kJT9LBvbvFZ6SEnFXGPM1W0QPJ00RxCbi2EkXMAnaIDmapSHr/X0emsPpbkZUN0R2w9ef/HDBtfi5YPVt9VPcKBwa1CLwFZrFjI8kKTeT38xsMpC1JGqQgARBPiEcq9JOcV3ZXS3uZns2lFSvxwU2ZMsu9jGnzOEl1sdfMwVcv7FLgyQyid5GUJLDME+WVs88cMO2yVV7kw3oCy2BCJazOHO+IxAAbXck32BM4PrFFJFxGLeIsBK3SedfUBNYHkh5oREYkoxUYIvTLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=teFepYySKYD2C48iFNbnpJ3EzklsUFTx0ylm39NuI5s=; b=dB3T59yd29okl/cXEJ00Sc9PPcjLtcDuoCmqVs5BoL/ZBDQOE0H9AtBlMAL9YZVxeCpwQVyt2qJDB/NmwJM765LCp83q1/Jukh6jKGisxcQ3g70Nmjno/sKeqmmZkgJozzpX2PbZyJ4BJuGP0uBgsLyjc80G1u538pnRMA6GaBM= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by BL0PR12MB4755.namprd12.prod.outlook.com (2603:10b6:208:82::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15; Thu, 9 Sep 2021 06:55:45 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::dce2:96e5:aba2:66fe]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::dce2:96e5:aba2:66fe%6]) with mapi id 15.20.4500.015; Thu, 9 Sep 2021 06:55:45 +0000 Subject: Re: [PATCH v3 6/9] dma-buf/fence-array: Add fence deadline support To: Rob Clark , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Pekka Paalanen , Rob Clark , Sumit Semwal , Gustavo Padovan , "open list:SYNC FILE FRAMEWORK" , open list References: <20210903184806.1680887-1-robdclark@gmail.com> <20210903184806.1680887-7-robdclark@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 9 Sep 2021 08:55:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: AM0PR06CA0120.eurprd06.prod.outlook.com (2603:10a6:208:ab::25) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 Received: from [IPv6:2a02:908:1252:fb60:327b:a453:3daa:de36] (2a02:908:1252:fb60:327b:a453:3daa:de36) by AM0PR06CA0120.eurprd06.prod.outlook.com (2603:10a6:208:ab::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 06:55:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8bfe381-3a19-4d05-ac4c-08d9735ed8a8 X-MS-TrafficTypeDiagnostic: BL0PR12MB4755: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EKMZnT/3CJzLzhnggAaQcNGi18dt+SFuefOCRPlVSmIGP+YV1EqVWUkXW5+yXw/POwkKFtrOITei26zphFsVMalF3UE+6mAQHzcQp2bqQO8rvoI5VNb1/2WN5s9bLO9JSP6XTemnJzB7TbIMaHWqx2tKg1HQMICAH1nQXt4MNlmaW+ZcA3jKkS5si7XnbVJ14c9CnYy2C1wMpHxqD7MaXceHSDcovNntr7utOM4hklqjP/WDtKstTSRFT4lIfuMzE+OkBvhZnaXpyxKZMFbYnIWeLLEKfRqazmOtCim6TKrJ07n1tqK4RBIVeU1FkqWw2IudjDX/OAJChBWRXTWKHMhJjLzDwH04JXk1VUSjcsrKTYo3ljfqV58KUBb2tzMAmRdjIIBD0FBH7HTcQmCXq58+nA3hihkmqZ9oDxwaPPTVq7n2MES68JqTtiGxsNazDZ/C5f4coUOmDpHhmCvMOvV4pUSz9wRYHyiIgvZqCsV149ujeiu5zuA8vGyIWbknUIPD+Sn+TIUkgocslcAkpLpGPKxhywr7dWXgl2TK6uMhW/MEfHr9lZYuDATKNpx500djEryRQH/tSavXjFTzkLzn43vhoTSoUTFW72Uy/5bTiOJ46t0iklX0X8Em67mh/YA6egaC7iNq+3c5XcwlLn+3BXRorGF4bZ1O+om0xjK6CN2975NBNlQ+1xEHcX2BuAdFQ0/1OR+5/IOZbtlq67U/hmk9kMxOj0fTzCK3AlJTKKjJ4f+gqgOsvRx8XE+8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3775.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(366004)(38100700002)(2906002)(478600001)(36756003)(2616005)(316002)(66556008)(186003)(31686004)(7416002)(110136005)(66574015)(83380400001)(8936002)(86362001)(66946007)(6486002)(921005)(8676002)(6666004)(5660300002)(31696002)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXJzbUJTa3EvVFUraXA0UHJIaENsaUs1Mk5xbGtBbkxJRGk0N3pSdFBMUDNM?= =?utf-8?B?ekZJME5QSUY4MFFueHo5QmVnN2phdHg4bU1YZDRsVkVCbDhKYytMaktEUWNq?= =?utf-8?B?ZS8vMEtVV2lucENKSzUvcVBsbWN3YklGaXBhNkhaekU0K0pwM1NQTmk2SytK?= =?utf-8?B?L3FKQkdWVTA0ZG1YWUdGNms4USsrN3BlcG81VDBEYyszTWNaWTU5NWlKaXE1?= =?utf-8?B?Mi8vUzFUdDR1dTJqQVliL0szQ2Vrc0R0a0Y4dUpHb1U0SnF1VXBnbDZBQXVt?= =?utf-8?B?V21FWElqY0M0QW5GU2hLNnhkb1FmUURpMmI1Rk9TY0tWTDMvbEQvMjZsZTh6?= =?utf-8?B?dG5JN3JvemliRlNWbFA2MGtYYmR1UXQvNUkzWEY3eFBydWJEZDBVanBEYkJw?= =?utf-8?B?a2ZocnVaTnZNUktORy9IMUwyaDB4cWJXSGUrNU1XVHdIdU1iWkVxYnN1M1d5?= =?utf-8?B?WUtERWpZd2tOeDI3MkJTUko5bFNNemJjOXl3V2NpL3FqTXBmK1BIYjlRVFVu?= =?utf-8?B?VXlySzlpYXJJT0hXQTBMZy81SGNjS1hLZUtBejE4MlBDVmtaM2w1YUVDYjVj?= =?utf-8?B?bEY0amN5S1k3TTZEbUpCRHYvYkt6S2hWOUdDTC94L3ZObVY1MnlWVC9Gdi9J?= =?utf-8?B?MXg3ejNTK3kvRS9FSTRXZjZBMHB4ZkNSWDdDMzVhQTdCVUt2aXU4SWpKUzF4?= =?utf-8?B?U3R5Ujl4cGhXcDhzNUFPZ3cwU0VFMlZXZjBPT3ZmLy9ITDlhWWhlTWljNzha?= =?utf-8?B?RW9ycGhuNXhQL1lLUUhqV2thdDQ3THJISWpsN2tvZUNGVDVaVTlBZWJreWR5?= =?utf-8?B?WVVQcUVYaWJWR1hWN1FmVGpLb3V2VFk0TlU1eTVwaXRENjA0QmFKM1plUjdM?= =?utf-8?B?UXpHckgyRjUyTzJNenVHbWVmeG9GQWFrdjlaZFV5QU40eHplazc0YVRaZlVj?= =?utf-8?B?S0RqNHpWT0YxVEVDVWt2T3ZETWdYNVk1NzBUNERkWTlocnJxNFhYbjR0U015?= =?utf-8?B?cHMvUGZSdzZXSlU3dm84bEVQQTFZb3RKK2JWeWw1Q1RoREtENEZyVWVBVU1r?= =?utf-8?B?dGd6MFNwT2lUMmpUSEJ1enkzYW5yZFBHMlF5VUVaWXNaNGo1L0dBa3BEK3Iw?= =?utf-8?B?MkdZZXNiOFliMHFzWVhvVkd1S1NYYmNIOEtQVW1hZXRtYmpnY0VYNmovNHo1?= =?utf-8?B?Y3o2M2h0U25jUmJkcjR6dDRITlQ1WjJZb2R6MndtUHVTRllUY0dLSEtaVVBO?= =?utf-8?B?OHVSR0VNV003R2tVTzIvb0p0ejMwZVpMR01Bb0M0MkFaUE9xR3BvOTdPaTRx?= =?utf-8?B?RmNEZjBWUWdadzExTjEzb3k0eldTMmVjVWZHd0N6M3RPd0RQK3RhdnlRVXh2?= =?utf-8?B?V3h0Z2kvL0FxYVhWN1F0Nm9VUm12RzJwMzdJRlgvOXlkNEd5ZlVmSjNvcG5P?= =?utf-8?B?YzRLWksvSzlUeTY2NkRCUEtYSlhNMXRuYnBJaWQ0YWl4ZzB5K2lvNFE5Ym5E?= =?utf-8?B?TkxhNkV3YU8xcG4xdzIwSFZKNEJweXN4Vll0Z3kyZHJWbHhsYVB5dFJuUExi?= =?utf-8?B?aFNqMzNURk4rVmxFVWI2dG5oeUM5T2xHVE9QUTRWdmtCVmJudHdMRVFlTWN5?= =?utf-8?B?Tjh1TXQ4VjJnTFVCbEREKzFjeCtFUzZXenFLSW1ndUhHYVBKZUNSWDFtNXVq?= =?utf-8?B?d0tVT0RiZ3pkbmZJTytvSWRpS2s5dExuMjRUNVJmajZGOEd3K3BuMnFIUWxz?= =?utf-8?B?WDVtbWFvdTJKUURsWHlkLzNLZzZicUExeXh1VUVib0U5MHg3eDVQVW4rOUd3?= =?utf-8?B?QnUxWEZWVVZ0SVJZdjJoL2c1YzZDSE1TSTBnUmZCOC96TUYrNmpiQjdMS2Mz?= =?utf-8?Q?1cBPNCvBLl2Vn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8bfe381-3a19-4d05-ac4c-08d9735ed8a8 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 06:55:45.2796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gZtBaUXvty48A6JKOwjwKmKg8d2Ej4WQiDHJRAUJc48WY84c0Q+pMA788KQ/kM9Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4755 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 08.09.21 um 20:00 schrieb Daniel Vetter: > On Fri, Sep 03, 2021 at 11:47:57AM -0700, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> drivers/dma-buf/dma-fence-array.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c >> index d3fbd950be94..8d194b09ee3d 100644 >> --- a/drivers/dma-buf/dma-fence-array.c >> +++ b/drivers/dma-buf/dma-fence-array.c >> @@ -119,12 +119,23 @@ static void dma_fence_array_release(struct dma_fence *fence) >> dma_fence_free(fence); >> } >> >> +static void dma_fence_array_set_deadline(struct dma_fence *fence, >> + ktime_t deadline) >> +{ >> + struct dma_fence_array *array = to_dma_fence_array(fence); >> + unsigned i; >> + >> + for (i = 0; i < array->num_fences; ++i) >> + dma_fence_set_deadline(array->fences[i], deadline); > Hm I wonder whether this can go wrong, and whether we need Christian's > massive fence iterator that I've seen flying around. If you nest these > things too much it could all go wrong I think. I looked at other users > which inspect dma_fence_array and none of them have a risk for unbounded > recursion. That should work fine or at least doesn't add anything new which could go boom. The dma_fence_array() can't contain other dma_fence_array or dma_fence_chain objects or it could end up in a recursion and corrupt the kernel stack. That's a well known limitation for other code paths as well. So Reviewed-by: Christian König for this one. Regards, Christian. > > Maybe check with Christian. > -Daniel > > >> +} >> + >> const struct dma_fence_ops dma_fence_array_ops = { >> .get_driver_name = dma_fence_array_get_driver_name, >> .get_timeline_name = dma_fence_array_get_timeline_name, >> .enable_signaling = dma_fence_array_enable_signaling, >> .signaled = dma_fence_array_signaled, >> .release = dma_fence_array_release, >> + .set_deadline = dma_fence_array_set_deadline, >> }; >> EXPORT_SYMBOL(dma_fence_array_ops); >> >> -- >> 2.31.1 >>