From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72F6CC83F33 for ; Mon, 4 Sep 2023 07:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:References:In-Reply-To: Subject:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=znQBy2+DT0QFCLsj+WNc2uKs42L2IHgLyC/bgE6cJCM=; b=vjILe7zL60WFiS V+qAWLo+g70vU2qdWNpPR6csoZEo4UU2bngPfux8GnH94aqUkdmSfUZHrbb3t4NfdbnbNGc/zau6D zWjmdaUYLo2m1VeORPmrTacw8prRIJxEwH7JXcPAAghZt9w2W7wS7xvz73J30CrmH/0PmD9oSaGNV mM3oqdK1oJncdEn7nTDBH1j3rXwTsFb2gO/Al/wit8rd8C/nt39KbozQmgahY5mIAAtTnZuRJ5fvj 5fd1DzAYnOaOpTQzR/QmDkROO8YPE3lKrlwLXFNzZKOKuEnoDPXWNSTmHqCG5YhXO+4itCpDSOO20 5a0PSA5ZAnkw6F4I4iuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qd4QT-003WCP-0x; Mon, 04 Sep 2023 07:55:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qd4QQ-003WBg-1R for linux-arm-kernel@lists.infradead.org; Mon, 04 Sep 2023 07:55:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88C356131F; Mon, 4 Sep 2023 07:55:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 780EFC433C8; Mon, 4 Sep 2023 07:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693814108; bh=hrumtQoV1/ACtGoSsBTZdx/2I2D/Z7gcCZhcW0zrn04=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=fedbdDOEevGhM4eFrSwwvCxC+lMbRQCn/Kk45uAI61D5+yf9T61g7cdwMKzNMgKwE 5CxaHynR/tzzj963O7X/bR7SbWRsbT/Ge7eNRNT9ntR1B0DbuDzQJhpyChN1Bf9W9/ dGbcLCsVpPIHrGA1aQd+s6/Dj7iCsOuYOxVufmwqLidf0ognf3hh0SH+Dd9L1q3DV7 UmSg+CxCxfRyLAJKtGdWxw3ddKJYc+T5BMD/2xSBL1BHM3H87SdbyFnN+UfmDf3bcS +ex24+ORJzpZ7QUCF/35NcWTCmU52S/ZPCcG2tUCCWEkV6Xf0vO0jGMN2rTtF2UbW2 cfPn18KN+rvfQ== Message-ID: Date: Mon, 04 Sep 2023 07:55:06 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 13/15] drm/imx/ipuv3: Call drm_atomic_helper_shutdown() at shutdown/unbind time In-Reply-To: <20230901164111.RFT.13.I0a9940ff6f387d6acf4e71d8c7dbaff8c42e3aaa@changeid> References: <20230901164111.RFT.13.I0a9940ff6f387d6acf4e71d8c7dbaff8c42e3aaa@changeid> Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, festevam@gmail.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, "Maxime Ripard" , "Sascha Hauer" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_005510_525780_44F3D995 X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 1 Sep 2023 16:41:24 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time > and at driver unbind time. Among other things, this means that if a > panel is in use that it won't be cleanly powered off at system > shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 391D3C83F33 for ; Mon, 4 Sep 2023 07:55:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4739E10E2E7; Mon, 4 Sep 2023 07:55:36 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E5F710E2C9 for ; Mon, 4 Sep 2023 07:55:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88C356131F; Mon, 4 Sep 2023 07:55:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 780EFC433C8; Mon, 4 Sep 2023 07:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693814108; bh=hrumtQoV1/ACtGoSsBTZdx/2I2D/Z7gcCZhcW0zrn04=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=fedbdDOEevGhM4eFrSwwvCxC+lMbRQCn/Kk45uAI61D5+yf9T61g7cdwMKzNMgKwE 5CxaHynR/tzzj963O7X/bR7SbWRsbT/Ge7eNRNT9ntR1B0DbuDzQJhpyChN1Bf9W9/ dGbcLCsVpPIHrGA1aQd+s6/Dj7iCsOuYOxVufmwqLidf0ognf3hh0SH+Dd9L1q3DV7 UmSg+CxCxfRyLAJKtGdWxw3ddKJYc+T5BMD/2xSBL1BHM3H87SdbyFnN+UfmDf3bcS +ex24+ORJzpZ7QUCF/35NcWTCmU52S/ZPCcG2tUCCWEkV6Xf0vO0jGMN2rTtF2UbW2 cfPn18KN+rvfQ== Message-ID: Date: Mon, 04 Sep 2023 07:55:06 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 13/15] drm/imx/ipuv3: Call drm_atomic_helper_shutdown() at shutdown/unbind time In-Reply-To: <20230901164111.RFT.13.I0a9940ff6f387d6acf4e71d8c7dbaff8c42e3aaa@changeid> References: <20230901164111.RFT.13.I0a9940ff6f387d6acf4e71d8c7dbaff8c42e3aaa@changeid> Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 1 Sep 2023 16:41:24 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time > and at driver unbind time. Among other things, this means that if a > panel is in use that it won't be cleanly powered off at system > shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03138C83F33 for ; Mon, 4 Sep 2023 07:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351912AbjIDHzP (ORCPT ); Mon, 4 Sep 2023 03:55:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350939AbjIDHzM (ORCPT ); Mon, 4 Sep 2023 03:55:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF66FF0 for ; Mon, 4 Sep 2023 00:55:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64BEC61314 for ; Mon, 4 Sep 2023 07:55:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 780EFC433C8; Mon, 4 Sep 2023 07:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693814108; bh=hrumtQoV1/ACtGoSsBTZdx/2I2D/Z7gcCZhcW0zrn04=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=fedbdDOEevGhM4eFrSwwvCxC+lMbRQCn/Kk45uAI61D5+yf9T61g7cdwMKzNMgKwE 5CxaHynR/tzzj963O7X/bR7SbWRsbT/Ge7eNRNT9ntR1B0DbuDzQJhpyChN1Bf9W9/ dGbcLCsVpPIHrGA1aQd+s6/Dj7iCsOuYOxVufmwqLidf0ognf3hh0SH+Dd9L1q3DV7 UmSg+CxCxfRyLAJKtGdWxw3ddKJYc+T5BMD/2xSBL1BHM3H87SdbyFnN+UfmDf3bcS +ex24+ORJzpZ7QUCF/35NcWTCmU52S/ZPCcG2tUCCWEkV6Xf0vO0jGMN2rTtF2UbW2 cfPn18KN+rvfQ== Message-ID: Date: Mon, 04 Sep 2023 07:55:06 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 13/15] drm/imx/ipuv3: Call drm_atomic_helper_shutdown() at shutdown/unbind time In-Reply-To: <20230901164111.RFT.13.I0a9940ff6f387d6acf4e71d8c7dbaff8c42e3aaa@changeid> References: <20230901164111.RFT.13.I0a9940ff6f387d6acf4e71d8c7dbaff8c42e3aaa@changeid> Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, festevam@gmail.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, "Maxime Ripard" , "Sascha Hauer" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Sep 2023 16:41:24 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time > and at driver unbind time. Among other things, this means that if a > panel is in use that it won't be cleanly powered off at system > shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime