From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>, Chuck Lever <cel@kernel.org>,
Kimi Security Team <bug-report@moonshot.ai>,
Yilin Zhang <yilinzhang@moonshot.ai>,
Bjoern Doebel <doebel@amazon.de>
Subject: Re: [PATCH 5.10.y v2] SUNRPC: Copy the deferred RPC Call from the head buffer
Date: Thu, 12 Nov 2026 21:33:11 -0500 [thread overview]
Message-ID: <daily-reply-2026-11-12-5417451315@kernel.org> (raw)
In-Reply-To: <20261112135550.982415-1-doebel@amazon.de>
On 2026-11-12, Bjoern Doebel wrote:
> [PATCH 5.10.y v2] SUNRPC: Copy the deferred RPC Call from the head buffer
> svc_defer() snapshots the RPC Call for replay once a pending cache
> upcall resolves. It copies the Call starting (rq_arg.len -
> head[0].iov_len) bytes before head[0].iov_base, a back-up that once
On 5.10 the RPC header is already consumed from head[0] before svc_defer()
runs, so the premise behind the new check in 2192a56b0686 ("SUNRPC: Copy the
deferred RPC Call from the head buffer"), rq_arg.len == head[0].iov_len,
doesn't hold. With it, nearly every request would be refused deferral.
Could you rework the 5.10 version so it doesn't change that behavior and send a
v3?
--
Thanks,
Sasha
prev parent reply other threads:[~2026-11-13 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 18:54 FAILED: patch "[PATCH] SUNRPC: Copy the deferred RPC Call from the head buffer" failed to apply to 5.10-stable tree gregkh
2026-11-12 13:40 ` [PATCH 5.10.y] SUNRPC: Copy the deferred RPC Call from the head buffer Bjoern Doebel
2026-11-12 13:55 ` [PATCH 5.10.y v2] " Bjoern Doebel
2026-11-13 2:33 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daily-reply-2026-11-12-5417451315@kernel.org \
--to=sashal@kernel.org \
--cc=bug-report@moonshot.ai \
--cc=cel@kernel.org \
--cc=doebel@amazon.de \
--cc=stable@vger.kernel.org \
--cc=yilinzhang@moonshot.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.