From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com, bvanassche@acm.org,
avri.altman@sandisk.com, alim.akhtar@samsung.com,
wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
alice.chao@mediatek.com, cc.chou@mediatek.com,
chaotian.jing@mediatek.com, tun-yu.yu@mediatek.com,
naomi.chu@mediatek.com, ed.tsai@mediatek.com
Subject: Re: [PATCH 6.18.y] scsi: ufs: core: Re-arm the device command completion before submitting
Date: Tue, 15 Sep 2026 21:52:13 -0400 [thread overview]
Message-ID: <daily-reply-20260915-0008-re-ufs-dev-cmd-completion@kernel.org> (raw)
In-Reply-To: <20260915052638.459390-1-alice.chao@mediatek.com>
> Re-arm the completion in ufshcd_issue_dev_cmd(), immediately before
> submitting. All submitters - ufshcd_exec_dev_cmd(),
> ufshcd_issue_devman_upiu_cmd() and ufshcd_advanced_rpmb_op() - reach it
> holding hba->dev_cmd.lock, so no extra serialization is needed.
The analysis reads correct to me and the patch is clean against 6.18, but
this is a stable only change in the UFS core completion path with no
mainline counterpart, since 08b12cda6c44 ("scsi: ufs: core: Switch to
scsi_get_internal_cmd()") deleted this code outright. I would like a
subsystem ack before queueing it.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-09-16 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 5:26 [PATCH 6.18.y] scsi: ufs: core: Re-arm the device command completion before submitting alice.chao
2026-09-15 5:36 ` sashiko-bot
2026-09-16 1:52 ` Sasha Levin [this message]
2026-10-05 8:34 ` Alice Chao
2026-10-05 11:54 ` Bean Huo
2026-10-06 9:55 ` Alice Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daily-reply-20260915-0008-re-ufs-dev-cmd-completion@kernel.org \
--to=sashal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@sandisk.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=tun-yu.yu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.