[cocci] Spatch corrupting struct variable

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

Hi all,

I'm at total loss what coccinelle/spatch is trying to do here:

@@
struct resource *res;
expression size;
@@
- res->end = res->start + size - 1;
+ resource_set_size(res, size);

Spatching against Linux kernel tree results in this corruption:

HANDLING: drivers/bus/fsl-mc/fsl-mc-bus.c
diff = 
diff -u -p a/fsl-mc-bus.c b/fsl-mc-bus.c
--- a/fsl-mc-bus.c
+++ b/fsl-mc-bus.c
@@ -736,7 +736,7 @@ static int fsl_mc_device_get_mmio_region
                        goto error_cleanup_regions;
                }
 
-               regions[i].end = regions[i].start + region_desc.size - 1;
+               resource_set_size(regions, region_desc.size);
                regions[i].name = "fsl-mc object MMIO region";
                regions[i].flags = region_desc.flags & IORESOURCE_BITS;
                regions[i].flags |= IORESOURCE_MEM;

??? How did that [i] vanish from regions? Why spatch thought . and -> are 
equal?

$ spatch --version
spatch version 1.1.0 compiled with OCaml version 4.11.1
Flags passed to the configure script: --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib --enable-ocaml --enable-python --enable-opt
OCaml scripting support: yes
Python scripting support: yes
Syntax of regular expressions: PCRE


--
 i.