From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD3BC282CB for ; Sat, 9 Feb 2019 17:28:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63E3121939 for ; Sat, 9 Feb 2019 17:28:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fcV8bKXa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="io6gJ4n5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63E3121939 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To: Subject:To:From:Date:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FIo6x6pFcKapB45Xy0/H/OvweuHa7EiBGehYV1Huhig=; b=fcV8bKXaw6itjq q/Cm0QDz2jWae98A0s8aVJb3rPZl7TgGpnrH1Kf99MEz6GsP+kVcasNKJYJpd4k+7M/qJCGCuDOR4 h/JFni0nLI/lKRY6aSpRj+3z1m3BidGLfJMHugbpTy/YtZpRxdfbdfzx53Ulr3GWLP2eGCWRJHLsb IOP0Vo/vBulys4ZVPygqjyqxIk69OqN2mKC3y1tX5lXF8VaA3HiReg+v6pgSctvhKiJDlmjP2OtKP TY2+YxesMjj285Za7V0mnTxikSx1SdIhgIWfhyD1noC9YDA0SKsC6iCtXTlLOEeS885gSJjkObuYq D/Uak/U5dH5FYEqgPtlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsWQh-0005JR-CS; Sat, 09 Feb 2019 17:28:39 +0000 Received: from mail.kmu-office.ch ([2a02:418:6a02::a2]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsWQd-0005Id-1b for linux-arm-kernel@lists.infradead.org; Sat, 09 Feb 2019 17:28:37 +0000 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 7CA545C1E69; Sat, 9 Feb 2019 18:28:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1549733305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PW8zfQNBUwSdLd/R0RaFY9UOCwcevFz+HFnUPe87atQ=; b=io6gJ4n5U+HR4miJoeDVnMdccujW0ZscC2xbNXYvqtM5sASYiREoFppsdE8b2TgHYiBJyX TA0pGw87laYtP1Zyh2emQy5+3qDotXzn9DE3uo3j1ynkdr+MK4ajakqC3gmbrwTLdCmaWt U3bKBJ2px0PF10y8WxckJ5McF5oWvJY= MIME-Version: 1.0 Date: Sat, 09 Feb 2019 18:28:25 +0100 From: Stefan Agner To: linux@armlinux.org.uk Subject: Re: [PATCH 4/5] ARM: use unified assembler in c files In-Reply-To: References: Message-ID: X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190209_092835_384825_CAF40404 X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nicolas.pitre@linaro.org, mark.rutland@arm.com, arnd@arndb.de, ard.biesheuvel@linaro.org, will.deacon@arm.com, julien.thierry@arm.com, ndesaulniers@google.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, natechancellor@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for the reviews so far. During some more testing I stumbled upon another issue: On 07.02.2019 10:48, Stefan Agner wrote: > Use unified assembler syntax (UAL) in inline assembler. Divided > syntax is considered depricated. This will also allow to build > the kernel using LLVM's integrated assembler. > > Signed-off-by: Stefan Agner > --- > arch/arm/mm/copypage-v4mc.c | 2 +- > arch/arm/mm/copypage-v4wb.c | 2 +- > arch/arm/mm/copypage-v4wt.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mm/copypage-v4mc.c b/arch/arm/mm/copypage-v4mc.c > index b03202cddddb..b19c7ad1a6de 100644 > --- a/arch/arm/mm/copypage-v4mc.c > +++ b/arch/arm/mm/copypage-v4mc.c > @@ -56,7 +56,7 @@ static void mc_copy_user_page(void *from, void *to) > ldmia %0!, {r2, r3, ip, lr} @ 4\n\ > subs %2, %2, #1 @ 1\n\ > stmia %1!, {r2, r3, ip, lr} @ 4\n\ > - ldmneia %0!, {r2, r3, ip, lr} @ 4\n\ > + ldmiane %0!, {r2, r3, ip, lr} @ 4\n\ > bne 1b @ " > : "+&r" (from), "+&r" (to), "=&r" (tmp) > : "2" (PAGE_SIZE / 64) > diff --git a/arch/arm/mm/copypage-v4wb.c b/arch/arm/mm/copypage-v4wb.c > index cd3e165afeed..6e3c9b69dd25 100644 > --- a/arch/arm/mm/copypage-v4wb.c > +++ b/arch/arm/mm/copypage-v4wb.c > @@ -38,7 +38,7 @@ static void v4wb_copy_user_page(void *kto, const void *kfrom) > ldmia %1!, {r3, r4, ip, lr} @ 4\n\ > subs %2, %2, #1 @ 1\n\ > stmia %0!, {r3, r4, ip, lr} @ 4\n\ > - ldmneia %1!, {r3, r4, ip, lr} @ 4\n\ > + ldmiane %1!, {r3, r4, ip, lr} @ 4\n\ > bne 1b @ 1\n\ > mcr p15, 0, %1, c7, c10, 4 @ 1 drain WB" > : "+&r" (kto), "+&r" (kfrom), "=&r" (tmp) > diff --git a/arch/arm/mm/copypage-v4wt.c b/arch/arm/mm/copypage-v4wt.c > index 8614572e1296..4a40fa1cbc2a 100644 > --- a/arch/arm/mm/copypage-v4wt.c > +++ b/arch/arm/mm/copypage-v4wt.c > @@ -34,7 +34,7 @@ static void v4wt_copy_user_page(void *kto, const void *kfrom) > ldmia %1!, {r3, r4, ip, lr} @ 4\n\ > subs %2, %2, #1 @ 1\n\ > stmia %0!, {r3, r4, ip, lr} @ 4\n\ > - ldmneia %1!, {r3, r4, ip, lr} @ 4\n\ > + ldmiane %1!, {r3, r4, ip, lr} @ 4\n\ > bne 1b @ 1\n\ > mcr p15, 0, %2, c7, c7, 0 @ flush ID cache" > : "+&r" (kto), "+&r" (kfrom), "=&r" (tmp) When compiling with gcc, this leads to: /tmp/ccrvA1wy.s: Assembler messages: /tmp/ccrvA1wy.s:180: Error: bad instruction `ldmiane r0!,{r3,r4,ip,lr}' make[1]: *** [scripts/Makefile.build:277: arch/arm/mm/copypage-v4wb.o] Error 1 make: *** [Makefile:1042: arch/arm/mm] Error 2 Unfortunately, the gcc option -masm-syntax-unified which allows unified syntax in inline assembly is broken (see also https://lkml.org/lkml/2019/1/7/1320). So this requires to sprinkle those inline assembly with ".syntax unified" strings, similar to how I've done it in uaccess.h. -- Stefan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel