From: Florian Fainelli <f.fainelli@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>, Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH] Documentation: firmware: Clarify firmware path usage
Date: Tue, 11 Apr 2023 15:21:31 -0700 [thread overview]
Message-ID: <db25c4cb-e786-d17c-d82a-c2450f4226a2@gmail.com> (raw)
In-Reply-To: <87wn2i9i3l.fsf@meer.lwn.net>
On 4/11/23 15:20, Jonathan Corbet wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
>> On Mon, Apr 10, 2023 at 04:12:32PM -0700, Florian Fainelli wrote:
>>> I was not sure whether it was on purpose or not, Greg, will we break
>>> anyone's use case if we strip off \n from the firmware path passed via
>>> sysfs?
>>
>> I do not know, sorry.
>
> I would be amazed if anybody is putting newlines into their firmware
> path; that would be kind of a silly thing to do.
>
> That said, I've been amazed before.
>
> I'll go ahead and apply the docs patch, but it still doesn't really seem
> like the right fix to me.
I will submit a patch that strips off newlines from sysfs provided
firmware paths and if this turns out to break someone's use case it
could still be reverted, sounds good?
--
Florian
next prev parent reply other threads:[~2023-04-11 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 13:54 [PATCH] Documentation: firmware: Clarify firmware path usage Florian Fainelli
2023-04-10 22:43 ` Jonathan Corbet
2023-04-10 23:12 ` Florian Fainelli
2023-04-11 6:02 ` Greg KH
2023-04-11 22:20 ` Jonathan Corbet
2023-04-11 22:21 ` Florian Fainelli [this message]
2023-04-12 6:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db25c4cb-e786-d17c-d82a-c2450f4226a2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.