From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9F5BC433FE for ; Mon, 7 Nov 2022 17:00:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5561984BDB; Mon, 7 Nov 2022 18:00:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="KDOd65oo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1538484A9C; Mon, 7 Nov 2022 18:00:27 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 30DE584DF9 for ; Mon, 7 Nov 2022 18:00:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WQUsYsC/zM6Cf+ZKeKFC4HW42J0frPPfqO+S72Ec6BnYdt6sLwntlIg3pIaymyL8S6AmG5KKqXk1zfoFhhaAi0RE5+kdOiYYWUQT11gskue1vaJOBz0V8R60hLCtaTtPMGQFvjhmCV8VTn6i5xzgDXcHX7/rLFH15D7tfQuylQCiRXlwgYQIzAAyLOZk4oQhBp97mlmJ1twBYrmKESIfEausnzJNeRVQOi4+8QeyGNS4E7D6mMdy/cf35o3BYFVjOdLgdLJzMkzkmW5ugIWyyvRZzyPCE62bWgTM4B5ezzM7/B+fvToBB7au3//Af41o2eUfvZhALmmGAiyMiDqIcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7ETzJ8YTlYwPjET/HvOxeKJ/7xTcdU2P6tETRCUDDug=; b=TyP1lSxeYrWNu07tXvLPWBkdvD/fOIFYyu0FpUX4S3rOnNYKCgo8vIo51GtyCA+VoZ+zpz0lDTdHWITDs9h+IwS9gwIVjoXGxabCo7mNGvKsrUHS6wgw5RnwAcMEc90ur9eMkF45O1NmJ0jtkAK+EYRP1wjEKiWjyNn/zeeKMei7T7zvGol+oKTvhS+foKoBP0122Ss2Y7N8dkN/4GjGXXX7khPsORX9eHrvReAnRxtIKubPIgG/a+NaFBi2wH7127mplugs8L11Uj1JnAqU1RTLMz31LdSvNT+ffH/zLgBnfPkxhn7+uAUe8sDdxKWOcUKk/Q4wUfjCvDtG7Ot1hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ETzJ8YTlYwPjET/HvOxeKJ/7xTcdU2P6tETRCUDDug=; b=KDOd65oo8Wcx57J3uAE5r0TSIe+sdSfXgWK5NxcBOaZFWf5zxDjtyXwZTcP53cAObZlCx2bEomiPOe6VXVfFbRKjoU/s4kfNkf70u1/3zDcn8IaeUpybulQs+T99OSHnjs7rTaMvpvhP8bDJeJc256Y2dcjaEkyJizhS7J3ZUNHUSAudcI8A3NzKKgWg8zQ7bz2MTA2rQxO7VtCJkOHcVkZrkd63Z/A6+ipywKdsPacHCYq0aBPa/UnJrYlTgoRzgLKF6DtS2lEcl5g3oAX7H6ALN251uf3HakqQK7HBCkHkDsIWE4GaRhd2IBSJ88ixc4A20xM9ypnr3lmUdeDKog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DB9PR10MB6003.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:39e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Mon, 7 Nov 2022 17:00:21 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::5d9b:b9d1:bd69:107b]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::5d9b:b9d1:bd69:107b%4]) with mapi id 15.20.5791.025; Mon, 7 Nov 2022 17:00:21 +0000 Message-ID: Date: Mon, 7 Nov 2022 18:00:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 2/3] efi_loader: Set default console colors on efi_cout_clear_screen if needed Content-Language: en-US From: Jan Kiszka To: Heinrich Schuchardt References: <4b7a28d04119ae529a2dc1a16dec50fb39c74f17.1667549199.git.jan.kiszka@siemens.com> Cc: U-Boot Mailing List In-Reply-To: <4b7a28d04119ae529a2dc1a16dec50fb39c74f17.1667549199.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::10) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DB9PR10MB6003:EE_ X-MS-Office365-Filtering-Correlation-Id: 72066e7f-3562-46cb-cb83-08dac0e18e79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r3GXgHmfOmIshbyHhYTaI4QPtU2Tfv24JRhtdXMUhp3QdGozJGjYe3kijAipt2aKHOOm3SD+5EJccw+dKjR7fYtaPPDeAu0UIMKKc4jzYxrNCnper6/e4fMfSuztc2+aAspKqp3JK8AgBqTE747xxllciHAcjn2sgTMoe46keAHPrHLG8KAAgv0bjJdGT72Vw5wa1LtQW/0HVoIaQFdvAODOIGdYfJ/QOYBjah69mcj5BN849ELYDprT9EPtr6udw0EKEWvF4vtfgIR3ucikhpnYCAnQT9Xx2Hx9hi9TZt75MvYER6HqAYQ7kmplCse93AecuUoMIcUr7h5w/I+KwqdBCNrCO6j/P2SXMdNPrgH6XwfQ8bwWR4dY9J2HGxj0t88G2WjCbrZGMsn/k+jGzd0wq7uHBhj9iiHQqCpkKcGNRu7ZA/wSWP0iMiI0c8//Ur81v8avV+rtazR71y7v7k9XUHEfmTrHY1Ezdd3YYKO8lwBvkNoK/YwqwOd7ZpZWch4rZtsqFaYmI5ZdjJDWNTtj2/N90QHaA7sZmKK/VmDyAYRUX82I5fmx04EODYQ+uMbQOikA3RxKGhz4KFI4TGBzLrh71fxBr3wgX+JZLqdkaVKkrqrsACAye846FqwdceXBybP0ZlT0ZQqA8T/8e71Hztc/sowEo/IzwkuGhguoUBxku4vAjsEYsAh+l0+n1uDj+pbcO2y3+yhJ+QanPbbVK/WMI03OqH2IF0nQSuneXHbHY+naTs93H4aZ89AGcOgncy1+iN/APBfAhNX97HFVoRPa/+T2kRuR+2DbCpk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(366004)(451199015)(86362001)(31696002)(66946007)(66556008)(186003)(4326008)(8676002)(66476007)(316002)(6916009)(26005)(38100700002)(6512007)(82960400001)(44832011)(8936002)(5660300002)(4744005)(41300700001)(2616005)(2906002)(36756003)(6486002)(478600001)(31686004)(6506007)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OW8zNGFyS1U4azI0U2RPanlTN0tzMWNTbGI4Y1JiUGVSc3c0ZitXMVhxL0N6?= =?utf-8?B?bmxoY2ZmcnJJN1ZzRFdySWRGeHRXRkZrdklrbWhFdUovS21XUW1KT0xyVjNF?= =?utf-8?B?TVNLcDRRR3ExL3c0MytvTzU3NkZVWnlwSVZ5a3pRbU1WZk9HcnZ1L1dodWUy?= =?utf-8?B?WWZURmVkemZ1ZEE2VndjMFNtKzJibjh6dThJakdROHN0eUtVeTBFVHE5dTBv?= =?utf-8?B?RFlzTlRVMDJHaHNhZE1nUG9xZEtVTFRkTzZMTmdYS01HS0ppQzNPSE1QV2pP?= =?utf-8?B?dytMVkhURXBNbkNORVdQek5ZTjZRR1BIK2pQaHFDemVJTjhBNmRjSnB6Nm16?= =?utf-8?B?bDJGZHJ2dUUzdW9hVGVYVFVzMTdYZUhZMUFuaUk4T2U2RFl4cVNUM0JvTW9J?= =?utf-8?B?N3pXTGpVajN6VERFTVc5VmhVZUdReFltVlI0TjJiZXdxV3FKakEzTFowaU1k?= =?utf-8?B?NDgwaXlseXN2NExsS2QrTnJDNzhHTElpcUMrdWc0OWZCOVFCZ2I3bjN1UXR2?= =?utf-8?B?SlhGbFhlempyckV5VU1DS2tUTWhZZGI1eW1yNkU0UzhJMmpYZ1E4USthUDBm?= =?utf-8?B?OExTWWtHc1U0SVVxekk0K3JZSFRyZTBhYWk3SE1ldklzM1hvejVqUnFHdTV1?= =?utf-8?B?N0NZMmV4VkdNYnRqNGRXNkxqNitOVTVhZi80cDdadTBlVjdqWENGUG5jS0g4?= =?utf-8?B?MXpZVmk4WjVVRXZRKzJnYU40c1FhYUs3OWxoSCtZdXh2elFqdHQzSlg2Yitt?= =?utf-8?B?YVlURmRwWmtaaGZIZ2JDZmMwY0VFWHNpNTJuY0NvZytERVNlNkRja0lzc0ZR?= =?utf-8?B?NXAwcWkwRGxDbmlKeTRROWZ2Q2VtYUpHWlFEeFV4emJMSUpTZDBnZkVhNUFD?= =?utf-8?B?OXdSSTNpSkNXSHlMWVJYRG14b0ZRbzNBZkNnVC9DZnJFL3NLcmlEVFlZRno4?= =?utf-8?B?MEdLS3BUc3g1aW5EdzFIU1RHMHBvN3pNUlYvYUdLem9TOHlWR0haK0JENWdj?= =?utf-8?B?MTc5Q29SYWs3M2dEOTBoVmZHbmp2RzlJenAya203Nk1ieExBQTlONXoyMlk3?= =?utf-8?B?MlYvZllseDZJNkJJZlZyaU5sL3k3TlJYd3ZLamJNbkhhOFVtYUFEMkhxblU1?= =?utf-8?B?UkRPVXlzQUV3WW1IT2IrbVdiV0VKTU96M04ydTd3VGNFYk1peHp2a3ZXeXdL?= =?utf-8?B?Y29IYkJERW9ZcGVVTW92VFZONko3SkZTaUhRWEtleDNrRkxjdFhGdEZRMUNh?= =?utf-8?B?QWtQSHVxTStTM3dvelkvMEkyY0hnaWp2SjRENklWS1N5UUE5NkRJNEJEOEV1?= =?utf-8?B?WE5MMXR1WHp3dUhsTDNGVWthd0YzWmxmYklaNHdGeURqSEpTUHlHQXZmU25k?= =?utf-8?B?bFFVejhvM1NkZlVVdHdNMzk1WkRzVEtJa0cxdkYyeVB3K01xQjlVQXgyZWRX?= =?utf-8?B?dGkyS2ZicWE1clcvOGFtelVsMlZ2ZmEvMmRabGdkNjFIaTBleW91dDhaWHJj?= =?utf-8?B?VlZmOWNBT1ZQU05id1lnUm1Xa2lOU056elpPNThobjhwNlRaU3RWSWd6WHE2?= =?utf-8?B?NFN6S1hSdHNDTStncGFUM2ZVRHdaNWY2UEVvOW5IRmlWUjlOMjV6aXExZnpk?= =?utf-8?B?VENDaXhadG12SU54bE56aFJjVkEzMG81ZGtiQnFRN2dhenRrMExMZG9tOEpq?= =?utf-8?B?SlFlUUVSRDU4VE12c0N3UEt6K1lrdGFYa3RYT3pvTlFnTXJ3V08yRytpa2Ez?= =?utf-8?B?emt1RzF3QmVmc2tFWmptdlBXdzhOKzBqRWNxcU9Fb2l6UkVvMlBocjN3MHJR?= =?utf-8?B?M1JKODF4QlkzOVpRcG1YSUc4MG5IdHlOYzc3Zk03MmxteHhGOVpBSkl4WEFQ?= =?utf-8?B?QmJBTkIwMkF2eVFYUm1yNXNFRjFjaHg2TjdldHZXeXRMTmVyaUR3ZXFFRmVr?= =?utf-8?B?aHB1bllBSG9kVHkxZm5ucGpzNWxkeEY1NzBZbDdLVE1SMUt0V3F5b1FzZXN6?= =?utf-8?B?ZkpQTlcwTUdHVXZLQXZlSVN5RGRzTW16dk8wV25SQysrdjgwRzdjMFUvbytp?= =?utf-8?B?cjdtOE82VFZwbUFLcmVCZDd3b1JmSTBubnhPelRZa0o3QjlEaG1ZRzA5UktE?= =?utf-8?B?aDV0R0RwTTFwNThBWnBINFk2R09lbWhBQXQzbjRITFNRSkkySms2c0Y5d3VL?= =?utf-8?B?ckE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72066e7f-3562-46cb-cb83-08dac0e18e79 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 17:00:21.8429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1FnbzYfvr1XrKIXjsiXou/Zk4lNGEBhUKGXBYgWNsnjzNHuwsS6TaZgd84EUCkKW0HqOyZwhn7xJzV9+/xzYGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB6003 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 04.11.22 09:06, Jan Kiszka wrote: > From: Jan Kiszka > > Ensures a consistent background color of the whole screen for succeeding > outputs as both demanded by the spec and implemented in EDK2 as well. > > Signed-off-by: Jan Kiszka > --- > lib/efi_loader/efi_console.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c > index 6ce0fcc168d..4228a509caf 100644 > --- a/lib/efi_loader/efi_console.c > +++ b/lib/efi_loader/efi_console.c > @@ -495,6 +495,12 @@ static efi_status_t EFIAPI efi_cout_clear_screen( > { > EFI_ENTRY("%p", this); > > + /* Set default colors if not done yet */ > + if (efi_con_mode.attribute == 0) { > + efi_con_mode.attribute = 0x07; > + printf(ESC "[0;37;40m"); > + } > + > efi_clear_screen(); > > return EFI_EXIT(EFI_SUCCESS); And what about this visual fix? It does not depend on patch 1. Jan -- Siemens AG, Technology Competence Center Embedded Linux