From: Frederik.Juul@3shape.com (Frederik Juul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] IMX: Rearm watchdog after loading value for restart
Date: Fri, 28 Apr 2017 12:45:15 +0000 [thread overview]
Message-ID: <db36b4c832db4b75b4cb3fa7b19635f6@3shape.com> (raw)
In-Reply-To: <20170428120329.2dab740f@ipc1.ka-ro>
Disregard this patch then :) I had seen some strange behavior when toying with watchdog where it didn?t reset properly and wrote the "something went wrong" message. This patch fixed it for me, but I guess I may have misunderstood the issue.
Frederik Juul
-----Original Message-----
From: Lothar Wa?mann [mailto:LW at KARO-electronics.de]
Sent: 28. april 2017 12:03
To: frederikj at gmail.com
Cc: linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org; fabio.estevam at nxp.com; kernel at pengutronix.de; Frederik Juul <Frederik.Juul@3shape.com>
Subject: Re: [PATCH] IMX: Rearm watchdog after loading value for restart
Hi,
On Thu, 27 Apr 2017 15:14:34 +0200 frederikj at gmail.com wrote:
> When calling the restart function the watchdog is activated and the
> WDOG timeout field is set to 0. This gives a reset time of 500 ms,
> which is consistent with the following delay. However this new time is
> not loaded into the WDOG until the WDOG service routine is run (see
> IMX6SXRM section
> 70.5.1.1 "Servicing WDOG to reload the counter").
>
> Not reloading the counter could result in a random delay up to 128
> seconds before the system restarts, depending on the previous value of
> the WDOG timeout field and when it has last been serviced. That bug is
> fixed with this patch.
>
The routine is actually initiating a softreset by clearing the SRS bit in WCR. Thus the watchdog timeout should only have any effect, if the softreset fails in some way. Under normal circumstances the reset should happen immediately no matter what watchdog timeout is programmed.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________
prev parent reply other threads:[~2017-04-28 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 13:14 [PATCH] IMX: Rearm watchdog after loading value for restart frederikj at gmail.com
2017-04-27 19:57 ` Baruch Siach
2017-04-28 10:03 ` Lothar Waßmann
2017-04-28 12:45 ` Frederik Juul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db36b4c832db4b75b4cb3fa7b19635f6@3shape.com \
--to=frederik.juul@3shape.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.