All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
	TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:AMD PMF DRIVER" <platform-driver-x86@vger.kernel.org>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Armin Wolf" <W_Armin@gmx.de>
Subject: Re: [PATCH v4 1/2] Input: Add a Kconfig to emulate KEY_SCREENLOCK with META + L
Date: Sat, 26 Apr 2025 18:44:54 -0500	[thread overview]
Message-ID: <db4dfc85-ce8b-4922-9558-670c3bb6eff2@kernel.org> (raw)
In-Reply-To: <aA0o2SWGtd/iMYM2@duo.ucw.cz>



On 4/26/25 13:41, Pavel Machek wrote:
> Hi!
> 
>>>> In the PC industry KEY_SCREENLOCK isn't used as frequently as it used
>>>> to be. Modern versions of Windows [1], GNOME and KDE support "META" + "L"
>>>> to lock the screen. Modern hardware [2] also sends this sequence of
>>>> events for keys with a silkscreen for screen lock.
>>>>
>>>> Introduced a new Kconfig option that will change KEY_SCREENLOCK when
>>>> emitted by driver to META + L.
>>>
>>> Fix gnome and kde, do not break kernel...
>>
>> I'm sorry; fix them to do what exactly?  Switch to KEY_SCREENLOCK?
>>
>> That's going to break modern hardware lockscreen keys.  They've all
>> obviously moved to META+L because that's what hardware today uses.
> 
> Gnome / KDE should accept either META+L _or_ KEY_SCREENLOCK to do the
> screen locking, no?
> 

This was actually the first path I looked down before I even started the 
kernel patch direction for this problem.

GNOME doesn't support assigning more than one shortcut key for an action.

  reply	other threads:[~2025-04-26 23:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 16:29 [PATCH v4 1/2] Input: Add a Kconfig to emulate KEY_SCREENLOCK with META + L Mario Limonciello
2025-04-25 16:29 ` [PATCH v4 2/2] platform/x86/amd: pmf: Use META + L for screen lock command Mario Limonciello
2025-04-26  8:15 ` [PATCH v4 1/2] Input: Add a Kconfig to emulate KEY_SCREENLOCK with META + L Pavel Machek
2025-04-26 13:00   ` Mario Limonciello
2025-04-26 18:41     ` Pavel Machek
2025-04-26 23:44       ` Mario Limonciello [this message]
2025-04-27  6:10         ` Pavel Machek
2025-04-27 12:15           ` Mario Limonciello
2025-04-28  5:30             ` Dmitry Torokhov
2025-04-28  5:51               ` Dmitry Torokhov
2025-04-28 13:50                 ` Mario Limonciello
2025-04-28 14:10                   ` Hans de Goede
2025-04-28  5:52               ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db4dfc85-ce8b-4922-9558-670c3bb6eff2@kernel.org \
    --to=superm1@kernel.org \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=W_Armin@gmx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.