From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Colton Lewis <colton.w.lewis@protonmail.com>,
alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
lgirdwood@gmail.com
Subject: Re: Fwd: [PATCH] snd/soc: correct trivial kernel-doc inconsistency
Date: Wed, 24 Jun 2020 10:20:22 -0500 [thread overview]
Message-ID: <db6d3b05-33c1-91b9-d0b4-c5063ebafcae@linux.intel.com> (raw)
In-Reply-To: <4574918.31r3eYUQgx@laptop.coltonlewis.name>
On 6/20/20 9:09 PM, Colton Lewis wrote:
> Can some please accept or comment on this patch?
It's a valid fix, I added the same change in the SOF tree yesterday but
you beat me to it.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
You probably want to resend and CC: Takashi and Mark.
>
> ---------- Forwarded Message ----------
>
> Subject: [PATCH] snd/soc: correct trivial kernel-doc inconsistency
> Date: Saturday, June 13, 2020, 9:29:08 PM CDT
> From: Colton Lewis <colton.w.lewis@protonmail.com>
> To: lgirdwood@gmail.com
> CC: trivial@kernel.org, Colton Lewis <colton.w.lewis@protonmail.com>
>
>
>
> Silence documentation build warning by correcting kernel-doc comment
> for snd_soc_runtime_action.
>
> ./sound/soc/soc-pcm.c:220: warning: Function parameter or member 'action' not described in 'snd_soc_runtime_action'
>
> Signed-off-by: Colton Lewis <colton.w.lewis@protonmail.com>
> ---
> sound/soc/soc-pcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index 2c114b4542ce..9ab376844ac1 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -208,6 +208,7 @@ static inline void dpcm_remove_debugfs_state(struct snd_soc_dpcm *dpcm)
> * PCM runtime components
> * @rtd: ASoC PCM runtime that is activated
> * @stream: Direction of the PCM stream
> + * @action: Activate stream if 1. Deactivate if -1.
> *
> * Increments/Decrements the active count for all the DAIs and components
> * attached to a PCM runtime.
>
next prev parent reply other threads:[~2020-06-24 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 2:09 Fwd: [PATCH] snd/soc: correct trivial kernel-doc inconsistency Colton Lewis
2020-06-24 15:20 ` Pierre-Louis Bossart [this message]
2020-06-26 5:40 ` Colton Lewis
2020-06-26 14:35 ` Pierre-Louis Bossart
2020-06-26 15:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db6d3b05-33c1-91b9-d0b4-c5063ebafcae@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colton.w.lewis@protonmail.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.