From: Jens Axboe <axboe@kernel.dk>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>, manas18244@iiitd.ac.in
Cc: "FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Anup Sharma" <anupnewsmail@gmail.com>,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3 1/3] rust: block: simplify Result<()> in validate_block_size return
Date: Mon, 18 Nov 2024 09:10:00 -0700 [thread overview]
Message-ID: <db75c787-8deb-4522-b4f7-ab26b164fce5@kernel.dk> (raw)
In-Reply-To: <CANiq72mzCSmLG0_Vqu=sCO7TBPzXtea3HPw5TjT_gYKEh7_1NA@mail.gmail.com>
On 11/18/24 9:05 AM, Miguel Ojeda wrote:
> On Mon, Nov 18, 2024 at 3:37?PM Manas via B4 Relay
> <devnull+manas18244.iiitd.ac.in@kernel.org> wrote:
>>
>> From: Manas <manas18244@iiitd.ac.in>
>>
>> `Result` is used in place of `Result<()>` because the default type
>> parameters are unit `()` and `Error` types, which are automatically
>> inferred. Thus keep the usage consistent throughout codebase.
>>
>> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
>> Link: https://github.com/Rust-for-Linux/linux/issues/1128
>> Signed-off-by: Manas <manas18244@iiitd.ac.in>
>
> If block wants to pick this one up independently:
>
> Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
I can grab it.
--
Jens Axboe
next prev parent reply other threads:[~2024-11-18 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 14:36 [PATCH v3 0/3] rust: simplify Result<()> uses Manas
2024-11-18 14:36 ` Manas via B4 Relay
2024-11-18 14:36 ` [PATCH v3 1/3] rust: block: simplify Result<()> in validate_block_size return Manas
2024-11-18 14:36 ` Manas via B4 Relay
2024-11-18 16:05 ` Miguel Ojeda
2024-11-18 16:10 ` Jens Axboe [this message]
2024-11-18 16:19 ` Manas
2024-11-18 14:36 ` [PATCH v3 2/3] rust: uaccess: simplify Result<()> in bytes_add_one return Manas
2024-11-18 14:36 ` Manas via B4 Relay
2024-11-18 20:10 ` Boqun Feng
2024-11-18 14:37 ` [PATCH v3 3/3] rust: macros: simplify Result<()> in function returns Manas
2024-11-18 14:37 ` Manas via B4 Relay
2024-11-18 20:28 ` Boqun Feng
2024-11-18 16:11 ` (subset) [PATCH v3 0/3] rust: simplify Result<()> uses Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db75c787-8deb-4522-b4f7-ab26b164fce5@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=anupnewsmail@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=manas18244@iiitd.ac.in \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.