From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41C70CD342E for ; Tue, 3 Sep 2024 13:19:31 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1slTRQ-0005Nf-Cx; Tue, 03 Sep 2024 13:19:28 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1slTRO-0005NR-GW for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Sep 2024 13:19:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=MIME-Version:Content-Transfer-Encoding:Content-Type :References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; b=MrmEtHCq1yIBeyHcVJAuFFoiW5 vxa0C+0bEfy4Vf8rI0hIphwE2W+YIpjbRG9A4K7ZtiGC2iqS6sK8ciI5uptroX6wiOFz6SR1DIz4q eVX2GqnCH8iwHDK8XfcjcWWqG0RpXlltYSpIF2ftPTtvMmONqnBruq+BNJHzt/uXlloI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; b=EeNHT4JhZuAhUBw8e1GMH5mOuA JL8K338kmVclRcL/Yy7e7Tn0jsupDDqlBOVk7ylbnFCnYjo4VaiaPTi7nBDiIETVYFuGn/l4JaxtY eckUgzPHfrm8eVfrDNlDYrsMle0nNc+KMlkjgkrV4TjWjHgFJpqrjt1cI0K5RjXywcE4=; Received: from mail-oo1-f43.google.com ([209.85.161.43]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1slTRN-0005jh-OL for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Sep 2024 13:19:26 +0000 Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-5dfa315ccf1so3147707eaf.3 for ; Tue, 03 Sep 2024 06:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725369555; x=1725974355; darn=lists.sourceforge.net; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; b=fhRY9JcaCWyiPyGpX33XyZx3E39dfEojgieZNnpxWmNRNhYzGoHq+WCgNq32upIiKb DUOz2y0b/T2o/rmdMyNMtjagq+/IA4FjW2F/1zEUN6cDP3rBz+Dsur1nVGXJ1t8OJhdk upVS58RJ8KPFhTEgDYg+dAhrVOnG8yFlGVXpbIIEIHBlOo1phuhTKi1ofEFBRDbdq/tC nQlObgUBUbNuDqoJDqiXdMIKGMcR/PQ/Zmg8oWk3LKYqSDWOq/3RKKAOpy5tmA+WIPGX zejipUf3lrn4jZlgLWxhL7y3rMcZPljP1kv6j7FtTJ+5QNKho9HTwoMVY/4EvUIC08OD 6vZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725369555; x=1725974355; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; b=EgGyGWZRj2cbezQb+8sYxrnCB/6e69JDNUnd9sUxRVeKJzX0UESRASlYDZdQvpjoBr ZMIgYgCU06RxF/pzVKPAaM9M5GSLgqaGLxp1WkCIwiQvGDNkC3WPw4TFR6qsw3Rygins oco4/6WAOQntIzXx78EKukyJyU9+XSDf8/X5hc/W1obAwSIVENxWgwNn2WN+eRyqO2us fPD9KdWdFbg1DA7qY/4BpiqW2ta0+P715QyNzWfknmPAXmLKWbYoeE6NY+dBJg+e61ej 0L2cQFx68YZrhvvsgmxsGIsqQBVG3MT61uCqYKf6sf/nQq6rDRkwEzxec4vR2hZXECGS rY8g== X-Forwarded-Encrypted: i=1; AJvYcCVlUpDTrjTWxXzOI+bax7vJRT3JNZ//KLm6RFbkIewbnYaow1X3MO0S4Y6+7Gm+51vNfrm6wo/ouTdYmkpUAxi9@lists.sourceforge.net X-Gm-Message-State: AOJu0YysFEmc6l3Jo3GmpriShqLvG1ACTtnRElwT9AWivFyymz/p12R5 H0Gc7TZ3Q1MG4XMwHFDrllYc6PNdmCB7A2CEKTUbK1wU7r5ZALZKRtj332Qe X-Google-Smtp-Source: AGHT+IHmqKB2ApI4jtmnVOIKPHAaEfmCOJEP0+RdE5W02PZplPzBvvvrHQ15gjBnd/lnsJzhYx3fSg== X-Received: by 2002:a05:6358:528a:b0:1b8:15fd:49f6 with SMTP id e5c5f4694b2df-1b815fd4c10mr151831555d.27.1725369554677; Tue, 03 Sep 2024 06:19:14 -0700 (PDT) Received: from [127.0.0.1] ([191.96.241.67]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d22e9be21bsm7983314a12.74.2024.09.03.06.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 06:19:14 -0700 (PDT) Message-ID: From: Julian Sun To: Chao Yu , linux-f2fs-devel@lists.sourceforge.net Date: Tue, 03 Sep 2024 21:19:10 +0800 In-Reply-To: <0f1e5069-7ff0-4d5f-8a3a-3806c8d21487@kernel.org> References: <20240828165425.324845-1-sunjunchao2870@gmail.com> <0f1e5069-7ff0-4d5f-8a3a-3806c8d21487@kernel.org> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-Headers-End: 1slTRN-0005jh-OL Subject: Re: [f2fs-dev] [PATCH v2] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs. X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaegeuk@kernel.org, syzbot+ebea2790904673d7c618@syzkaller.appspotmail.com, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gTW9uLCAyMDI0LTA5LTAyIGF0IDE2OjEzICswODAwLCBDaGFvIFl1IHdyb3RlOgo+IE9uIDIw MjQvOC8yOSAwOjU0LCBKdWxpYW4gU3VuIHdyb3RlOgo+ID4gSGksIGFsbC4KPiA+IAo+ID4gUmVj ZW50bHkgc3l6Ym90IHJlcG9ydGVkIGEgYnVnIGFzIGZvbGxvd2luZzoKPiA+IAo+ID4ga2VybmVs IEJVRyBhdCBmcy9mMmZzL2lub2RlLmM6ODk2IQo+ID4gQ1BVOiAxIFVJRDogMCBQSUQ6IDUyMTcg Q29tbTogc3l6LWV4ZWN1dG9yNjA1IE5vdCB0YWludGVkIDYuMTEuMC0KPiA+IHJjNC1zeXprYWxs ZXItMDAwMzMtZzg3MmNmMjhiOGRmOSAjMAo+ID4gUklQOiAwMDEwOmYyZnNfZXZpY3RfaW5vZGUr MHgxNTk4LzB4MTVjMCBmcy9mMmZzL2lub2RlLmM6ODk2Cj4gPiBDYWxsIFRyYWNlOgo+ID4gwqAg PFRBU0s+Cj4gPiDCoCBldmljdCsweDUzMi8weDk1MCBmcy9pbm9kZS5jOjcwNAo+ID4gwqAgZGlz cG9zZV9saXN0IGZzL2lub2RlLmM6NzQ3IFtpbmxpbmVdCj4gPiDCoCBldmljdF9pbm9kZXMrMHg1 ZjkvMHg2OTAgZnMvaW5vZGUuYzo3OTcKPiA+IMKgIGdlbmVyaWNfc2h1dGRvd25fc3VwZXIrMHg5 ZC8weDJkMCBmcy9zdXBlci5jOjYyNwo+ID4gwqAga2lsbF9ibG9ja19zdXBlcisweDQ0LzB4OTAg ZnMvc3VwZXIuYzoxNjk2Cj4gPiDCoCBraWxsX2YyZnNfc3VwZXIrMHgzNDQvMHg2OTAgZnMvZjJm cy9zdXBlci5jOjQ4OTgKPiA+IMKgIGRlYWN0aXZhdGVfbG9ja2VkX3N1cGVyKzB4YzQvMHgxMzAg ZnMvc3VwZXIuYzo0NzMKPiA+IMKgIGNsZWFudXBfbW50KzB4NDFmLzB4NGIwIGZzL25hbWVzcGFj ZS5jOjEzNzMKPiA+IMKgIHRhc2tfd29ya19ydW4rMHgyNGYvMHgzMTAga2VybmVsL3Rhc2tfd29y ay5jOjIyOAo+ID4gwqAgcHRyYWNlX25vdGlmeSsweDJkMi8weDM4MCBrZXJuZWwvc2lnbmFsLmM6 MjQwMgo+ID4gwqAgcHRyYWNlX3JlcG9ydF9zeXNjYWxsIGluY2x1ZGUvbGludXgvcHRyYWNlLmg6 NDE1IFtpbmxpbmVdCj4gPiDCoCBwdHJhY2VfcmVwb3J0X3N5c2NhbGxfZXhpdCBpbmNsdWRlL2xp bnV4L3B0cmFjZS5oOjQ3NyBbaW5saW5lXQo+ID4gwqAgc3lzY2FsbF9leGl0X3dvcmsrMHhjNi8w eDE5MCBrZXJuZWwvZW50cnkvY29tbW9uLmM6MTczCj4gPiDCoCBzeXNjYWxsX2V4aXRfdG9fdXNl cl9tb2RlX3ByZXBhcmUga2VybmVsL2VudHJ5L2NvbW1vbi5jOjIwMAo+ID4gW2lubGluZV0KPiA+ IMKgIF9fc3lzY2FsbF9leGl0X3RvX3VzZXJfbW9kZV93b3JrIGtlcm5lbC9lbnRyeS9jb21tb24u YzoyMDUKPiA+IFtpbmxpbmVdCj4gPiDCoCBzeXNjYWxsX2V4aXRfdG9fdXNlcl9tb2RlKzB4Mjc5 LzB4MzcwIGtlcm5lbC9lbnRyeS9jb21tb24uYzoyMTgKPiA+IMKgIGRvX3N5c2NhbGxfNjQrMHgx MDAvMHgyMzAgYXJjaC94ODYvZW50cnkvY29tbW9uLmM6ODkKPiA+IMKgIGVudHJ5X1NZU0NBTExf NjRfYWZ0ZXJfaHdmcmFtZSsweDc3LzB4N2YKPiA+IAo+ID4gVGhlIHN5emJvdCBjb25zdHJ1Y3Rl ZCB0aGUgZm9sbG93aW5nIHNjZW5hcmlvOiBjb25jdXJyZW50bHkKPiA+IGNyZWF0aW5nIGRpcmVj dG9yaWVzIGFuZCBzZXR0aW5nIHRoZSBmaWxlIHN5c3RlbSB0byByZWFkLW9ubHkuCj4gPiBJbiB0 aGlzIGNhc2UsIHdoaWxlIGYyZnMgd2FzIG1ha2luZyBkaXIsIHRoZSBmaWxlc3lzdGVtIHN3aXRj aGVkIHRvCj4gPiByZWFkb25seSwgYW5kIHdoZW4gaXQgdHJpZWQgdG8gY2xlYXIgdGhlIGRpcnR5 IGZsYWcsIGl0IHRyaWdnZXJlZAo+ID4gdGhpcwo+ID4gY29kZSBwYXRoOiBmMmZzX21rZGlyKCkt PiBmMmZzX3N5bmNfZnMoKS0+ZjJmc193cml0ZV9jaGVja3BvaW50KCkKPiA+IC0+ZjJmc19yZWFk b25seSgpLiBUaGlzIHJlc3VsdGVkIEZJX0RJUlRZX0lOT0RFIGZsYWcgbm90IGJlaW5nCj4gPiBj bGVhcmVkLAo+ID4gd2hpY2ggZXZlbnR1YWxseSBsZWQgdG8gYSBidWcgYmVpbmcgdHJpZ2dlcmVk IGR1cmluZyB0aGUKPiA+IEZJX0RJUlRZX0lOT0RFCj4gPiBjaGVjayBpbiBmMmZzX2V2aWN0X2lu b2RlKCkuCj4gPiAKPiA+IEluIHRoaXMgY2FzZSwgd2UgY2Fubm90IGRvIGFueXRoaW5nIGZ1cnRo ZXIsIHNvIGlmIGZpbGVzeXN0ZW0gaXMKPiA+IHJlYWRvbmx5LAo+ID4gZG8gbm90IHRyaWdnZXIg dGhlIEJVRy4gSW5zdGVhZCwgY2xlYW4gdXAgcmVzb3VyY2VzIHRvIHRoZSBiZXN0IG9mCj4gPiBv dXIKPiA+IGFiaWxpdHkgdG8gcHJldmVudCB0cmlnZ2VyaW5nIHN1YnNlcXVlbnQgcmVzb3VyY2Ug bGVhayBjaGVja3MuCj4gPiAKPiA+IElmIHRoZXJlIGlzIGFueXRoaW5nIGltcG9ydGFudCBJJ20g bWlzc2luZywgcGxlYXNlIGxldCBtZSBrbm93LAo+ID4gdGhhbmtzLgo+ID4gCj4gPiBSZXBvcnRl ZC1ieTogc3l6Ym90K2ViZWEyNzkwOTA0NjczZDdjNjE4QHN5emthbGxlci5hcHBzcG90bWFpbC5j b20KPiA+IENsb3NlczoKPiA+IGh0dHBzOi8vc3l6a2FsbGVyLmFwcHNwb3QuY29tL2J1Zz9leHRp ZD1lYmVhMjc5MDkwNDY3M2Q3YzYxOAo+ID4gRml4ZXM6IGNhN2Q4MDJhN2Q4ZSAoImYyZnM6IGRl dGVjdCBkaXJ0eSBpbm9kZSBpbiBldmljdF9pbm9kZSIpCj4gPiBDQzogc3RhYmxlQHZnZXIua2Vy bmVsLm9yZwo+ID4gU2lnbmVkLW9mZi1ieTogSnVsaWFuIFN1biA8c3VuanVuY2hhbzI4NzBAZ21h aWwuY29tPgo+ID4gLS0tCj4gPiDCoCBmcy9mMmZzL2lub2RlLmMgfCAzICsrLQo+ID4gwqAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZm IC0tZ2l0IGEvZnMvZjJmcy9pbm9kZS5jIGIvZnMvZjJmcy9pbm9kZS5jCj4gPiBpbmRleCBhZWY1 NzE3MjAxNGYuLmViZjgyNWRiYTBhNSAxMDA2NDQKPiA+IC0tLSBhL2ZzL2YyZnMvaW5vZGUuYwo+ ID4gKysrIGIvZnMvZjJmcy9pbm9kZS5jCj4gPiBAQCAtODkyLDcgKzg5Miw4IEBAIHZvaWQgZjJm c19ldmljdF9pbm9kZShzdHJ1Y3QgaW5vZGUgKmlub2RlKQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYXRvbWljX3JlYWQoJmZpLT5pX2NvbXByX2Js b2NrcykpOwo+ID4gwqAgCj4gPiDCoMKgwqDCoMKgwqDCoMKgaWYgKGxpa2VseSghZjJmc19jcF9l cnJvcihzYmkpICYmCj4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAhaXNfc2JpX2ZsYWdfc2V0KHNiaSwKPiA+IFNCSV9DUF9E SVNBQkxFRCkpKQo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIWlzX3NiaV9mbGFnX3NldChzYmksCj4gPiBTQklfQ1BfRElT QUJMRUQpKSAmJgo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIWYyZnNfcmVhZG9ubHkoc2JpLT5zYikpCj4gCj4gSXMgaXQg ZmluZSB0byBkcm9wIHRoaXMgZGlydHkgaW5vZGU/IFNpbmNlIG9uY2UgaXQgcmVtb3VudHMgZjJm cyBhcwo+IHJ3IG9uZSwKPiBwcmV2aW91cyB1cGRhdGVzIG9uIHN1Y2ggaW5vZGUgbWF5IGJlIGxv c3Q/IE9yIGFtIEkgbWlzc2luZwo+IHNvbWV0aGluZz8KSGksIENoYW8uCgpJIGJlbGlldmUgdGhl IGlzc3VlIHlvdSBwb2ludGVkIG91dCBnb2VzIGJleW9uZCB0aGUgc2NvcGUgb2YgdGhlCnByb2Js ZW0gcmVwb3J0ZWQgYnkgc3l6Ym90LCBhcyBJIGhhdmUgc2VlbiB0aGlzIGlzc3VlIGluIHNvbWUg ZXhpc3RpbmcKY29kZSBhcyB3ZWxsLCBzdWNoIGFzIGluIHRoZSBoYW5kbGluZyBvZiByZWFkLW9u bHkgZmlsZSBzeXN0ZW1zIGluCmYyZnNfbWFya19pbm9kZV9kaXJ0eV9zeW5jKCksIGYyZnNfd3Jp dGVfY2hlY2twb2ludCgpLApmMmZzX2RvX3N5bmNfZmlsZSgpLCBldGMuCgpJZiB5b3UgZG8gYmVs aWV2ZSB0aGUgcHJvYmxlbSBuZWVkcyB0byBiZSBmaXhlZCwgd2UgY2FuIGRpc2N1c3MgaXQKZnVy dGhlciwgYnV0IGl0IHNob3VsZCBiZSBhZGRyZXNzZWQgaW4gYSBzZXBhcmF0ZSBwYXRjaC4KCklm IHRoZXJlIGlzIGFueXRoaW5nIGltcG9ydGFudCBJJ20gbWlzc2luZywgcGxlYXNlIGxldCBtZSBr bm93LCB0aGFua3MuCj4gCj4gVGhhbmtzLAo+IAo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqBmMmZzX2J1Z19vbihzYmksIGlzX2lub2RlX2ZsYWdfc2V0KGlub2RlLAo+ID4gRklf RElSVFlfSU5PREUpKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqBlbHNlCj4gPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGYyZnNfaW5vZGVfc3luY2VkKGlub2RlKTsKPiAKClRoYW5rcywK LS0gCkp1bGlhbiBTdW4gPHN1bmp1bmNoYW8yODcwQGdtYWlsLmNvbT4KCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRldmVsIG1haWxp bmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xp c3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311AB188010 for ; Tue, 3 Sep 2024 13:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725369557; cv=none; b=eJdr1YnGYHXsDqAbVfkv6EtPNUxL0P2uGsV+vdTqRsaI6vnDV0RvrBDEAhhz+C0cQHLD4ZPVX6Sy20croAyyP8VWGL5r0AftooV+WU1e/c4Nnh/u+U1nZDDlUKp3Um1VtqMH8MnbVBpe6uzslsehBoSsUq2AsRiDsdb+l/+0zl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725369557; c=relaxed/simple; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MWl41iNjuqz+5GIw6rNJXMbC1fkM0B2NUct37d04PqkuZNsZe5Zf26xrbIyegRF+LR+NZD/Smch/gmJYZVB1J8wYhwn0kKSYPh+SOA/TXMhFOJxw/xSX5t4h9inEzNqdY4aAW70KyVU328+cKYyR/GxPaoLjBhDcLlUQqAE3a1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l7mA03Vi; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l7mA03Vi" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5dca9cc71b2so3190197eaf.2 for ; Tue, 03 Sep 2024 06:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725369555; x=1725974355; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; b=l7mA03ViqAlbhlBqNQNEFc3UZZf9bYfqGdrxi/r0IlFlGa0jBY0Q7ZmGFPEC4Wg8o3 8BEQjV3OpkY6sr/whqEfVRyxj1ovu1jvn9OOKp9PqfKNSCZvQA3k63vcjWefB3aaT7Wn a4ws0or7N66V+rcfu06RRUhBQ+DDE/IJGYkPlPP3Blx5xoED1syAuVWZNC6VMkZGAaiW rgP8NrDx8Mrfql9LMgqaH6e91BRWQh1Z2eP220kUducL/4TNIt5BSFJrdf/VHXP85UYR 5KMcmZEQJDXwqAxhMW60K50/4KPhMjHmAdk05tV6sn/JIEgkZmumWWWYHa/Nqp11DMi2 sPgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725369555; x=1725974355; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nXLxdtE8dKy73TUb2uzwOpBR3I6kFdQEuWkttJKFH4c=; b=rnWPKax/L93Q43RiSkP4pynAUelhyjW1tKN3cOx/ECU7qzVcWbPNZ7RpPWd40AYyZ7 lBHalJy9kuJNuU8OJ2eny6o3Eo3N0s4kn/7THgrT/mWi+TZbrU1ZjmVNs7uR8K1207Vm yYfYCtJdIqdlWT56Jf6763i3NN66kHaCbAUYw2Vdjjlc5hUC+aHUE03gXbRI7H+7Qccx 7VCzR1WBZQphkD6yprL42nPq3kTMlcAciqX+fqHekZjI6vchqVD9fBxAgvSncuVgSXyh DVfV60SWhs2/W/YNLHrLDmvtgiKMdpjXSQO8+7tfv9TUfBYLkP7r/YD6bAgqfj4TIjlL H+oA== X-Forwarded-Encrypted: i=1; AJvYcCXN7Lc3tvqApXdGq++NVvNMAciCoNhFaewJc4Urmf0+nkmWkBJ78JoWn679St2Ba5gWEw1//Kg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz54/WjUUYbhNYrg/b/nHM441W4DOLpkJAoPBfytU7RlDpsGbZu fYq1WxxyoMwBXFwIV/x7t0gTbOzPFyUoiihLlBuqIuoszexAobRF X-Google-Smtp-Source: AGHT+IHmqKB2ApI4jtmnVOIKPHAaEfmCOJEP0+RdE5W02PZplPzBvvvrHQ15gjBnd/lnsJzhYx3fSg== X-Received: by 2002:a05:6358:528a:b0:1b8:15fd:49f6 with SMTP id e5c5f4694b2df-1b815fd4c10mr151831555d.27.1725369554677; Tue, 03 Sep 2024 06:19:14 -0700 (PDT) Received: from [127.0.0.1] ([191.96.241.67]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d22e9be21bsm7983314a12.74.2024.09.03.06.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 06:19:14 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs. From: Julian Sun To: Chao Yu , linux-f2fs-devel@lists.sourceforge.net Cc: jaegeuk@kernel.org, syzbot+ebea2790904673d7c618@syzkaller.appspotmail.com, stable@vger.kernel.org Date: Tue, 03 Sep 2024 21:19:10 +0800 In-Reply-To: <0f1e5069-7ff0-4d5f-8a3a-3806c8d21487@kernel.org> References: <20240828165425.324845-1-sunjunchao2870@gmail.com> <0f1e5069-7ff0-4d5f-8a3a-3806c8d21487@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-09-02 at 16:13 +0800, Chao Yu wrote: > On 2024/8/29 0:54, Julian Sun wrote: > > Hi, all. > >=20 > > Recently syzbot reported a bug as following: > >=20 > > kernel BUG at fs/f2fs/inode.c:896! > > CPU: 1 UID: 0 PID: 5217 Comm: syz-executor605 Not tainted 6.11.0- > > rc4-syzkaller-00033-g872cf28b8df9 #0 > > RIP: 0010:f2fs_evict_inode+0x1598/0x15c0 fs/f2fs/inode.c:896 > > Call Trace: > > =C2=A0 > > =C2=A0 evict+0x532/0x950 fs/inode.c:704 > > =C2=A0 dispose_list fs/inode.c:747 [inline] > > =C2=A0 evict_inodes+0x5f9/0x690 fs/inode.c:797 > > =C2=A0 generic_shutdown_super+0x9d/0x2d0 fs/super.c:627 > > =C2=A0 kill_block_super+0x44/0x90 fs/super.c:1696 > > =C2=A0 kill_f2fs_super+0x344/0x690 fs/f2fs/super.c:4898 > > =C2=A0 deactivate_locked_super+0xc4/0x130 fs/super.c:473 > > =C2=A0 cleanup_mnt+0x41f/0x4b0 fs/namespace.c:1373 > > =C2=A0 task_work_run+0x24f/0x310 kernel/task_work.c:228 > > =C2=A0 ptrace_notify+0x2d2/0x380 kernel/signal.c:2402 > > =C2=A0 ptrace_report_syscall include/linux/ptrace.h:415 [inline] > > =C2=A0 ptrace_report_syscall_exit include/linux/ptrace.h:477 [inline] > > =C2=A0 syscall_exit_work+0xc6/0x190 kernel/entry/common.c:173 > > =C2=A0 syscall_exit_to_user_mode_prepare kernel/entry/common.c:200 > > [inline] > > =C2=A0 __syscall_exit_to_user_mode_work kernel/entry/common.c:205 > > [inline] > > =C2=A0 syscall_exit_to_user_mode+0x279/0x370 kernel/entry/common.c:218 > > =C2=A0 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 > > =C2=A0 entry_SYSCALL_64_after_hwframe+0x77/0x7f > >=20 > > The syzbot constructed the following scenario: concurrently > > creating directories and setting the file system to read-only. > > In this case, while f2fs was making dir, the filesystem switched to > > readonly, and when it tried to clear the dirty flag, it triggered > > this > > code path: f2fs_mkdir()-> f2fs_sync_fs()->f2fs_write_checkpoint() > > ->f2fs_readonly(). This resulted FI_DIRTY_INODE flag not being > > cleared, > > which eventually led to a bug being triggered during the > > FI_DIRTY_INODE > > check in f2fs_evict_inode(). > >=20 > > In this case, we cannot do anything further, so if filesystem is > > readonly, > > do not trigger the BUG. Instead, clean up resources to the best of > > our > > ability to prevent triggering subsequent resource leak checks. > >=20 > > If there is anything important I'm missing, please let me know, > > thanks. > >=20 > > Reported-by: syzbot+ebea2790904673d7c618@syzkaller.appspotmail.com > > Closes: > > https://syzkaller.appspot.com/bug?extid=3Debea2790904673d7c618 > > Fixes: ca7d802a7d8e ("f2fs: detect dirty inode in evict_inode") > > CC: stable@vger.kernel.org > > Signed-off-by: Julian Sun > > --- > > =C2=A0 fs/f2fs/inode.c | 3 ++- > > =C2=A0 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > index aef57172014f..ebf825dba0a5 100644 > > --- a/fs/f2fs/inode.c > > +++ b/fs/f2fs/inode.c > > @@ -892,7 +892,8 @@ void f2fs_evict_inode(struct inode *inode) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= atomic_read(&fi->i_compr_blocks)); > > =C2=A0=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (likely(!f2fs_cp_err= or(sbi) && > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0!is_sbi_flag_set(sbi, > > SBI_CP_DISABLED))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0!is_sbi_flag_set(sbi, > > SBI_CP_DISABLED)) && > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0!f2fs_readonly(sbi->sb)) >=20 > Is it fine to drop this dirty inode? Since once it remounts f2fs as > rw one, > previous updates on such inode may be lost? Or am I missing > something? Hi, Chao. I believe the issue you pointed out goes beyond the scope of the problem reported by syzbot, as I have seen this issue in some existing code as well, such as in the handling of read-only file systems in f2fs_mark_inode_dirty_sync(), f2fs_write_checkpoint(), f2fs_do_sync_file(), etc. If you do believe the problem needs to be fixed, we can discuss it further, but it should be addressed in a separate patch. If there is anything important I'm missing, please let me know, thanks. >=20 > Thanks, >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0f2fs_bug_on(sbi, is_inode_flag_set(inode, > > FI_DIRTY_INODE)); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0f2fs_inode_synced(inode); >=20 Thanks, --=20 Julian Sun