Re: [PATCH] Input: atkbd - skip deactivate for Lenovo IdeaPad Slim 3 14IWC11

[Hans de Goede <hansg@kernel.org>]

Hi,

On 11-Sep-26 8:23 PM, Iustin Ivan wrote:
> The internal keyboard on the Lenovo IdeaPad Slim 3 14IWC11 (83RQ) does
> not work after boot. The keyboard ACKs every command during probe,
> including ATKBD_CMD_ENABLE, but never sends any scancodes afterwards.
> Booting with 'i8042.dumbkbd=1' makes it work at the cost of the
> CapsLock LED. Adding the atkbd_deactivate_fixup quirk fixes the
> keyboard and the LED natively.
> 
> DMI: LENOVO 83RQ/LNVNB161216, BIOS U2CN19WW 03/30/2026
> 
> Fixes: 9cf6e24c9fbf ("Input: atkbd - do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID")
> Cc: stable@vger.kernel.org
> Signed-off-by: Iustin Ivan <iustinivan2002@gmail.com>

I'm starting to wonder if we should not just make this behavior the default.

IIRC the whole deactivate thing was added as a workaround for multi-byte scancodes
getting split-up during suspend/resume. I wonder if we can come-up with some
better fix for that ?

Regards,

Hans







> ---
>  drivers/input/keyboard/atkbd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index b9ad2381f885..923f77808381 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1938,6 +1938,14 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
>  		},
>  		.callback = atkbd_deactivate_fixup,
>  	},
> +	{
> +		/* Lenovo IdeaPad Slim 3 14IWC11 (83RQ) */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "83RQ"),
> +		},
> +		.callback = atkbd_deactivate_fixup,
> +	},
>  	{
>  		/* Xiaomi Book Pro 14 (TM2424) */
>  		.matches = {