From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782EEC2B9F8 for ; Mon, 24 May 2021 13:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56B1F613B0 for ; Mon, 24 May 2021 13:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232536AbhEXN3T (ORCPT ); Mon, 24 May 2021 09:29:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232401AbhEXN3S (ORCPT ); Mon, 24 May 2021 09:29:18 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A087C061574; Mon, 24 May 2021 06:27:49 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id w33so32719052lfu.7; Mon, 24 May 2021 06:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WlD4zojrALQJ3lMjLIav5M7SKi5ELnimDryncsQ/eew=; b=n+janOnwDY0e+M/oqh/h5lp+KO3spsFId0m8fYDlrunNShBYLSDx99+oihuZFnQrKb p+yan76rURm+le3301pH9UEAHBSF0dey5vrlm3Gz229XQARguK7u66/P97HssAFcT/kL Q49eHUPqimmyUiQr6+ylw0QD1G4lGXs8AkPEBnBLotdqPQBDLtjMzykFtPq2T5Ws7ji4 T3939zY0oAjChf4BxQA6FJtqXJ9v7+VEwVKHVz5rrYoQHKzTxSqRSuy7obS/A1EYKgEC QvRJpo3uM/ObkgZRe1RsNhDvL4Ba93MVrtleRksDndDfVqsZFcD2SfNhkyuXJhMWVZCc NIAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WlD4zojrALQJ3lMjLIav5M7SKi5ELnimDryncsQ/eew=; b=YWLavoJwVbi0jG5hVHZqxcngWJYP+hX2eqIXpyiDnTR8VdIAVo7vu37X1AL/D2fhsS oi3spZEjqCLUJmfoU63lc9d7U9T0QNfHOAK1s3QOJroyEprfXXGDTgQglzDSk2DBHDIW lezo8XGmFDYLQHeWkyIJalsRO0LpkBLY/qBrveXI5o0OnTG0exr/uCCBfHh8ODXILFWc 4hRUV5YwJPYV3ut3TMi/rrBUwAAfGYyQeT3e08fzpQUeOWN0kQ0If1488+7HmK0J3FI0 3Mlu9Bc8/ZuLuxexFmborJqmWH2N5bjG3SvpQ19a2aB4iw/zHU3T11quUp9PU4/qgfl8 l7IA== X-Gm-Message-State: AOAM533XgxDK1mCdlvbIsGJ+g7ynRcITV8/6Rek/LPKNaL3tzJxZuYV3 yr2ZFzwOEoHvTm95w4N/emg= X-Google-Smtp-Source: ABdhPJx21C2ia2YRPJ+KM6HGkOOUDyuFOa4OvvZsYw21/Dc6XaNds85PS5+Mk5I/jXr0R6uagP0uBw== X-Received: by 2002:a05:6512:3dac:: with SMTP id k44mr10709502lfv.256.1621862867427; Mon, 24 May 2021 06:27:47 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-110.dynamic.spd-mgts.ru. [109.252.193.110]) by smtp.googlemail.com with ESMTPSA id a25sm1763802ljp.11.2021.05.24.06.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 06:27:47 -0700 (PDT) Subject: Re: [PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe() To: Wei Yongjun , Mauro Carvalho Chehab , Mauro Carvalho Chehab , Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Philipp Zabel , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210524133550.2363884-1-weiyongjun1@huawei.com> From: Dmitry Osipenko Message-ID: Date: Mon, 24 May 2021 16:27:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210524133550.2363884-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org 24.05.2021 16:35, Wei Yongjun пишет: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/staging/media/tegra-vde/vde.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c > index e025b69776f2..321d14ba2e56 100644 > --- a/drivers/staging/media/tegra-vde/vde.c > +++ b/drivers/staging/media/tegra-vde/vde.c > @@ -1071,7 +1071,8 @@ static int tegra_vde_probe(struct platform_device *pdev) > * power-cycle it in order to put hardware into a predictable lower > * power state. > */ > - if (pm_runtime_resume_and_get(dev) < 0) > + err = pm_runtime_resume_and_get(dev); > + if (err < 0) > goto err_pm_runtime; > > pm_runtime_put(dev); > pm_runtime_resume_and_get() doesn't return positive values, the previous variant was okay. You should also version your patches and add changelog. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE85C04FF3 for ; Mon, 24 May 2021 13:27:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB76F61248 for ; Mon, 24 May 2021 13:27:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB76F61248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76EC86E578; Mon, 24 May 2021 13:27:50 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id E85F86E581 for ; Mon, 24 May 2021 13:27:48 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id r5so40644692lfr.5 for ; Mon, 24 May 2021 06:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WlD4zojrALQJ3lMjLIav5M7SKi5ELnimDryncsQ/eew=; b=n+janOnwDY0e+M/oqh/h5lp+KO3spsFId0m8fYDlrunNShBYLSDx99+oihuZFnQrKb p+yan76rURm+le3301pH9UEAHBSF0dey5vrlm3Gz229XQARguK7u66/P97HssAFcT/kL Q49eHUPqimmyUiQr6+ylw0QD1G4lGXs8AkPEBnBLotdqPQBDLtjMzykFtPq2T5Ws7ji4 T3939zY0oAjChf4BxQA6FJtqXJ9v7+VEwVKHVz5rrYoQHKzTxSqRSuy7obS/A1EYKgEC QvRJpo3uM/ObkgZRe1RsNhDvL4Ba93MVrtleRksDndDfVqsZFcD2SfNhkyuXJhMWVZCc NIAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WlD4zojrALQJ3lMjLIav5M7SKi5ELnimDryncsQ/eew=; b=uByEyeNuwBQ1JfIAXQaiyElWNAyH7Q9PySAIGRNXEBU1pZpQ2gpwfyRViV4ReZBrns xFU/aQiDw+rrP1Z4m7zfdlg+HiFzu/oafEPTQnu08BM+jeTl20xsn5tVrJiQYZp2J+kK Hofef0x7yBpXs1nk4fOJr2R6/bqR77ceJoKgMUAKdAlAHnytrEepWekj43VUevqSnrFM AN9ExbCAscqAQbRlNWRQHZBLJtSNXTqKI67TNOrqxgMKHKTdPOLZrQ1sBP30fG3xrAQq XRYd/cmwn91LOkUfBwc/c/nhLBnGqpgyC4A0YT3O/0B6teXtFHDGGCHKCwPso7TwWf7S k2Fw== X-Gm-Message-State: AOAM530AT08THUtb2XVYBW+neH6qEi45//NRHchOHRJ4L6pB3wjzPdim V39r4o/Ejpf50UiXILzc5sw= X-Google-Smtp-Source: ABdhPJx21C2ia2YRPJ+KM6HGkOOUDyuFOa4OvvZsYw21/Dc6XaNds85PS5+Mk5I/jXr0R6uagP0uBw== X-Received: by 2002:a05:6512:3dac:: with SMTP id k44mr10709502lfv.256.1621862867427; Mon, 24 May 2021 06:27:47 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-110.dynamic.spd-mgts.ru. [109.252.193.110]) by smtp.googlemail.com with ESMTPSA id a25sm1763802ljp.11.2021.05.24.06.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 06:27:47 -0700 (PDT) Subject: Re: [PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe() To: Wei Yongjun , Mauro Carvalho Chehab , Mauro Carvalho Chehab , Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Philipp Zabel , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20210524133550.2363884-1-weiyongjun1@huawei.com> From: Dmitry Osipenko Message-ID: Date: Mon, 24 May 2021 16:27:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210524133550.2363884-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Hulk Robot , linux-tegra@vger.kernel.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 24.05.2021 16:35, Wei Yongjun пишет: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/staging/media/tegra-vde/vde.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c > index e025b69776f2..321d14ba2e56 100644 > --- a/drivers/staging/media/tegra-vde/vde.c > +++ b/drivers/staging/media/tegra-vde/vde.c > @@ -1071,7 +1071,8 @@ static int tegra_vde_probe(struct platform_device *pdev) > * power-cycle it in order to put hardware into a predictable lower > * power state. > */ > - if (pm_runtime_resume_and_get(dev) < 0) > + err = pm_runtime_resume_and_get(dev); > + if (err < 0) > goto err_pm_runtime; > > pm_runtime_put(dev); > pm_runtime_resume_and_get() doesn't return positive values, the previous variant was okay. You should also version your patches and add changelog.