All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Geert Uytterhoeven' <geert@linux-m68k.org>,
	Joe Perches <joe@perches.com>
Cc: Bernard Metzler <bmt@zurich.ibm.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse
Date: Tue, 27 Aug 2019 14:17:40 +0000	[thread overview]
Message-ID: <dbc03b4ac1ef4ba2a807409676cf8066@AcuMS.aculab.com> (raw)
In-Reply-To: <CAMuHMdVh8dwd=77mHTqG80_D8DK+EtVGewRUJuaJzK1qRYrB+w@mail.gmail.com>

From: Geert Uytterhoeven
> Sent: 19 August 2019 18:15
...
> > I think a cast to unsigned long is rather more common.
> >
> > uintptr_t is used ~1300 times in the kernel.
> > I believe a cast to unsigned long is much more common.
> 
> That is true, as uintptr_t was introduced in C99.
> Similarly, unsigned long was used before size_t became common.
> 
> However, nowadays size_t and uintptr_t are preferred.

Isn't uintptr_t defined by the same standard as uint32_t?
If the former is allowed so should the latter.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  parent reply	other threads:[~2019-08-27 14:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 10:05 [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse Geert Uytterhoeven
2019-08-19 12:24 ` Jason Gunthorpe
2019-08-19 13:36   ` Bernard Metzler
2019-08-19 13:52     ` Jason Gunthorpe
2019-08-19 14:15       ` Bernard Metzler
2019-08-19 14:18         ` Jason Gunthorpe
2019-08-19 14:52           ` Bernard Metzler
2019-08-19 15:07             ` Jason Gunthorpe
2019-08-19 15:54               ` Bernard Metzler
2019-08-19 16:05                 ` Jason Gunthorpe
2019-08-19 16:29                   ` Bernard Metzler
2019-08-19 16:35                     ` Jason Gunthorpe
2019-08-19 17:39                       ` Bernard Metzler
2019-08-19 18:00                         ` Jason Gunthorpe
2019-08-19 21:40                           ` Bernard Metzler
2019-08-19 22:22                             ` Jason Gunthorpe
2019-08-19 16:56 ` Joe Perches
2019-08-19 17:14   ` Geert Uytterhoeven
2019-08-19 17:26     ` Bernard Metzler
2019-08-27 14:17     ` David Laight [this message]
2019-08-27 17:29       ` Geert Uytterhoeven
2019-08-27 17:46         ` Al Viro
2019-08-27 17:59           ` Geert Uytterhoeven
2019-08-27 18:33             ` Joe Perches
2019-08-28  8:27               ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbc03b4ac1ef4ba2a807409676cf8066@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=bmt@zurich.ibm.com \
    --cc=dledford@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=jgg@ziepe.ca \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.