Re: [PATCH v4 2/2] platform/x86: Move Lenovo files into lenovo subdir

["Mark Pearson" <mpearson-lenovo@squebb.ca>]

On Wed, Jun 11, 2025, at 11:07 AM, Andy Shevchenko wrote:
> On Wed, Jun 11, 2025 at 06:01:36PM +0300, Ilpo Järvinen wrote:
>> On Tue, 10 Jun 2025, Mark Pearson wrote:
>> > On Tue, Jun 10, 2025, at 4:27 PM, Andy Shevchenko wrote:
>> > > On Tue, Jun 10, 2025 at 03:28:25PM -0400, Mark Pearson wrote:
>> > >> Create lenovo subdirectory for holding Lenovo specific drivers.
>> > >
>> > > Assuming Kconfig entries have mostly been copied'n'pasted, the rest LGTM,
>> > 
>> > Yes - no changes from what they were previously.
>> 
>> Indeed, no changes, too bad that the addition "depends on DMI" was missed 
>> because of that ;-). I've fixed this for you to not delay this patch 
>> further.
>
> Oh, thanks!
>
Ooops - sorry! That was bad :( Thanks for fixing.

>> A diff-of-pre/post magic trick helps to validate while preparing and 
>> review move changes like this:
>> 
>> diff -u <(grep '^[-]' patch.patch | cut -b 2- | sort) <(grep '^[+]' patch.patch | cut -b 2- | sort)
>
> AFAIK Git can do something like this for you (patch to the patch) or `b4`.
> Never used personally, but interested to try if somebody tells me what to
> do :-)
>
>> The sorting is not always needed if no core reordering is done in the 
>> patch but regardless of sorting or not, the unexpected differences are 
>> usually pretty easy to spot from the output of that command. It's how I 
>> found out the lack of depends on DMI on the post side and have found 
>> plenty of similar issue when changes are rebased/reordered in a series 
>> that does contain a move change.
>> 
>> While applying this, I realized I'd taken Jelle's ideapad patch which 
>> resulted in this move patch not applying cleanly, so I ended up moving 
>> Jelle's patch after this change to make things easier for me.
>> 

Thanks - hopefully this doesn't cause you headaches for the rest of the window.

Mark