From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E83FAC433ED for ; Wed, 19 May 2021 07:23:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6236460725 for ; Wed, 19 May 2021 07:23:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6236460725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4SVYKQ+2Wxmk1W28Yti45/CaxBvX+vBoCKHYmIh4/nM=; b=GiQ38QYAVFCdjO6rGUBHl8eXk jLgb2P+leaW/l9oxIKRJkL/WHC6y4yw8IHXZwaf8e+OwDFfnIStXIXWKc4fKaQ2Ia7TWs7xYovrQK pRaNkClD+5Vf8KMBelxD6Iq2TaC7243Bq10X0mHJAfx+U4hA1VajMONaywF0x3rqIwWNW6hhi9yqW 3U24eFYpRb9d0eSGuNNFMma08vG24PP/YJDdwa/qCi8VdBPQyo+q+ZLRT+p80Zih/HLY209HhSb5F 00eJS08Mym85vdwZCL4ymlBag5HIxzTJGOQl7Uw2N75VM8tfaY4sQcwQFjnmmWTQ/66Zpi6v0uLrq TX1/ZgDVg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljGYO-0039a9-CF; Wed, 19 May 2021 07:23:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljGYL-0039ZH-KB for ath11k@desiato.infradead.org; Wed, 19 May 2021 07:23:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:References:In-Reply-To: Subject:Cc:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=Xi6rm+02wfE8iimkDrJVtwRuysvJH7sJ44vjdfKzLeY=; b=H+Sl+dNhjW0zxrKA9dZlytKLvY wYYA5K0lHD4gLJq16YfVswwzog1bMshG977POLYC7FEJnoUx4sig/a0/rInhb+j7DHp89KrsTgLHU smXKjNSP6FZxb4kqZWstbNKfG2S5tIAaYqeeAjy3yJ6Xx9ciE1d7kj9rubHyDKGZGwqXMjAcyJhpb 7F8t2SZiT9XQaGuure1cnky68dGcTzf0MN1zKzdcTB5WVvNnP85GAhoC80JPhvDsFeZsCVniojcPp xZ/LilSs0tpz0GRDtv+MFkgDwquP50el5edSjSEuwctrX8iXAI894yzrWwkDZsyNlyH31GgK/ydG1 4rOyuyyw==; Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljGYE-00FDUE-HN for ath11k@lists.infradead.org; Wed, 19 May 2021 07:23:36 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621409014; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Xi6rm+02wfE8iimkDrJVtwRuysvJH7sJ44vjdfKzLeY=; b=SKpioW/E9IRiDbuRfRL+rLBdQ6Zy2jMI8/QF7A7mEWmnNarBLAnqqvURKfK5pilDCWCUPyOB JawgMKMEYs+MgxeLZVkZdj0Y0ufsMtMYuYT5MM3fb4+c0PjxGTRS267B9yHm08t8MaEN/x9B j3M5AXEOBYtlSOPzWNLGX3vGfO0= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60a4bcdd2bff04e53be67923 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 19 May 2021 07:23:09 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 57441C433F1; Wed, 19 May 2021 07:23:09 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id DDCC9C4338A; Wed, 19 May 2021 07:23:08 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 19 May 2021 15:23:08 +0800 From: Wen Gong To: Shay Bar Cc: Johannes Berg , linux-wireless@vger.kernel.org, aviad.brikman@celeno.com, eliav.farber@celeno.com, linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH] wireless: fix wrong 160/80+80 MHz setting In-Reply-To: <20200826143139.25976-1-shay.bar@celeno.com> References: <20200826143139.25976-1-shay.bar@celeno.com> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_002334_989926_5C7817BB X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wOC0yNiAyMjozMSwgU2hheSBCYXIgd3JvdGU6Cj4gRml4IGNmZzgwMjExX2NoYW5k ZWZfdXNhYmxlKCk6Cj4gY29uc2lkZXIgSUVFRTgwMjExX1ZIVF9DQVBfRVhUX05TU19CVyB3aGVu IHZlcmlmeWluZyAxNjAvODArODAgTUh6Lgo+IAo+IEJhc2VkIG9uOgo+ICJUYWJsZSA5LTI3MiDi gJQgU2V0dGluZyBvZiB0aGUgU3VwcG9ydGVkIENoYW5uZWwgV2lkdGggU2V0IHN1YmZpZWxkIGFu ZAo+IEV4dGVuZGVkIE5TUyBCVwo+IFN1cHBvcnQgc3ViZmllbGQgYXQgYSBTVEEgdHJhbnNtaXR0 aW5nIHRoZSBWSFQgQ2FwYWJpbGl0aWVzIEluZm9ybWF0aW9uIAo+IGZpZWxkIgo+IEZyb20gIkRy YWZ0IFA4MDIuMTFSRVZtZF9EMy4wLnBkZiIKPiAKPiBTaWduZWQtb2ZmLWJ5OiBBdmlhZCBCcmlr bWFuIDxhdmlhZC5icmlrbWFuQGNlbGVuby5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2hheSBCYXIg PHNoYXkuYmFyQGNlbGVuby5jb20+Cj4gLS0tCj4gIG5ldC93aXJlbGVzcy9jaGFuLmMgfCAxNSAr KysrKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL25ldC93aXJlbGVzcy9jaGFuLmMgYi9uZXQvd2ly ZWxlc3MvY2hhbi5jCj4gaW5kZXggOTBmMGY4MmNkOWNhLi5hNTFkMTFkM2JlMzMgMTAwNjQ0Cj4g LS0tIGEvbmV0L3dpcmVsZXNzL2NoYW4uYwo+ICsrKyBiL25ldC93aXJlbGVzcy9jaGFuLmMKPiBA QCAtOTEyLDYgKzkxMiw3IEBAIGJvb2wgY2ZnODAyMTFfY2hhbmRlZl91c2FibGUoc3RydWN0IHdp cGh5ICp3aXBoeSwKPiAgICAgICAgIHN0cnVjdCBpZWVlODAyMTFfc3RhX3ZodF9jYXAgKnZodF9j YXA7Cj4gICAgICAgICBzdHJ1Y3QgaWVlZTgwMjExX2VkbWcgKmVkbWdfY2FwOwo+ICAgICAgICAg dTMyIHdpZHRoLCBjb250cm9sX2ZyZXEsIGNhcDsKPiArICAgICAgIGJvb2wgc3VwcG9ydF84MF84 MCA9IGZhbHNlOwo+IAo+ICAgICAgICAgaWYgKFdBUk5fT04oIWNmZzgwMjExX2NoYW5kZWZfdmFs aWQoY2hhbmRlZikpKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gQEAgLTk3OSw5 ICs5ODAsMTYgQEAgYm9vbCBjZmc4MDIxMV9jaGFuZGVmX3VzYWJsZShzdHJ1Y3Qgd2lwaHkgKndp cGh5LAo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiAgICAgICAgICAg ICAgICAgYnJlYWs7Cj4gICAgICAgICBjYXNlIE5MODAyMTFfQ0hBTl9XSURUSF84MFA4MDoKPiAt ICAgICAgICAgICAgICAgY2FwID0gdmh0X2NhcC0+Y2FwICYgCj4gSUVFRTgwMjExX1ZIVF9DQVBf U1VQUF9DSEFOX1dJRFRIX01BU0s7Cj4gKyAgICAgICAgICAgICAgIGNhcCA9IHZodF9jYXAtPmNh cDsKPiArICAgICAgICAgICAgICAgc3VwcG9ydF84MF84MCA9Cj4gKyAgICAgICAgICAgICAgICAg ICAgICAgKChjYXAgJgo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgCj4gSUVFRTgwMjExX1ZI VF9DQVBfU1VQUF9DSEFOX1dJRFRIXzE2MF84MFBMVVM4ME1IWikgfHwKPiArICAgICAgICAgICAg ICAgICAgICAgICAoY2FwICYgSUVFRTgwMjExX1ZIVF9DQVBfU1VQUF9DSEFOX1dJRFRIXzE2ME1I WiAKPiAmJgo+ICsgICAgICAgICAgICAgICAgICAgICAgICBjYXAgJiBJRUVFODAyMTFfVkhUX0NB UF9FWFRfTlNTX0JXX01BU0spIHx8Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgKChjYXAgJiBJ RUVFODAyMTFfVkhUX0NBUF9FWFRfTlNTX0JXX01BU0spID4+Cj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgSUVFRTgwMjExX1ZIVF9DQVBfRVhUX05TU19CV19TSElGVCAKPiA+ IDEpKTsKPiAgICAgICAgICAgICAgICAgaWYgKGNoYW5kZWYtPmNoYW4tPmJhbmQgIT0gTkw4MDIx MV9CQU5EXzZHSFogJiYKPiAtICAgICAgICAgICAgICAgICAgIGNhcCAhPSAKPiBJRUVFODAyMTFf VkhUX0NBUF9TVVBQX0NIQU5fV0lEVEhfMTYwXzgwUExVUzgwTUhaKQo+ICsgICAgICAgICAgICAg ICAgICAgIXN1cHBvcnRfODBfODApCj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwo+ICAgICAgICAgICAgICAgICAvKiBmYWxsIHRocm91Z2ggKi8KPiAgICAgICAgIGNhc2Ug Tkw4MDIxMV9DSEFOX1dJRFRIXzgwOgo+IEBAIC0xMDAxLDcgKzEwMDksOCBAQCBib29sIGNmZzgw MjExX2NoYW5kZWZfdXNhYmxlKHN0cnVjdCB3aXBoeSAqd2lwaHksCj4gICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ICAgICAgICAgICAgICAgICBjYXAgPSB2aHRfY2FwLT5j YXAgJiAKPiBJRUVFODAyMTFfVkhUX0NBUF9TVVBQX0NIQU5fV0lEVEhfTUFTSzsKPiAgICAgICAg ICAgICAgICAgaWYgKGNhcCAhPSBJRUVFODAyMTFfVkhUX0NBUF9TVVBQX0NIQU5fV0lEVEhfMTYw TUhaICYmCj4gLSAgICAgICAgICAgICAgICAgICBjYXAgIT0gCj4gSUVFRTgwMjExX1ZIVF9DQVBf U1VQUF9DSEFOX1dJRFRIXzE2MF84MFBMVVM4ME1IWikKPiArICAgICAgICAgICAgICAgICAgIGNh cCAhPSAKPiBJRUVFODAyMTFfVkhUX0NBUF9TVVBQX0NIQU5fV0lEVEhfMTYwXzgwUExVUzgwTUha ICYmCj4gKyAgICAgICAgICAgICAgICAgICAhKHZodF9jYXAtPmNhcCAmIAo+IElFRUU4MDIxMV9W SFRfQ0FQX0VYVF9OU1NfQldfTUFTSykpCj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwppbiBUYWJsZSA5LTI1MeKAlFN1cHBvcnRlZCBWSFQtTUNTIGFuZCBOU1MgU2V0IHN1 YmZpZWxkcywgaXQgaGFzIFN1YmZpZWxkIApWSFQgRXh0ZW5kZWQKTlNTIEJXIENhcGFibGUsIGl0 cyBEZWZpbml0aW9uIGlzOgpJbmRpY2F0ZXMgd2hldGhlciB0aGUgU1RBIGlzIGNhcGFibGUgb2YK aW50ZXJwcmV0aW5nIHRoZSBFeHRlbmRlZCBOU1MgQlcKU3VwcG9ydCBzdWJmaWVsZCBvZiB0aGUg VkhUIENhcGFiaWxpdGllcwpJbmZvcm1hdGlvbiBmaWVsZAoKc28gaXQgc2hvdWxkIGNoZWNrIHRo ZSBTdWJmaWVsZCBWSFQgRXh0ZW5kZWQgTlNTIEJXIENhcGFibGUgaW4gCnZodF9jYXAtPnZodF9t Y3MgZmlyc3RseSwgaWYKaXQgaXMgMCwgdGhlbiBub3QgYWxsb3dlZCB0byBjaGVjayBJRUVFODAy MTFfVkhUX0NBUF9FWFRfTlNTX0JXX01BU0sgb2YgCnZodF9jYXAtPmNhcC4KcGxlYXNlIGNvcnJl Y3QgbWUgaWYgd3JvbmcuCgo+ICAgICAgICAgICAgICAgICBicmVhazsKPiAgICAgICAgIGRlZmF1 bHQ6Cj4gLS0KPiAyLjE3LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IFRoZSBpbmZvcm1hdGlvbiB0cmFuc21pdHRlZCBpcyBpbnRlbmRlZCBvbmx5IGZvciB0aGUgcGVy c29uIG9yIGVudGl0eQo+IHRvIHdoaWNoIGl0IGlzIGFkZHJlc3NlZCBhbmQgbWF5IGNvbnRhaW4g Y29uZmlkZW50aWFsIGFuZC9vcgo+IHByaXZpbGVnZWQgbWF0ZXJpYWwuIEFueSByZXRyYW5zbWlz c2lvbiwgZGlzc2VtaW5hdGlvbiwgY29weWluZyBvcgo+IG90aGVyIHVzZSBvZiwgb3IgdGFraW5n IG9mIGFueSBhY3Rpb24gaW4gcmVsaWFuY2UgdXBvbiB0aGlzCj4gaW5mb3JtYXRpb24gaXMgcHJv aGliaXRlZC4gSWYgeW91IHJlY2VpdmVkIHRoaXMgaW4gZXJyb3IsIHBsZWFzZQo+IGNvbnRhY3Qg dGhlIHNlbmRlciBhbmQgZGVsZXRlIHRoZSBtYXRlcmlhbCBmcm9tIGFueSBjb21wdXRlci4gTm90 aGluZwo+IGNvbnRhaW5lZCBoZXJlaW4gc2hhbGwgYmUgZGVlbWVkIGFzIGEgcmVwcmVzZW50YXRp b24sIHdhcnJhbnR5IG9yIGEKPiBjb21taXRtZW50IGJ5IENlbGVuby4gTm8gd2FycmFudGllcyBh cmUgZXhwcmVzc2VkIG9yIGltcGxpZWQsCj4gaW5jbHVkaW5nLCBidXQgbm90IGxpbWl0ZWQgdG8s IGFueSBpbXBsaWVkIHdhcnJhbnRpZXMgb2YKPiBub24taW5mcmluZ2VtZW50LCBtZXJjaGFudGFi aWxpdHkgYW5kIGZpdG5lc3MgZm9yIGEgcGFydGljdWxhcgo+IHB1cnBvc2UuCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KCi0tIAphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vYXRoMTFrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1946C433B4 for ; Wed, 19 May 2021 07:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7016C60725 for ; Wed, 19 May 2021 07:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238016AbhESHZA (ORCPT ); Wed, 19 May 2021 03:25:00 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:33722 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbhESHZA (ORCPT ); Wed, 19 May 2021 03:25:00 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621409021; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Xi6rm+02wfE8iimkDrJVtwRuysvJH7sJ44vjdfKzLeY=; b=t0cZ8u5aTtuHisgBi1uVr5aZ2GNt8tZw3PT6zUSW00wdp8NjkjRFCi4cKDX6D5taC3hz48xc SF5oSe2seT5eKSoXLY/NgAJJHQfhWzf1ntxFidiOS/y9RPpuq5xsJ6DP6IjB5Qn8pUgLtaKD vX1Hfy2llCAG1YgUPbJU/C5iPUA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 60a4bcdd2bff04e53be67a21 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 19 May 2021 07:23:09 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B258FC4338A; Wed, 19 May 2021 07:23:09 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id DDCC9C4338A; Wed, 19 May 2021 07:23:08 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 19 May 2021 15:23:08 +0800 From: Wen Gong To: Shay Bar Cc: Johannes Berg , linux-wireless@vger.kernel.org, aviad.brikman@celeno.com, eliav.farber@celeno.com, linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH] wireless: fix wrong 160/80+80 MHz setting In-Reply-To: <20200826143139.25976-1-shay.bar@celeno.com> References: <20200826143139.25976-1-shay.bar@celeno.com> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-08-26 22:31, Shay Bar wrote: > Fix cfg80211_chandef_usable(): > consider IEEE80211_VHT_CAP_EXT_NSS_BW when verifying 160/80+80 MHz. > > Based on: > "Table 9-272 — Setting of the Supported Channel Width Set subfield and > Extended NSS BW > Support subfield at a STA transmitting the VHT Capabilities Information > field" > From "Draft P802.11REVmd_D3.0.pdf" > > Signed-off-by: Aviad Brikman > Signed-off-by: Shay Bar > --- > net/wireless/chan.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/net/wireless/chan.c b/net/wireless/chan.c > index 90f0f82cd9ca..a51d11d3be33 100644 > --- a/net/wireless/chan.c > +++ b/net/wireless/chan.c > @@ -912,6 +912,7 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy, > struct ieee80211_sta_vht_cap *vht_cap; > struct ieee80211_edmg *edmg_cap; > u32 width, control_freq, cap; > + bool support_80_80 = false; > > if (WARN_ON(!cfg80211_chandef_valid(chandef))) > return false; > @@ -979,9 +980,16 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy, > return false; > break; > case NL80211_CHAN_WIDTH_80P80: > - cap = vht_cap->cap & > IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_MASK; > + cap = vht_cap->cap; > + support_80_80 = > + ((cap & > + > IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ) || > + (cap & IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ > && > + cap & IEEE80211_VHT_CAP_EXT_NSS_BW_MASK) || > + ((cap & IEEE80211_VHT_CAP_EXT_NSS_BW_MASK) >> > + IEEE80211_VHT_CAP_EXT_NSS_BW_SHIFT > > 1)); > if (chandef->chan->band != NL80211_BAND_6GHZ && > - cap != > IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ) > + !support_80_80) > return false; > /* fall through */ > case NL80211_CHAN_WIDTH_80: > @@ -1001,7 +1009,8 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy, > return false; > cap = vht_cap->cap & > IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_MASK; > if (cap != IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ && > - cap != > IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ) > + cap != > IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ && > + !(vht_cap->cap & > IEEE80211_VHT_CAP_EXT_NSS_BW_MASK)) > return false; in Table 9-251—Supported VHT-MCS and NSS Set subfields, it has Subfield VHT Extended NSS BW Capable, its Definition is: Indicates whether the STA is capable of interpreting the Extended NSS BW Support subfield of the VHT Capabilities Information field so it should check the Subfield VHT Extended NSS BW Capable in vht_cap->vht_mcs firstly, if it is 0, then not allowed to check IEEE80211_VHT_CAP_EXT_NSS_BW_MASK of vht_cap->cap. please correct me if wrong. > break; > default: > -- > 2.17.1 > > ________________________________ > The information transmitted is intended only for the person or entity > to which it is addressed and may contain confidential and/or > privileged material. Any retransmission, dissemination, copying or > other use of, or taking of any action in reliance upon this > information is prohibited. If you received this in error, please > contact the sender and delete the material from any computer. Nothing > contained herein shall be deemed as a representation, warranty or a > commitment by Celeno. No warranties are expressed or implied, > including, but not limited to, any implied warranties of > non-infringement, merchantability and fitness for a particular > purpose. > ________________________________