From: Eric Blake <eblake@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 0/3] target/xtensa: improvements for core-specific files
Date: Thu, 22 Mar 2018 14:17:44 -0500 [thread overview]
Message-ID: <dbfa79c8-50cf-e902-bcd3-3ae39a5c3dce@redhat.com> (raw)
In-Reply-To: <20180322180940.8253-1-jcmvbkbc@gmail.com>
On 03/22/2018 01:09 PM, Max Filippov wrote:
> Hello,
>
> this series adds .inc. to the names of non-top level xtensa core-specific
> files and fixes script import_core.sh so that it does it automatically.
> It also adds a fixup to the script that changes #include <xtensa-isa.h>
> to #include "xtensa-isa.h".
>
> Max Filippov (3):
> target/xtensa: add .inc. to non-top level source file names
> target/xtensa/import_core.sh: fix names of non-top level files
> target/xtensa/import_core.sh: fix #include <xtensa-isa.h>
Simple enough. I don't know if it qualifies as a bug fix, so up to you
as maintainer whether you feel comfortable enough getting it into 2.12.
See my per-patch comments about possibly merging 1 and 2; but for the
series,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-03-22 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 18:09 [Qemu-devel] [PATCH 0/3] target/xtensa: improvements for core-specific files Max Filippov
2018-03-22 18:09 ` [Qemu-devel] [PATCH 1/3] target/xtensa: add .inc. to non-top level source file names Max Filippov
2018-03-22 19:16 ` Eric Blake
2018-03-22 20:37 ` Max Filippov
2018-03-23 2:28 ` Philippe Mathieu-Daudé
2018-03-22 18:09 ` [Qemu-devel] [PATCH 2/3] target/xtensa/import_core.sh: fix names of non-top level files Max Filippov
2018-03-22 19:15 ` Eric Blake
2018-03-22 18:09 ` [Qemu-devel] [PATCH 3/3] target/xtensa/import_core.sh: fix #include <xtensa-isa.h> Max Filippov
2018-03-23 2:30 ` Philippe Mathieu-Daudé
2018-03-22 19:17 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfa79c8-50cf-e902-bcd3-3ae39a5c3dce@redhat.com \
--to=eblake@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.