From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH ethtool v2 08/13] ethtool: fix runtime errors found by sanitizers
Date: Fri, 9 Dec 2022 14:09:30 -0800 [thread overview]
Message-ID: <dc08b6de-4bef-6439-ef6d-a8d667621963@intel.com> (raw)
In-Reply-To: <20221209180934.cknkbvdr7gkphenf@lion.mk-sys.cz>
On 12/9/2022 10:09 AM, Michal Kubecek wrote:
>> I'll do it whichever way you like, but you're correct, later in this series
>> I fix up all the BIT() usages. Maybe we can just leave this patch as is,
>> knowing the full fix comes during the refactor in 10/13 ?
>
> As we end up with BIT() everywhere anyway, I'm OK with either option,
> leaving this patch as it is or dropping it. When I was writing that
> comment, I had seen 09/13 (introduction of BIT()) but not 10/13
> (refactoring everything to use it).
Ok, thanks. Also Jakub pointed out to me there is a UAPI compliant
_BITUL()/_BITULL() function in include/uapi/linux/const.h, which I'll
switch 9 and 10 to using. Wish that function had been a tad more
discoverable.
next prev parent reply other threads:[~2022-12-09 22:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 1:11 [PATCH ethtool v2 00/13] ethtool: clean up and fix Jesse Brandeburg
2022-12-08 1:11 ` [PATCH ethtool v2 01/13] ethtool: convert boilerplate licenses to SPDX Jesse Brandeburg
2022-12-08 8:17 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 02/13] ethtool: fix trivial issue in allocation Jesse Brandeburg
2022-12-08 8:26 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 03/13] ethtool: disallow passing null to find_option Jesse Brandeburg
2022-12-08 9:14 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 04/13] ethtool: commonize power related strings Jesse Brandeburg
2022-12-08 10:25 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 05/13] ethtool: fix extra warnings Jesse Brandeburg
2022-12-08 10:43 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 06/13] ethtool: fix uninitialized local variable use Jesse Brandeburg
2022-12-08 2:06 ` Andrew Lunn
2022-12-08 1:11 ` [PATCH ethtool v2 07/13] ethtool: avoid null pointer dereference Jesse Brandeburg
2022-12-08 6:23 ` Michal Kubecek
2022-12-09 17:36 ` Jesse Brandeburg
2022-12-09 18:06 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 08/13] ethtool: fix runtime errors found by sanitizers Jesse Brandeburg
2022-12-08 6:34 ` Michal Kubecek
2022-12-09 17:42 ` Jesse Brandeburg
2022-12-09 18:09 ` Michal Kubecek
2022-12-09 22:09 ` Jesse Brandeburg [this message]
2022-12-08 1:11 ` [PATCH ethtool v2 09/13] ethtool: merge uapi changes to implement BIT and friends Jesse Brandeburg
2022-12-08 6:44 ` Michal Kubecek
2022-12-09 17:53 ` Jesse Brandeburg
2022-12-08 1:11 ` [PATCH ethtool v2 10/13] ethtool: refactor bit shifts to use BIT and BIT_ULL Jesse Brandeburg
2022-12-08 1:11 ` [PATCH ethtool v2 11/13] ethtool: fix missing free of memory after failure Jesse Brandeburg
2022-12-08 10:52 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 12/13] ethtool: fix leak of memory after realloc Jesse Brandeburg
2022-12-08 11:30 ` Michal Kubecek
2022-12-08 1:11 ` [PATCH ethtool v2 13/13] ethtool: fix bug and use standard string parsing Jesse Brandeburg
2022-12-08 11:48 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc08b6de-4bef-6439-ef6d-a8d667621963@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.