From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 04 Mar 2019 07:06:36 -0000 Received: from mx1.redhat.com ([209.132.183.28]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h0hgJ-0002VC-5n for speck@linutronix.de; Mon, 04 Mar 2019 08:06:35 +0100 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E57568535C for ; Mon, 4 Mar 2019 07:06:28 +0000 (UTC) Received: from tonnant.bos.jonmasters.org (ovpn-120-248.rdu2.redhat.com [10.10.120.248]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F6645D71A for ; Mon, 4 Mar 2019 07:06:28 +0000 (UTC) References: <20190301214738.281554861@linutronix.de> <20190301214847.896222054@linutronix.de> From: Jon Masters Message-ID: Date: Mon, 4 Mar 2019 02:06:27 -0500 MIME-Version: 1.0 In-Reply-To: Subject: [MODERATED] Encrypted Message Content-Type: multipart/mixed; boundary="fRSduE9l2qm4rRL6clAIelQ4eqqbSfHkj"; protected-headers="v1" To: speck@linutronix.de List-ID: This is an OpenPGP/MIME encrypted message (RFC 4880 and 3156) --fRSduE9l2qm4rRL6clAIelQ4eqqbSfHkj Content-Type: text/rfc822-headers; protected-headers="v1" Content-Disposition: inline From: Jon Masters To: speck for Jon Masters Subject: Re: [patch V6 08/14] MDS basics 8 --fRSduE9l2qm4rRL6clAIelQ4eqqbSfHkj Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/4/19 1:57 AM, speck for Jon Masters wrote: > On 3/1/19 4:47 PM, speck for Thomas Gleixner wrote: >> if (static_branch_unlikely(&vmx_l1d_should_flush)) >> vmx_l1d_flush(vcpu); >> + else if (static_branch_unlikely(&mds_user_clear)) >> + mds_clear_cpu_buffers(); >=20 > Does this cover the case where we have older ucode installed that does > L1D flush but NOT the MD_CLEAR? I'm about to go check to see if there's= > logic handling this but wanted to call it out. Aside from the above question, I've reviewed all of the patches extensively at this point. Feel free to add a Reviewed-by or Tested-by according to your preference. I've a bunch of further tests running, including on AMD platforms just so to check nothing broke with those platforms that are not susceptible to MDS. Jon. --=20 Computer Architect | Sent with my Fedora powered laptop --fRSduE9l2qm4rRL6clAIelQ4eqqbSfHkj--