From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM mailing list <linux-pm@vger.kernel.org>,
Lukasz Luba <Lukasz.Luba@arm.com>
Subject: Trip points crossed not detected when no cooling device bound
Date: Wed, 26 Jun 2024 08:50:46 +0200 [thread overview]
Message-ID: <dc1e6cba-352b-4c78-93b5-94dd033fca16@linaro.org> (raw)
Hi,
after experimenting different setup I noticed there is no longer trip
crossed notifications sent to the userspace when there is no cooling
device bound to a thermal zone.
git bisecting leads me to this commit:
202aa0d4bb532338cd27bcc64c60abc2987a2be7 is the first bad commit
commit 202aa0d4bb532338cd27bcc64c60abc2987a2be7
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Tue Apr 30 17:45:55 2024 +0200
thermal: core: Do not call handle_thermal_trip() if zone
temperature is invalid
Make __thermal_zone_device_update() bail out if update_temperature()
fails to update the zone temperature because __thermal_zone_get_temp()
has returned an error and the current zone temperature is
THERMAL_TEMP_INVALID (user space receiving netlink thermal messages,
thermal debug code and thermal governors may get confused otherwise).
Fixes: 9ad18043fb35 ("thermal: core: Send trip crossing
notifications at init time if needed")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
drivers/thermal/thermal_core.c | 3 +++
1 file changed, 3 insertions(+)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next reply other threads:[~2024-06-26 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 6:50 Daniel Lezcano [this message]
2024-06-26 10:38 ` Trip points crossed not detected when no cooling device bound Rafael J. Wysocki
2024-06-26 21:21 ` Daniel Lezcano
2024-06-26 22:24 ` Daniel Lezcano
2024-06-27 9:54 ` Rafael J. Wysocki
2024-06-27 16:30 ` Daniel Lezcano
2024-06-27 18:23 ` Rafael J. Wysocki
2024-06-28 8:04 ` Daniel Lezcano
2024-06-28 10:49 ` Rafael J. Wysocki
2024-06-28 12:26 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc1e6cba-352b-4c78-93b5-94dd033fca16@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Lukasz.Luba@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.