From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE4FC43458 for ; Mon, 29 Jun 2026 14:09:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1weCfE-0007Yk-R4; Mon, 29 Jun 2026 10:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weCfA-0007Y7-9S for qemu-devel@nongnu.org; Mon, 29 Jun 2026 10:08:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weCf8-0003Zz-2D for qemu-devel@nongnu.org; Mon, 29 Jun 2026 10:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782742115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YWU3w74Uw6TNjG9FtCdjy2t1znpl7sxW4LG0tlPOhw0=; b=ePm/hSGktb2Dp8E/c1hXGciToMdbWCO/nttFtURN7SPFLI8NRPP+De2GvCvkcQX1SphZV1 V7EmOIyRHHukw2v4UKjhT3sEVh+wW1BFUnAXH77kEe3+K560ZHyBaSrF44nTmeyjHWhnPA P0+2Og564f1HT8U3jVKfyQpygWWavTo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-RlatFUMJPpaH0QMYrzaYWg-1; Mon, 29 Jun 2026 10:08:31 -0400 X-MC-Unique: RlatFUMJPpaH0QMYrzaYWg-1 X-Mimecast-MFC-AGG-ID: RlatFUMJPpaH0QMYrzaYWg_1782742110 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47407691804so413346f8f.1 for ; Mon, 29 Jun 2026 07:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782742110; x=1783346910; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YWU3w74Uw6TNjG9FtCdjy2t1znpl7sxW4LG0tlPOhw0=; b=OMYJnRAZhDaTjl/vM8emnYXa2wDy/ra5USge2g6yK5b6akFsdn/87/j0Kb41gKE5DD jlac4u7Zk4Qa10+bxZ9mI8CfDdgf3jLGHQWZGvPftS4TKJoc/XTkA6Q8xMMt3XPPr0Z8 O0IBEHo+OzBnUtFtVUDVL+8z980vQoNDR/RUWkVEGbqdRD1GpYgY0UXq+o4R7ozbd/2V oyMgz5VMLhZCnt9DXy1BfgYokottdbELbgxslE1+vPTy1zAfPoBWKQyef1rAXYUHW0wv 9J7y22qzRoy/TbtXHd9kJTbgRKTikjslgZmuOzdMeJ3TGPYvlaI/a3nzrssWUBnyvxE/ p8Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782742110; x=1783346910; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YWU3w74Uw6TNjG9FtCdjy2t1znpl7sxW4LG0tlPOhw0=; b=L/thS/5SIzLT5KUja6a1pbxAxEslgdHHecL4eJD3JK5rnBQK0r7lJf2/DvVylxKV4i jP3D1mJLRQRIFtaP2G7EhDLf0ijY0GRbFKkwfh/rrA3c++DskBgbl3B/EMBQUZzmjpDS +Fa5z7xmxOTpOt4E0MLc+vRo5Byo00KYs0lpizXdSNv4PShRrBUTlWdwXtyAmCD8Tzzl T/JD6zBjFuz745KYV1gVseqMqoZ7ebg5BKQGeM7EcHKK3smYvetyQrTB9m8qLF7+/6wt xI417qGw8MAuS8YZO6tvjRUXdXyKzp1xhe9XwPfCicJBr80vOcuf1WgpCRetX4H2qBwY qgjA== X-Forwarded-Encrypted: i=1; AHgh+RrFmnjh41TSgV5uJRKp7wVkw9+TcFFQHBg0bsyf6iwEKAWW7YChmHmRH/5tSstkDn+hrHm5sD+Ikvo2@nongnu.org X-Gm-Message-State: AOJu0Yy2viB2/uf0NtEXR1tBQ60TncrJCU2ZO3w09jppMyp/2ma9VfDf INDhXr32J8r7H/frXR29eSreXLq/HJcOz1Kz9F1Gc4zyxxyBWVK1+NvFsteVDpomAu51asJYVh0 P8A8qNj5RMs9X5QPli7B1Pg8hyuDYllebyvT7f7GReaZ3fcl8ejFVZe0o X-Gm-Gg: AfdE7cl/D2yUxJ+AcRVoTRIDP5XWrh5ERn8IFbS2OsjEpu5g64vEZkvR2cqi7AKlLR1 9jX9bx01HF2dLx2m4ne0Jb9qw5xF0qCH6jr0ouvrmR1IfN9g2P8sSnHA4TevN8OAAp/ZvVv/bq7 92IbpbnoCg5YG7ElLXE/YyNM4BJK34xbOv0L27/zbME6Tpg08ylhpVftsxWM4sGW9jT7z158wLH 113nkelLEHk+nfIS4qx+PTVD1unJJtkFQ20xkcXwbTncEfcrF4JMAeUzyc6eadt76J+qIUrcP9T MKY588uMRL8utQIO1Fsk8bCvut2Uk5T2ANgGPKIeYbkrF8a4iztsgmXHs3SZvBtKXg5vsQMIbVa NS29PO8FL8cZAgAVXy974Pe1zgVMaof/WS+2IiyHrQYexjTwxpwU+Qw== X-Received: by 2002:a05:6000:2307:b0:471:f180:86d7 with SMTP id ffacd0b85a97d-471f1808813mr11795293f8f.41.1782742110427; Mon, 29 Jun 2026 07:08:30 -0700 (PDT) X-Received: by 2002:a05:6000:2307:b0:471:f180:86d7 with SMTP id ffacd0b85a97d-471f1808813mr11795242f8f.41.1782742109959; Mon, 29 Jun 2026 07:08:29 -0700 (PDT) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4721c88bfcasm21180785f8f.10.2026.06.29.07.08.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 07:08:29 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 16:08:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 16/17] sbsa-gwdt: reschedule timer on direct WCV load Content-Language: en-US To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, peter.maydell@linaro.org, shannon.zhaosl@gmail.com, rad@semihalf.com, leif.lindholm@oss.qualcomm.com, qemu-arm@nongnu.org References: <20260624102830.1355552-1-imammedo@redhat.com> <20260624102830.1355552-17-imammedo@redhat.com> From: Eric Auger In-Reply-To: <20260624102830.1355552-17-imammedo@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eauger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/24/26 12:28 PM, Igor Mammedov wrote: > According to spec[1]: > > "The compare value can either be loaded directly or indirectly on an > explicit refresh or timeout refresh" > > QEMU accepts writes to WCV but doesn't reschedule the timer, > which it should per the spec pseudo code: > > "TimeoutRefresh = ( SystemCounter [63:0] > CompareValue [63:0])" > > Fix it by updating the timer on WCV write. > > Fixes Windows in GTDT mode, which never issues a WRR refresh. > Instead, it programs WOR to ~4 sec, enables WCS, and immediately > writes a large absolute value into WCV to push the timeout far > into the future. Without this fix, QEMU ignores the WCV write, > the short WOR expires, and the guest reboots unexpectedly. > > 1) Arm® Server Base System Architecture 6.0 > Platform Design Document > DEN0029D 6.0 > "A.2 Watchdog Operation" > > Signed-off-by: Igor Mammedov > --- > hw/watchdog/sbsa_gwdt.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c > index 5ee0e06af5..fb67db9672 100644 > --- a/hw/watchdog/sbsa_gwdt.c > +++ b/hw/watchdog/sbsa_gwdt.c > @@ -44,6 +44,7 @@ static const VMStateDescription vmstate_sbsa_gwdt = { > typedef enum WdtRefreshType { > EXPLICIT_REFRESH = 0, > TIMEOUT_REFRESH = 1, > + WCV_LOAD = 2, > } WdtRefreshType; > > static uint64_t sbsa_gwdt_rread(void *opaque, hwaddr addr, unsigned int size) > @@ -167,10 +168,16 @@ static void sbsa_gwdt_write(void *opaque, hwaddr offset, uint64_t data, > > case SBSA_GWDT_WCV: > s->wcvl = data; > + if (s->wcs & SBSA_GWDT_WCS_EN) { > + sbsa_gwdt_update_timer(s, WCV_LOAD); regarding my comment on previous patch, you could add a WCV_LOAD check in sbsa_gwdt_update_timer now. In the previous patch it is not obvious that the code is identical to the original code in default path (hence my previous comment) Eric > + } > break; > > case SBSA_GWDT_WCVU: > s->wcvu = data; > + if (s->wcs & SBSA_GWDT_WCS_EN) { > + sbsa_gwdt_update_timer(s, WCV_LOAD); > + } > break; > > default: