From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: "Bystricky, Juro" <juro.bystricky@intel.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Cc: "jurobystricky@hotmail.com" <jurobystricky@hotmail.com>
Subject: Re: [PATCH 1/1] rpm_4.14.0: clamp timestamps by default
Date: Thu, 4 Jan 2018 14:16:07 +0200 [thread overview]
Message-ID: <dc3dfbcc-cfea-5c51-007a-b352a3ed0036@linux.intel.com> (raw)
In-Reply-To: <6E51916E4A1F32428260031F4C7CD2B6404A265A@ORSMSX112.amr.corp.intel.com>
On 01/03/2018 06:59 PM, Bystricky, Juro wrote:
>> A technicality: do not patch mnacros.in, set the macro directly from
>> package_rpm.bbclass.
>>
>
> Yes, I considered this (see the [patch 0/1]). I chose to patch macros.in in the
> recipe rpm_4.14.0 instead because the new macro is introduced in RPM 4.14.0.
> I assumed we did not want to have RPM version dependencies in package_rpm.bbclass.
> But I have no strong feelings regarding this, I am pretty sure the new macro is here
> to stay in the future and it is unlikely anyone would want to use a pre-4.14.0
> version of RPM either. If you think patching package_rpm.bbclass makes more sense,
> I can send in another patch.
Yes please. Setting configuration options at runtime is always
preferable to patching the upstream source code, for maintainability
reasons. We are already drowning in patches.
Alex
prev parent reply other threads:[~2018-01-04 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 23:16 [PATCH 0/1] rpm_4.14.0: clamp timestamps Juro Bystricky
2018-01-02 23:16 ` [PATCH 1/1] rpm_4.14.0: clamp timestamps by default Juro Bystricky
2018-01-03 8:47 ` Alexander Kanavin
2018-01-03 10:40 ` Richard Purdie
2018-01-03 16:59 ` Bystricky, Juro
2018-01-04 12:16 ` Alexander Kanavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3dfbcc-cfea-5c51-007a-b352a3ed0036@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=juro.bystricky@intel.com \
--cc=jurobystricky@hotmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.