From: "Peres, Martin" <martin.peres@intel.com>
To: "Gupta, Anshuman" <anshuman.gupta@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Peres, Martin" <martin.peres@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v2 3/5] tests/i915_pm_lpsp: Skip panel-fitter subtest for 1024x768 panels
Date: Mon, 23 Mar 2020 07:00:33 +0000 [thread overview]
Message-ID: <dc41f07863814ad48c905120bb278a71@intel.com> (raw)
In-Reply-To: 20200323063248.5261-4-anshuman.gupta@intel.com
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On 2020-03-23 08:32, Anshuman Gupta wrote:
> It makes sense to skip the test if edp-panel native resoultion
> is limted to 1024x768 rather than failing the test.
Acked-by: Martin Peres <martin.peres@linux.intel.com>
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> tests/i915/i915_pm_lpsp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> index e400c92e..0ce694e6 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -179,10 +179,10 @@ static void edp_subtest(data_t *data, bool use_panel_fitter)
> * support LPSP are too new for panels with native
> * 1024x768 resolution, so this should force the panel
> * fitter. */
> - igt_assert(c->count_modes &&
> - c->modes[0].hdisplay > 1024);
> - igt_assert(c->count_modes &&
> - c->modes[0].vdisplay > 768);
> + igt_require(c->count_modes &&
> + c->modes[0].hdisplay > 1024);
> + igt_require(c->count_modes &&
> + c->modes[0].vdisplay > 768);
> data->mode = &std_1024_mode;
> igt_output_override_mode(output, data->mode);
> } else {
>
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1774 bytes --]
[-- Attachment #3: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-23 7:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 6:32 [igt-dev] [PATCH i-g-t v2 0/5] lpsp platform agnostic support Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 1/5] lib/igt_pm: Add lib func to get lpsp capability Anshuman Gupta
2020-03-23 6:55 ` Peres, Martin
2020-03-24 6:05 ` Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 2/5] tests/i915_pm_lpsp: lpsp platform agnostic support Anshuman Gupta
2020-03-23 7:00 ` Peres, Martin
2020-03-23 7:46 ` Anshuman Gupta
2020-03-23 8:04 ` Peres, Martin
2020-03-23 12:48 ` Kai Vehmanen
2020-03-23 15:33 ` Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 3/5] tests/i915_pm_lpsp: Skip panel-fitter subtest for 1024x768 panels Anshuman Gupta
2020-03-23 7:00 ` Peres, Martin [this message]
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 4/5] tests/i915_pm_lpsp: screens-disabled subtest use igt_wait Anshuman Gupta
2020-03-23 7:05 ` Peres, Martin
2020-03-23 9:37 ` Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 5/5] tests/i915_pm_rpm: lpsp/non-lpsp screen mode_set_data Anshuman Gupta
2020-03-23 7:10 ` Peres, Martin
2020-03-23 7:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for lpsp platform agnostic support (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc41f07863814ad48c905120bb278a71@intel.com \
--to=martin.peres@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.