From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Guillaume Morin <guillaume@morinfr.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Breno Leitao <leitao@debian.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: hugetlb_madv_vs_map: fix TAP plan mismatches
Date: Mon, 5 Oct 2026 12:40:20 +0200 [thread overview]
Message-ID: <dc44e71f-5f31-4b16-a28b-debc3e5d0f86@kernel.org> (raw)
In-Reply-To: <20261004230018.190880-1-jaeyeon.lee.dev@gmail.com>
On 10/5/26 01:00, Jaeyeon Lee wrote:
> The plan was raised from 1 to 3, but the HugeTLB setup check that may
> call ksft_exit_skip() still runs after ksft_set_plan(), so a setup
> failure reports one result against a plan of 3. Move ksft_set_plan()
> below the setup check.
>
> Also, when the underflow check fails, or munmap() fails,
> test_underflow() jumps to err_cleanup and exits without reporting the
> remaining results. Report the munmap() failure as a test result and
> skip the final HugePages_Rsvd check in err_cleanup, so the output
> always contains the planned 3 results.
>
> Fixes: 827149aad495 ("selftests/mm: hugetlb_madv_vs_map: add underflow test")
> Assisted-by: LLM
> Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-10-05 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 15:36 [PATCH v5] selftests/mm: hugetlb_madv_vs_map: add underflow test Guillaume Morin
2026-10-04 23:00 ` [PATCH] selftests/mm: hugetlb_madv_vs_map: fix TAP plan mismatches Jaeyeon Lee
2026-10-05 10:40 ` David Hildenbrand (Arm) [this message]
2026-10-05 11:12 ` Sarthak Sharma
2026-10-06 8:15 ` [PATCH v5] selftests/mm: hugetlb_madv_vs_map: add underflow test Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc44e71f-5f31-4b16-a28b-debc3e5d0f86@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guillaume@morinfr.org \
--cc=jaeyeon.lee.dev@gmail.com \
--cc=leitao@debian.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.