From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B84D179A3 for ; Thu, 20 Nov 2025 06:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763618460; cv=none; b=JLj+Jls7PF+zp5pCZLy5gm4AwMtOyOqL5uPfqlvjSz4jyyTbUAJZnIGqzzDQiz0euITs9okFXVxQbk8jR0NKn4YDUS4Fm0GQ8x5CjXGrmBM0G+7dXuOEWzJgpoMqHB5nhULctRpAs3F1+FB0d7RhN/pioZ8pxAjVv87KrrlQrgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763618460; c=relaxed/simple; bh=zMqNnc4FWD58IRJuGa949PYlnpHr+m9TXXzqYBz2cNI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cLAC1YvuZrrY/v2VAKZpGnl0GOANuxBlmbigRSfh0ZBhobZQ0yq6B1CFFl3QZlKm7gwGqqrYs1EHgvmKySmNuUd52VLofnvqIx2DmJqvb/BHiUKvyfTRmN82i/qLVTJBcFC0EYz6T3x2Te7OMWu54qZjfADLM5T5GKjtXuToQuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=oWek2qYu; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="oWek2qYu" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5AJLkvSm012693; Thu, 20 Nov 2025 06:00:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=5LP6gk WgMx++BcUsyQzBpGOfUV7ymv9HiTjkaHnJvDI=; b=oWek2qYu+5lazAWjMSIZjy PIbez6VBwoPteoUxWiDflLyLB7Pb2Rq2Lxo3O9uQczqMrPCH3rUsEO1TQmIhnWs9 WPADHk/dZZWJPKQI7cPZpn9AVNLiJ/zvmHa6r1TJIBLq9I0NY7q31yEXdg58wi1T CnJpF+OBbUQrA2+UUP9vrRLZU6jhZ1vFzdTKeV3UtRKn90sVvijsqjFuMpFsaJ3B 7fjOLXRJbnCJyHmXZL6XEOWgcFa8uuBCDIQjD3vnvw2qHgf75lkmhORBX2bj/TTB B65s78UatmLH/w5ZLLDtxMvZIMLY/IlBhlkdqRBk/OXkVyyteqs8xMxGhCqCJbKg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4aejgx3e85-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 06:00:08 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5AK5xo7p025348; Thu, 20 Nov 2025 06:00:07 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4aejgx3e83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 06:00:07 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5AK33LJ7007031; Thu, 20 Nov 2025 06:00:06 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4af62jmknh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 06:00:06 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5AK606l229491938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Nov 2025 06:00:06 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0D7CD58063; Thu, 20 Nov 2025 06:00:06 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 044355805D; Thu, 20 Nov 2025 06:00:01 +0000 (GMT) Received: from [9.98.110.226] (unknown [9.98.110.226]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 20 Nov 2025 06:00:00 +0000 (GMT) Message-ID: Date: Thu, 20 Nov 2025 11:29:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] sched/psi: Make psi stubs consistent for !CONFIG_PSI To: K Prateek Nayak Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , John Stultz , Johannes Weiner , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Suren Baghdasaryan , linux-kernel@vger.kernel.org, Madadi Vineeth Reddy References: <20251117185550.365156-1-kprateek.nayak@amd.com> <20251117185550.365156-2-kprateek.nayak@amd.com> Content-Language: en-US From: Madadi Vineeth Reddy In-Reply-To: <20251117185550.365156-2-kprateek.nayak@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: E9toQGQgJN9y18RK2oob8cMlb9L_G0EP X-Authority-Analysis: v=2.4 cv=YqwChoYX c=1 sm=1 tr=0 ts=691eae68 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=zd2uoN0lAAAA:8 a=VnNF1IyMAAAA:8 a=dxaLvFDBJ1vMy-GPr-oA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: Ahnc5kDbVSBE_XbmzCSG5twMVYnf_EDd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE1MDAzMiBTYWx0ZWRfX/zysKGysQYiw LLOjq37KLvMU1yE51mpFHi4vjtETv7Om+tciIxJiHNOqpK3Wpq4nUwrX+FXvzFRROQkXJ+4w5Gf KOIF3YNdxr9pOclspT5PUHIyFkn2345SRVoV4nOzZtfHqJdEN8CcmqGV6Lq9nf/+/TqaTprCXvQ iUM5gAOok5uyU35hmnAVAeahqMgETtCp4ZN6AzNlOLWJQVGZNY8+4LD6OSXFHxPKV804F6V3kyb /94tVPOC+K7ed+7tlWmlrpBuiTDEttn8Wgv7gRbgQViqyysYdKlM31QZ3hyB98VDs/LOgyqYhhe UBtT9pEuUnq+3sLu8F+e1qK6F1wyTzBaFXcOFGZMPKNFC6gqN9u4UJc9gkrK1HSOSKyu/ur2EIJ kh0/fTGvSD+rv+IJmbMOmuLhkneXqQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_01,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1011 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2511150032 On 18/11/25 00:25, K Prateek Nayak wrote: > commit 1a6151017ee5 ("sched: psi: pass enqueue/dequeue flags to psi > callbacks directly") modified the psi_enqueue() and psi_dequeue() > functions to take the complete enqueue/dequeue flags but left the stubs > for !CONFIG_PSI unaltered. > > Modify the stubs to also accept the flags argument to keep it consistent > with CONFIG_PSI. > > Signed-off-by: K Prateek Nayak > --- > kernel/sched/stats.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h > index cbf7206b3f9d..3323d773fec3 100644 > --- a/kernel/sched/stats.h > +++ b/kernel/sched/stats.h > @@ -221,8 +221,8 @@ static inline void psi_sched_switch(struct task_struct *prev, > } > > #else /* !CONFIG_PSI: */ > -static inline void psi_enqueue(struct task_struct *p, bool migrate) {} > -static inline void psi_dequeue(struct task_struct *p, bool migrate) {} > +static inline void psi_enqueue(struct task_struct *p, int flags) {} > +static inline void psi_dequeue(struct task_struct *p, int flags) {} > static inline void psi_ttwu_dequeue(struct task_struct *p) {} > static inline void psi_sched_switch(struct task_struct *prev, > struct task_struct *next, Right. The commit that updated the function signature did not update the !CONFIG_PSI stubs accordingly. This patch corrects that. Reviewed-by: Madadi Vineeth Reddy Thanks, Vineeth