From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC74645BE3 for ; Wed, 17 Dec 2025 05:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765947706; cv=fail; b=lo8VpUGHrC6rFp3AF6C9bjo3SINxvaX5XLrTaDGEnJ/K8DzXUhWNuX0UO1QduBVEDYm2Z6s2mIQ1dv5/1knAPIZrYaQYCW4FLgU1YZqt+dZHN+BLytKe3zJe4LnSIkVHEWsjGDIwOWNw2vHR9whrltVRSQ2AK8S5hsvH+88MQro= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765947706; c=relaxed/simple; bh=gMHQYLlxALkWvXO8QhNqwo0FutJTufusoNbZxATPprI=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=mEbwT4FevLvmonFCMCi21Hf5ffQy8ZhikUxD88Mm3PpSfZuxL0GjRCWaD6dUhDxU8ysicGyuBRmm/N3JWDZTomwBAQzDbTnzBoTYbIoJgqm3MEnZhIK9uj28H6gEWPH0k9iia2dsUkMmURoGCpkG99c18kGq41fOG6enNofL73Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XQ/J4Ki3; arc=fail smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XQ/J4Ki3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765947705; x=1797483705; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=gMHQYLlxALkWvXO8QhNqwo0FutJTufusoNbZxATPprI=; b=XQ/J4Ki3zNbV+aR6OpdmBFGrOEpIK/jwt5pt6TeR7hwcHntBphCOF/Od OWuRi15UV1i8L2RNm08xdKorDh/u1rOnMYygZ955TFZIExfnFt9Qi5XD4 36hf4omMRKTCNs+3pQjFAAbsz6T1BE9GdXxJ+kdzqFhoJTRsZbppVrU6E rmvA0OZunNloZUuqdKQjVmOspFDPExUjdT2Yl5bkznwTgBvYjHPQYaq/w RJ3f4AmUetc+Mky22x239eNDKMNmwkzAzYJBF0IO7RRwiwiSgf5gpsbEX YfwY9hEJVWbPDHSc7Usfu/uXTgX6AiaboLgOs3s5MtLl3qRsNErstM5gx g==; X-CSE-ConnectionGUID: W2pHZvNLQsaJAxyWQfC4dw== X-CSE-MsgGUID: FJBtjPcYSpeV0jBb6nC4yQ== X-IronPort-AV: E=McAfee;i="6800,10657,11644"; a="67762777" X-IronPort-AV: E=Sophos;i="6.21,154,1763452800"; d="scan'208";a="67762777" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2025 21:01:44 -0800 X-CSE-ConnectionGUID: nxt67VW8RlqstCdfZXuM3w== X-CSE-MsgGUID: BZF5c+9QROuGIlB+DZ8JBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,154,1763452800"; d="scan'208";a="197818008" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2025 21:01:44 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 16 Dec 2025 21:01:43 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Tue, 16 Dec 2025 21:01:43 -0800 Received: from PH8PR06CU001.outbound.protection.outlook.com (40.107.209.70) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 16 Dec 2025 21:01:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mkuDTTd7+YuVeayX+ZNfic0M+C7EprBvckoHP6tkwRqvmRqJehLYLvzPtYeQPn1oq9Um+DtZ7Buelg2fQo140g+YV4ur+xfL71SJX8D6t2C1YcGWXRDcRpa7euTwBCICrfvNU2Rr6GKDNnQazKlNsrosu2tMAKOfmoRSselpIbdRHPA0j8yUsKxgbk/UiH/9PKbF+iu4gPLRJVvKJ3loXmwKEgrDdL6n1agBQMpvV7ckcD/7YUFEvLS0vRft2gJBXixhoTofDCAZMV6fjXho+4/1oD22bRAfLZH9ORWI4S/cENoklLTZdp87OlywDDvMcHbmUBFRXvnhclAIzGm6Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7/9vqPm4S/ocZD7vCiVxWc9JlHg4b+wKhR5diIZl90=; b=VR1AiB5nYuodyJv10wNSRo4nORyPtA5oayxwwmGJWGI02ch50gWD/rSrgSHhyJATz3d7+sP0WRULg0OGRRCe1WUI82NYCWOdZzL6u39Hc2KWgx7CLjv3grWtXostTs5IqUiyVUmDhTJKgAS02hrzidq/WaT2I/2O1/8IxbBzVOx2pOMJtA5ipJRKdOdK7jgxB+rxAMVocS7znqHME9UVJLZm8pgX0hDsc9Ku686ZtPQhGU58/wRAj78d65fLi7RWx7KnPVgQTYmBP853H0x4CWFbrNvr3CpUn+5lyP2PM+tV1mf4H0UQZgjdaLU3XKGlBGECV4anA3IJRG38QR2/dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by DS0PR11MB7767.namprd11.prod.outlook.com (2603:10b6:8:138::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.10; Wed, 17 Dec 2025 05:01:34 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::61a:aa57:1d81:a9cf]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::61a:aa57:1d81:a9cf%3]) with mapi id 15.20.9434.001; Wed, 17 Dec 2025 05:01:34 +0000 Message-ID: Date: Tue, 16 Dec 2025 21:01:32 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] fs/resctrl: Add helpers to check io_alloc support and enabled state To: Aaron Tomlin , , , , , , , , CC: , References: <20251215230257.1798865-1-atomlin@atomlin.com> <20251215230257.1798865-2-atomlin@atomlin.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <20251215230257.1798865-2-atomlin@atomlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0124.namprd03.prod.outlook.com (2603:10b6:303:8c::9) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|DS0PR11MB7767:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d80244f-d80b-4037-6ca2-08de3d2959d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Mlg2RmxzUFVzM1RFUDBHR0lDV0Z4T2FKQmY5QnBzbkdXMGx3OHFTaExlZlNs?= =?utf-8?B?V3RWaWpCblRpMjJXZDJ0WHdnVmcxdUpZR2x5WTZHY2FWaTNkZkl4RUlTcktJ?= =?utf-8?B?T0NmK1cyZERucWM1M0xBUWtnMFNrRGhNSmlMVkJFSytzS2dEWThBZnFHc3BL?= =?utf-8?B?cVRQQWMzenpTeDZBQkp2NnFxTDZDU0xtSUw4ZTd3WVF6Z2JsN2NNdVFNNUdL?= =?utf-8?B?aEwrU1hqZG1wbitMYlRkbzZXSWx2SkdUbkJ3TmtPYWM1RmwvYzdMZnhSWExQ?= =?utf-8?B?ZmRyb2FiWWo3VEdQb1A4MjBETGlxYUllM3dOUE5wYkE3RWF3UWtyY2VOZE1D?= =?utf-8?B?NXhwSmV1S0MzTStlb2RMRFZVMWpLL2NPaHFXakFsb0VMUzhsSWVpSVdzdFNn?= =?utf-8?B?UnJ2b0NIR25YOU1NaHRMaHdSb0ZEYUdaVnNZang4Zit5Vks0SGRFcTZ5a3pT?= =?utf-8?B?UktHcDBaYmFHdzZIc3ZZbU1ySXZhbWMxeHBGaGhkNERlc0FhcWwrbHl3TFhp?= =?utf-8?B?bk1VSUxURW5SODNQSm9WbFVZc0xuak9NTVZ6dFVPRVJYRTU0NjNXU1JDaTRI?= =?utf-8?B?SDlXQnBIQVZKUVZoSjFPWmdray9TVjhGNituL3BPRzNuZG9UMUdCRThqcmhC?= =?utf-8?B?U1d0SDNMdCtJUUZEcjluMm1pTHNKUkVPUDgzeWZBcEI0Wkx1Z3VNSHRCWjNx?= =?utf-8?B?U1BiOVo2SW8vamF1S2VEd0lCWUxhd0puRzZXS0JQYzZwdllTK2owUGZKQnlV?= =?utf-8?B?UFRhYk5DcktHVTQ3VC84cVRYQmRIdTN2amxMZkkwTmVXUU93RXI3SWVmTkJl?= =?utf-8?B?VFlXa0xTVk5aNGYwZ0hPclJTVVNJVEZNNU5abG41d3M1bERHWnVQb1pleE55?= =?utf-8?B?KzhteDV0Rm5qL2JpQzBqd1JPckk1cERZTGFod05Yd1gzU1VCMWpBTjdJOHpt?= =?utf-8?B?U00rVUdJMHBxYmpqWW4rRmRsRC9yQzhhQ2dNditVaDRyR2JNdXhIZkJXbTJM?= =?utf-8?B?NDVNU1g0ZThtNEladGRWQXVSZmM3T3ppQ0tYR3FOQ3M1VWNZT0RCSENTS1RR?= =?utf-8?B?SHdhN01tZ0RjUW9XTEVjYVFOS2lwMXhLS3NQWVA2VmhoWjBLdURzMUY3K0g3?= =?utf-8?B?Q1BOanhsYnFyY3dMd1VjdTNPQ2RoZUdtaGNQM0VwWWFkbUF2b092UjZUZk1O?= =?utf-8?B?VFROZ1hvY1NxNmMxenNtOTc1OEx1YXZVak1tS24zTndTTjhNck9rcmhSNUFl?= =?utf-8?B?ZGh3SXFGaHdoTW4yTTdUU05yc1pVZE5HTWFwakJqRlJKMzFzeldIWStOWlA4?= =?utf-8?B?MTlvVGl3eE5KQnJPREI2U0dYamhkNjdzUmNVZ2IxeEVUM1N6YWtwNkttMy9E?= =?utf-8?B?MVNOZU15MEl1ZUlORVR4cTg5b1dzUEd0b09uVHJ6aTZBSHJObFdiQTFGcGoz?= =?utf-8?B?K2lMYlczcnl4R29HdjZYdXNESzNlOXV4a2FWSWFwZkNuY1F4MC9kTXBvNWRV?= =?utf-8?B?cVlYcy9Wb3BFL1NxN3FoaGRrZkhaQUNuUEFyczc5Ym00QlFEdTRlTjF1N1RO?= =?utf-8?B?ZE5MbUlWRDhTaGVPMmg5ZEFVTXEyK1R1TEFyMTJQWjRrVDFYSkpXL2ptMDJP?= =?utf-8?B?QllvT3F0dm5iTDA5OHNnZ3p2VFlacmJ1TThaR1lnSGtGa25Ec1crM0JNbDc5?= =?utf-8?B?OWFpdENpRzh4M1F3UlE5ZThXVUNvaUxLMlFUNHEyZkFCOVJyZGx0VUhoZkhF?= =?utf-8?B?Y2hnSWdiKzAvWUJVRGRaNEtLVjBRSllremovNVBGMVJvdDJ0dW0vc2FBLzRv?= =?utf-8?B?WHBmcVBMS3kzMVhsMWJBSGllSDQ0Zks0Sjh0OWlVMHdXZDFSSXkzNEN0cXp2?= =?utf-8?B?K0VaNEl2aHpMNVNGenJMMU1sRFZXTmpIT3o1MzAybnd2OXVMNCsvT0xlWjVR?= =?utf-8?Q?O4VNdS8BdFOlVT4EtKYkq7ApdMMF8vaz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0NZTGhlZEF3MW9JQnZtS252dTNoL01lSGUzdUluek1PQlY4anlMazE5N2Yw?= =?utf-8?B?U2xGK09WUFZwUkpqckYvWVRWSzN1MXBVSmZWN2ErVVBKRHBBanUvZUJ5N3o1?= =?utf-8?B?Y3BDZnF5QXNHVnhvUWlsc1RMUWVGY2F0Z1MvVTBMTzl0V1VVTWtXZy9PMndT?= =?utf-8?B?Q01taTR1b0RzamRvSG1PVlBJa3dSWGhYSlNYOTBRWlhuVnZlRi9xVmU5OU1C?= =?utf-8?B?N3BQY1ZSSnpzM3dOU2t2SXphdGlDUGlKZGtiRkwwM2FBVnNkcEJpZ0ljNFNS?= =?utf-8?B?NVN6VHI3cG13cmRoSU40WllzOXBoN1NrTklVellWNXNsalRWMUxjSG12bVQ1?= =?utf-8?B?ZFIvUm04MUs0TklqLzZoTXZRa1Y3U0RMbVYxcU96ck00Y005aWlVYnozNkxH?= =?utf-8?B?eDhHZ0xISzhwR3p4eEpxTTQ5NnNoL2I4bXVtQ1RvMGFJdFJvc1lDUEZPUk8r?= =?utf-8?B?S2hvanpHMlNiNU5IcG1Dd3RhQlNheGN4TWpyVkt6REpnOVc1MXdqR3hDdi9E?= =?utf-8?B?TDljbzBxLzV4K0JYSFh1RkxCYWdWWjJQN3lrRHFWWXJjWUdVRzhsU0o0clZD?= =?utf-8?B?alJJK3hmeWl6VHB6VDd2ZmFpNlJvZHdWcVJ4NW0zcVRVakNJZHk4ajQ2Y3Np?= =?utf-8?B?MXFHKzdCdFc5ZUFJSEUrdXUwQStJYUdDdHBoaTJYMFlRajJMWVEwS1dSMVhn?= =?utf-8?B?UE5EVlNrdmJlYnNOcVllcWhWL3Q5Uy9hVTB5QjA2dURGQVdwL1ZMcTJ0UEdD?= =?utf-8?B?MVk3cm90RG5xMEE2aTlpZ3htM2VWQ09JWkxZSFRZdmllZE9pT1ZvY2w2KzI4?= =?utf-8?B?WkM0OGJpazhUMXU2dmNTbkRvU0xrUVVSMFExNnhvTi81cVdHQXpRcWtlK2t5?= =?utf-8?B?TFBwWmdORDhpbjR4bnFMQ25Pd0JFUDV6YVR2WUtuZmRMYWZHWWxKam1pZUtC?= =?utf-8?B?YzRKYXRPUlVraFNsZnpuRG1oNUYvNmwrRlVaci9qa2lkWEIyUzdpRU0zZFRp?= =?utf-8?B?SnVmaTB1OVVZTEliU01LdkdVNFdjaEN6QTJLMWtrQmVIU2pudnc4ZW5NazJm?= =?utf-8?B?ODFuMTQrYWM5Q2tkQXU1c252cG5UWlJKMmZqMW9TY0V4ZDJBaFUzTHlBTFI1?= =?utf-8?B?SG9nQUZWeEJ3Q3dNamVlNXlWVDhlLzI0a1lidHg2VndwdjB0Y3k3c2RqZTFB?= =?utf-8?B?TE02VytSVDRWQ0pTbUcwR2l2NW5GYW5oL09HN3dXT2NJcjdZd1hHRmVpb0o4?= =?utf-8?B?RkZ3K3dST29Cb2hzdnZHZGZWWkJ3VWdXdWhuSkdWR3dkbVdmTUdReC84cGRG?= =?utf-8?B?WHFMZEY2QmpMZEd3NnE5d0ZJZUxjZ1hkdXFvRVRRNHpFek9DQmJCVGxYTUNz?= =?utf-8?B?cjNJWE52WHNhN0JwTUsyMDRKcVF0ZmE3NzFFWk9TbDNTckk0RVkyTkdJMVRR?= =?utf-8?B?N25sVTFuZkVJRHdqU2pYU0VhZWJwVm5jKzBub1VpdDhPWk1ZdytDc2d0Mmhm?= =?utf-8?B?eTltRFV2UXkrSnB3cEVObGd2VEJrZ0x5OXhLRURWZzBna05JNFhZUjlYWXh2?= =?utf-8?B?MGxZYUhFbnRBWG5NQ1k2THNnT2p1WWZKTHVsYXZuMUhDa1g1bjJTRjYxWnpN?= =?utf-8?B?UzVhSjZhSlJFNXl2bnlNbHJHazBnNHI4eTFTSElJMjIyeUNHc29hamVBdjA2?= =?utf-8?B?amdaUEJobWVnUTZJcVh1T1BzTlk3bmxMUWYweHpMbEdQNnFUbTBjajkzTE5K?= =?utf-8?B?ZFV4NlRLV2FNbXRtS3BGZVdGQytUTENrRXhPMlhWcFJwc3UySXFnZ1IzWWQ2?= =?utf-8?B?TXBHMFNDWGtRMWVxS3kvaFpwT0pabUN3dGlwKy9EQzNWbTBxc2pGZkpTQmtz?= =?utf-8?B?ZkxIc01pdTZ5UjlodlEvQndsOGhJUFZXR0ZMUjRHV3VNYkw1WnV0QitLdFdV?= =?utf-8?B?RHBwb2ZaQ0YxVTUvYTNmcko2UGRUdUdhTkkrT3ZVMmZaMnFUTUpEMmp5c25k?= =?utf-8?B?RWw1UzhwQTI2UUNWSEhDMU1OTGJDYUVsTlBZbVRKMi9zbHZmcVZGL2tmU2Zt?= =?utf-8?B?Zm5reVI5eVdLZ0F4VUVGQmpZZlN6aHI0NmVvUXpRT3N6SWZ0eEcwU0FQVzlW?= =?utf-8?B?RmpRQUZQSlp4RGxmU0VlM1hNL29QSGhVOFQvZm9uRWlWbm5xbk1oRC80YzBB?= =?utf-8?B?T0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6d80244f-d80b-4037-6ca2-08de3d2959d9 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2025 05:01:34.4711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m4tS5shgAyFikuZN4RCTUT6hkzfidFpEHYfn/TYXzE5SyLP1lMOP0qkv3FlzImeVAcebQwm1UCmeKXVSUvw35gJdndT4limEBUYHhLon/ng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7767 X-OriginatorOrg: intel.com Hi Aaron, On 12/15/25 3:02 PM, Aaron Tomlin wrote: > This patch introduces two helpers to validate io_alloc support and > whether it is enabled. This reduces code duplication, clarifies > intent, and preserves existing semantics and messages. > > Signed-off-by: Aaron Tomlin > --- > fs/resctrl/ctrlmondata.c | 74 +++++++++++++++++++++++++++++----------- > 1 file changed, 54 insertions(+), 20 deletions(-) > > diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c > index b2d178d3556e..d2f9a4f2d887 100644 > --- a/fs/resctrl/ctrlmondata.c > +++ b/fs/resctrl/ctrlmondata.c > @@ -758,6 +758,50 @@ u32 resctrl_io_alloc_closid(struct rdt_resource *r) > return resctrl_arch_get_num_closid(r) - 1; > } > > +/* > + * resctrl_io_alloc_supported() - Establish if io_alloc is supported > + * > + * @s: resctrl resource schema. > + * > + * This function must be called under the cpu hotplug lock > + * and rdtgroup mutex > + * > + * Return: 0 on success, negative error code otherwise. > + */ > +static inline int resctrl_io_alloc_supported(struct resctrl_schema *s) > +{ > + struct rdt_resource *r = s->res; > + > + if (!r->cache.io_alloc.io_alloc_capable) { > + rdt_last_cmd_printf("io_alloc is not supported on %s\n", s->name); > + return -ENODEV; > + } > + > + return 0; > +} > + > +/* > + * resctrl_io_alloc_enabled() - Establish if io_alloc is enabled > + * > + * @s: resctrl resource schema > + * > + * This function must be called under the cpu hotplug lock > + * and rdtgroup mutex > + * > + * Return: 0 on success, negative error code otherwise. > + */ > +static inline int resctrl_io_alloc_enabled(struct resctrl_schema *s) > +{ > + struct rdt_resource *r = s->res; > + > + if (!resctrl_arch_get_io_alloc_enabled(r)) { > + rdt_last_cmd_printf("io_alloc is not enabled on %s\n", s->name); > + return -EINVAL; > + } > + > + return 0; > +} > + > ssize_t resctrl_io_alloc_write(struct kernfs_open_file *of, char *buf, > size_t nbytes, loff_t off) > { > @@ -777,11 +821,9 @@ ssize_t resctrl_io_alloc_write(struct kernfs_open_file *of, char *buf, > > rdt_last_cmd_clear(); > > - if (!r->cache.io_alloc_capable) { > - rdt_last_cmd_printf("io_alloc is not supported on %s\n", s->name); > - ret = -ENODEV; > + ret = resctrl_io_alloc_supported(s); > + if (ret) > goto out_unlock; > - } > > /* If the feature is already up to date, no action is needed. */ > if (resctrl_arch_get_io_alloc_enabled(r) == enable) > @@ -839,17 +881,13 @@ int resctrl_io_alloc_cbm_show(struct kernfs_open_file *of, struct seq_file *seq, > > rdt_last_cmd_clear(); > > - if (!r->cache.io_alloc_capable) { > - rdt_last_cmd_printf("io_alloc is not supported on %s\n", s->name); > - ret = -ENODEV; > + ret = resctrl_io_alloc_supported(s); > + if (ret) > goto out_unlock; > - } > > - if (!resctrl_arch_get_io_alloc_enabled(r)) { > - rdt_last_cmd_printf("io_alloc is not enabled on %s\n", s->name); > - ret = -EINVAL; > + ret = resctrl_io_alloc_enabled(s); > + if (ret) > goto out_unlock; > - } > > /* > * When CDP is enabled, the CBMs of the highest CLOSID of CDP_CODE and > @@ -928,17 +966,13 @@ ssize_t resctrl_io_alloc_cbm_write(struct kernfs_open_file *of, char *buf, > mutex_lock(&rdtgroup_mutex); > rdt_last_cmd_clear(); > > - if (!r->cache.io_alloc_capable) { > - rdt_last_cmd_printf("io_alloc is not supported on %s\n", s->name); > - ret = -ENODEV; > + ret = resctrl_io_alloc_supported(s); > + if (ret) > goto out_unlock; > - } > > - if (!resctrl_arch_get_io_alloc_enabled(r)) { > - rdt_last_cmd_printf("io_alloc is not enabled on %s\n", s->name); > - ret = -EINVAL; > + ret = resctrl_io_alloc_enabled(s); > + if (ret) > goto out_unlock; > - } > > io_alloc_closid = resctrl_io_alloc_closid(r); > How does this patch benefit the goal of this submission, which is to set identical CBM on all domains? If this change benefited this submission I should find these new helpers used in later patches but they are not. This seems to be an unrelated and unnecessary change mixed with this submission. It does not fix a bug nor does it support this submission and thus just adds noise when considering the new feature for inclusion. This patch can be dropped. Reinette