All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/8] tests/intel/i915_pm_rpm: Nuke bogus NULL check
Date: Tue, 13 Jan 2026 16:31:30 +0200	[thread overview]
Message-ID: <dcc090e75ff32b490630658069a817ce3f603e2e@intel.com> (raw)
In-Reply-To: <20260113120439.12577-3-ville.syrjala@linux.intel.com>

On Tue, 13 Jan 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> '&data->display' is never NULL, so don't check for it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  tests/intel/i915_pm_rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/i915_pm_rpm.c b/tests/intel/i915_pm_rpm.c
> index 778f46dbcfb9..b4da27b21b20 100644
> --- a/tests/intel/i915_pm_rpm.c
> +++ b/tests/intel/i915_pm_rpm.c
> @@ -356,7 +356,7 @@ static bool init_modeset_params_for_type(struct mode_set_data *data,
>  	igt_output_t *output = NULL;
>  	igt_display_t *display = &data->display;
>  
> -	if (!data->res || !display)
> +	if (!data->res)
>  		return false;
>  
>  	for_each_connected_output(display, output) {

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-01-13 14:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 12:04 [PATCH i-g-t 0/8] Some cleanups etc Ville Syrjala
2026-01-13 12:04 ` [PATCH i-g-t 1/8] tests/kms_plane_cursor: s/or/rect/ Ville Syrjala
2026-01-13 14:31   ` Jani Nikula
2026-01-13 12:04 ` [PATCH i-g-t 2/8] tests/intel/i915_pm_rpm: Nuke bogus NULL check Ville Syrjala
2026-01-13 14:31   ` Jani Nikula [this message]
2026-01-13 12:04 ` [PATCH i-g-t 3/8] tests/kms_rotation_crc: s/0/PIPE_A/ Ville Syrjala
2026-01-13 14:32   ` Jani Nikula
2026-01-13 12:04 ` [PATCH i-g-t 4/8] lib/kms: Nuke pipe_select() Ville Syrjala
2026-01-13 14:32   ` Jani Nikula
2026-01-13 12:04 ` [PATCH i-g-t 5/8] lib/kms: Simplify kmstest_get_vbl_flag() Ville Syrjala
2026-01-13 14:33   ` Jani Nikula
2026-01-13 12:04 ` [PATCH i-g-t 6/8] tests/kms_async_flips: Use designated initializers in wait_for_vblank() Ville Syrjala
2026-01-13 14:37   ` Jani Nikula
2026-01-13 12:04 ` [PATCH i-g-t 7/8] tests/intel/kms_pipe_stress: Eliminate double display.drm_fd initialization Ville Syrjala
2026-01-13 14:39   ` Jani Nikula
2026-01-13 12:04 ` [PATCH i-g-t 8/8] lib/kms: Turn igt_pipe_connector_valid() into a function Ville Syrjala
2026-01-13 14:41   ` Jani Nikula
2026-01-13 15:01 ` ✓ Xe.CI.BAT: success for Some cleanups etc Patchwork
2026-01-13 15:18 ` ✓ i915.CI.BAT: " Patchwork
2026-01-13 22:00 ` ✗ i915.CI.Full: failure " Patchwork
2026-01-13 23:14 ` ✗ Xe.CI.Full: " Patchwork
2026-01-15 15:09 ` ✓ Xe.CI.BAT: success for Some cleanups etc. (rev2) Patchwork
2026-01-15 15:17 ` ✓ i915.CI.BAT: " Patchwork
2026-01-15 17:26 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-15 18:22 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcc090e75ff32b490630658069a817ce3f603e2e@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.