From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B79C636D4 for ; Wed, 1 Feb 2023 22:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjBAWBQ (ORCPT ); Wed, 1 Feb 2023 17:01:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbjBAWBP (ORCPT ); Wed, 1 Feb 2023 17:01:15 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D5A1721D2 for ; Wed, 1 Feb 2023 14:01:12 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2FFEA85E33; Wed, 1 Feb 2023 23:00:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675288863; bh=6GRRYt5aNMZNRsKyHoSmp4/NA2MSLR8z21thUyNxF1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=icLiCMCaFPfnCGXlot0hfgoXpeWQFDjCihSFyAxIBm7/YABoRyyMJc5GyjfyHyX6U CkHVLhAQrBSSbEl1lhQMVjm7eFmrQxh9ofDHD7WOyD2qWD0s9eAS0uagJNQt8I2AGH NvZC53e+0VJkdQlpDJc9Ht6E9hrWN39wtm4mnUyAd8+9/gGEsvn6eo57Ts2hp0UyOj S7JrrpQX+bQbXQfCAc3CRIvY9vGyePNVwlQ9W2RVvz80rOlqtIHzlh59Ml0gesyBBG q1nDTSIdSPFmjacwDU7HSRCROLLxFVbHOihDdv7lrFVxpj2H8MjN70vcFT6FdvbxeK W32yJYqhuMlEg== Message-ID: Date: Wed, 1 Feb 2023 23:00:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge Content-Language: en-US To: Rasmus Villemoes , Jagan Teki Cc: Laurent.pinchart@ideasonboard.com, aford173@gmail.com, andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org, frieder.schrempf@kontron.de, inki.dae@samsung.com, kyungmin.park@samsung.com, linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com, matteo.lisi@engicam.com, sw0312.kim@samsung.com, tharvey@gateworks.com References: <20230126144427.607098-1-jagan@amarulasolutions.com> <06e5423f-c022-7a1c-efe0-0f4fbab664c1@prevas.dk> <31ccc974-4b01-ae47-9505-626617f07758@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 1/30/23 13:45, Rasmus Villemoes wrote: > On 27/01/2023 12.30, Marek Vasut wrote: >> On 1/27/23 12:04, Jagan Teki wrote: > >>>> Thanks, but that's exactly what I'm doing, and I don't see any >>>> modification of imx8mp.dtsi in that branch. I'm basically looking for >>>> help to do the equivalent of >>>> >>>>    88775338cd58 - arm64: dts: imx8mm: Add MIPI DSI pipeline >>>>    f964f67dd6ee - arm64: dts: imx8mm: Add eLCDIF node support >>>> >>>> for imx8mp in order to test those patches on our boards (we have two >>>> variants). >>> >>> Marek, any help here, thanks. >> >> Try attached patch. > > Thanks. I removed the lcdif2 and ldb nodes I had added from Alexander's > patch (94e6197dadc9 in linux-next) in order to apply it. I get a couple > of errors during boot: > > clk: /soc@0/bus@32c00000/mipi_dsi@32e60000: failed to reparent > media_apb to sys_pll1_266m: -22 > > and enabling a pr_debug in clk_core_set_parent_nolock() shows that this > is because > > clk_core_set_parent_nolock: clk sys_pll1_266m can not be parent of clk > media_apb > > Further, the mipi_dsi fails to probe due to > > /soc@0/bus@32c00000/mipi_dsi@32e60000: failed to get > 'samsung,burst-clock-frequency' property > > All other .dtsi files seem to have those samsung,burst-clock-frequency > and samsung,esc-clock-frequency properties, so I suppose those should > also go into the imx8mp.dtsi and are not something that the board .dts > file should supply(?). No, that samsung,esc-clock-frequency (should be some 10-20 MHz, based on your panel/bridge) and samsung,burst-clock-frequency (that's the HS clock) should go into board DT, as those are property of the attached panel/bridge. > [There's also some differences between your patch and Alexander's > regarding the lcdif2 and ldb nodes, so while my lvds display still sorta > works, I get > > fsl-ldb 32ec0000.blk-ctrl:lvds-ldb: Configured LDB clock (297000000 > Hz) does not match requested LVDS clock: 346500000 Hz > > and the image is oddly distorted/shifted. But I suppose that's > orthogonal to getting the lcdif1 -> mipi-dsi -> ... pipeline working.] Alexander is right in the reply below, you have to configure the LVDS serializer clock in DT and they must match LCDIF2 pixel clock which are also configured in DT then, else you won't get the correct LVDS clock. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2F6EC636D4 for ; Wed, 1 Feb 2023 22:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XRBly88nbsN4/uLVQmDwAHnniU3Aj8CDJ0Ul/UOJ0qA=; b=uXYYbACZdQEF+9 KmgKwcUuPWLvpk/S+YHsO188YtKnDAj/kJ6Oz9cpF2lcOQEqN6285URgorcK+y7oQPAKI/hAyggkS 9/qEN1Rgusy5JF0TnJ2WdoIaepC3+oMTt7RnnfC0NmnmjE1OjuH8PHsrb03hICn7KiClUYhU8jraQ 9LYQh2MhrTO0Gb+/d4si3pyqxZxYFTvtGTlOBYpJNuwO1bDFCpWHIDbO1fC2ri8puiSZBO/kxzgFh 9O6tCibxy7pbwEu2N+R+WNmwJb1hIHOXPC1zht3CUpHuppD5srsmJeEjjgnpsfMa50f/ydds1t96W zZbCKdFcD5SjTvivHyfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNLAH-00Dj9u-DN; Wed, 01 Feb 2023 22:01:13 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNLAD-00Dj8H-V9 for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 22:01:11 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2FFEA85E33; Wed, 1 Feb 2023 23:00:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675288863; bh=6GRRYt5aNMZNRsKyHoSmp4/NA2MSLR8z21thUyNxF1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=icLiCMCaFPfnCGXlot0hfgoXpeWQFDjCihSFyAxIBm7/YABoRyyMJc5GyjfyHyX6U CkHVLhAQrBSSbEl1lhQMVjm7eFmrQxh9ofDHD7WOyD2qWD0s9eAS0uagJNQt8I2AGH NvZC53e+0VJkdQlpDJc9Ht6E9hrWN39wtm4mnUyAd8+9/gGEsvn6eo57Ts2hp0UyOj S7JrrpQX+bQbXQfCAc3CRIvY9vGyePNVwlQ9W2RVvz80rOlqtIHzlh59Ml0gesyBBG q1nDTSIdSPFmjacwDU7HSRCROLLxFVbHOihDdv7lrFVxpj2H8MjN70vcFT6FdvbxeK W32yJYqhuMlEg== Message-ID: Date: Wed, 1 Feb 2023 23:00:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge Content-Language: en-US To: Rasmus Villemoes , Jagan Teki Cc: Laurent.pinchart@ideasonboard.com, aford173@gmail.com, andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org, frieder.schrempf@kontron.de, inki.dae@samsung.com, kyungmin.park@samsung.com, linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com, matteo.lisi@engicam.com, sw0312.kim@samsung.com, tharvey@gateworks.com References: <20230126144427.607098-1-jagan@amarulasolutions.com> <06e5423f-c022-7a1c-efe0-0f4fbab664c1@prevas.dk> <31ccc974-4b01-ae47-9505-626617f07758@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_140110_336721_FF8FA65A X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMS8zMC8yMyAxMzo0NSwgUmFzbXVzIFZpbGxlbW9lcyB3cm90ZToKPiBPbiAyNy8wMS8yMDIz IDEyLjMwLCBNYXJlayBWYXN1dCB3cm90ZToKPj4gT24gMS8yNy8yMyAxMjowNCwgSmFnYW4gVGVr aSB3cm90ZToKPiAKPj4+PiBUaGFua3MsIGJ1dCB0aGF0J3MgZXhhY3RseSB3aGF0IEknbSBkb2lu ZywgYW5kIEkgZG9uJ3Qgc2VlIGFueQo+Pj4+IG1vZGlmaWNhdGlvbiBvZiBpbXg4bXAuZHRzaSBp biB0aGF0IGJyYW5jaC4gSSdtIGJhc2ljYWxseSBsb29raW5nIGZvcgo+Pj4+IGhlbHAgdG8gZG8g dGhlIGVxdWl2YWxlbnQgb2YKPj4+Pgo+Pj4+ICDCoMKgIDg4Nzc1MzM4Y2Q1OCAtIGFybTY0OiBk dHM6IGlteDhtbTogQWRkIE1JUEkgRFNJIHBpcGVsaW5lCj4+Pj4gIMKgwqAgZjk2NGY2N2RkNmVl IC0gYXJtNjQ6IGR0czogaW14OG1tOiBBZGQgZUxDRElGIG5vZGUgc3VwcG9ydAo+Pj4+Cj4+Pj4g Zm9yIGlteDhtcCBpbiBvcmRlciB0byB0ZXN0IHRob3NlIHBhdGNoZXMgb24gb3VyIGJvYXJkcyAo d2UgaGF2ZSB0d28KPj4+PiB2YXJpYW50cykuCj4+Pgo+Pj4gTWFyZWssIGFueSBoZWxwIGhlcmUs IHRoYW5rcy4KPj4KPj4gVHJ5IGF0dGFjaGVkIHBhdGNoLgo+IAo+IFRoYW5rcy4gSSByZW1vdmVk IHRoZSBsY2RpZjIgYW5kIGxkYiBub2RlcyBJIGhhZCBhZGRlZCBmcm9tIEFsZXhhbmRlcidzCj4g cGF0Y2ggKDk0ZTYxOTdkYWRjOSBpbiBsaW51eC1uZXh0KSBpbiBvcmRlciB0byBhcHBseSBpdC4g SSBnZXQgYSBjb3VwbGUKPiBvZiBlcnJvcnMgZHVyaW5nIGJvb3Q6Cj4gCj4gICAgY2xrOiAvc29j QDAvYnVzQDMyYzAwMDAwL21pcGlfZHNpQDMyZTYwMDAwOiBmYWlsZWQgdG8gcmVwYXJlbnQKPiBt ZWRpYV9hcGIgdG8gc3lzX3BsbDFfMjY2bTogLTIyCj4gCj4gYW5kIGVuYWJsaW5nIGEgcHJfZGVi dWcgaW4gY2xrX2NvcmVfc2V0X3BhcmVudF9ub2xvY2soKSBzaG93cyB0aGF0IHRoaXMKPiBpcyBi ZWNhdXNlCj4gCj4gICAgY2xrX2NvcmVfc2V0X3BhcmVudF9ub2xvY2s6IGNsayBzeXNfcGxsMV8y NjZtIGNhbiBub3QgYmUgcGFyZW50IG9mIGNsawo+IG1lZGlhX2FwYgo+IAo+IEZ1cnRoZXIsIHRo ZSBtaXBpX2RzaSBmYWlscyB0byBwcm9iZSBkdWUgdG8KPiAKPiAgICAvc29jQDAvYnVzQDMyYzAw MDAwL21pcGlfZHNpQDMyZTYwMDAwOiBmYWlsZWQgdG8gZ2V0Cj4gJ3NhbXN1bmcsYnVyc3QtY2xv Y2stZnJlcXVlbmN5JyBwcm9wZXJ0eQo+IAo+IEFsbCBvdGhlciAuZHRzaSBmaWxlcyBzZWVtIHRv IGhhdmUgdGhvc2Ugc2Ftc3VuZyxidXJzdC1jbG9jay1mcmVxdWVuY3kKPiBhbmQgc2Ftc3VuZyxl c2MtY2xvY2stZnJlcXVlbmN5IHByb3BlcnRpZXMsIHNvIEkgc3VwcG9zZSB0aG9zZSBzaG91bGQK PiBhbHNvIGdvIGludG8gdGhlIGlteDhtcC5kdHNpIGFuZCBhcmUgbm90IHNvbWV0aGluZyB0aGF0 IHRoZSBib2FyZCAuZHRzCj4gZmlsZSBzaG91bGQgc3VwcGx5KD8pLgoKTm8sIHRoYXQgc2Ftc3Vu Zyxlc2MtY2xvY2stZnJlcXVlbmN5IChzaG91bGQgYmUgc29tZSAxMC0yMCBNSHosIGJhc2VkIG9u IAp5b3VyIHBhbmVsL2JyaWRnZSkgYW5kIHNhbXN1bmcsYnVyc3QtY2xvY2stZnJlcXVlbmN5ICh0 aGF0J3MgdGhlIEhTIApjbG9jaykgc2hvdWxkIGdvIGludG8gYm9hcmQgRFQsIGFzIHRob3NlIGFy ZSBwcm9wZXJ0eSBvZiB0aGUgYXR0YWNoZWQgCnBhbmVsL2JyaWRnZS4KCj4gW1RoZXJlJ3MgYWxz byBzb21lIGRpZmZlcmVuY2VzIGJldHdlZW4geW91ciBwYXRjaCBhbmQgQWxleGFuZGVyJ3MKPiBy ZWdhcmRpbmcgdGhlIGxjZGlmMiBhbmQgbGRiIG5vZGVzLCBzbyB3aGlsZSBteSBsdmRzIGRpc3Bs YXkgc3RpbGwgc29ydGEKPiB3b3JrcywgSSBnZXQKPiAKPiAgICBmc2wtbGRiIDMyZWMwMDAwLmJs ay1jdHJsOmx2ZHMtbGRiOiBDb25maWd1cmVkIExEQiBjbG9jayAoMjk3MDAwMDAwCj4gSHopIGRv ZXMgbm90IG1hdGNoIHJlcXVlc3RlZCBMVkRTIGNsb2NrOiAzNDY1MDAwMDAgSHoKPiAKPiBhbmQg dGhlIGltYWdlIGlzIG9kZGx5IGRpc3RvcnRlZC9zaGlmdGVkLiBCdXQgSSBzdXBwb3NlIHRoYXQn cwo+IG9ydGhvZ29uYWwgdG8gZ2V0dGluZyB0aGUgbGNkaWYxIC0+IG1pcGktZHNpIC0+IC4uLiBw aXBlbGluZSB3b3JraW5nLl0KCkFsZXhhbmRlciBpcyByaWdodCBpbiB0aGUgcmVwbHkgYmVsb3cs IHlvdSBoYXZlIHRvIGNvbmZpZ3VyZSB0aGUgTFZEUyAKc2VyaWFsaXplciBjbG9jayBpbiBEVCBh bmQgdGhleSBtdXN0IG1hdGNoIExDRElGMiBwaXhlbCBjbG9jayB3aGljaCBhcmUgCmFsc28gY29u ZmlndXJlZCBpbiBEVCB0aGVuLCBlbHNlIHlvdSB3b24ndCBnZXQgdGhlIGNvcnJlY3QgTFZEUyBj bG9jay4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E2FC636D4 for ; Wed, 1 Feb 2023 22:01:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D462010E091; Wed, 1 Feb 2023 22:01:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D6AD10E091 for ; Wed, 1 Feb 2023 22:01:10 +0000 (UTC) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2FFEA85E33; Wed, 1 Feb 2023 23:00:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675288863; bh=6GRRYt5aNMZNRsKyHoSmp4/NA2MSLR8z21thUyNxF1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=icLiCMCaFPfnCGXlot0hfgoXpeWQFDjCihSFyAxIBm7/YABoRyyMJc5GyjfyHyX6U CkHVLhAQrBSSbEl1lhQMVjm7eFmrQxh9ofDHD7WOyD2qWD0s9eAS0uagJNQt8I2AGH NvZC53e+0VJkdQlpDJc9Ht6E9hrWN39wtm4mnUyAd8+9/gGEsvn6eo57Ts2hp0UyOj S7JrrpQX+bQbXQfCAc3CRIvY9vGyePNVwlQ9W2RVvz80rOlqtIHzlh59Ml0gesyBBG q1nDTSIdSPFmjacwDU7HSRCROLLxFVbHOihDdv7lrFVxpj2H8MjN70vcFT6FdvbxeK W32yJYqhuMlEg== Message-ID: Date: Wed, 1 Feb 2023 23:00:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge Content-Language: en-US To: Rasmus Villemoes , Jagan Teki References: <20230126144427.607098-1-jagan@amarulasolutions.com> <06e5423f-c022-7a1c-efe0-0f4fbab664c1@prevas.dk> <31ccc974-4b01-ae47-9505-626617f07758@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, matteo.lisi@engicam.com, linux-amarula@amarulasolutions.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org, frieder.schrempf@kontron.de, kyungmin.park@samsung.com, Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com, m.szyprowski@samsung.com, aford173@gmail.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/30/23 13:45, Rasmus Villemoes wrote: > On 27/01/2023 12.30, Marek Vasut wrote: >> On 1/27/23 12:04, Jagan Teki wrote: > >>>> Thanks, but that's exactly what I'm doing, and I don't see any >>>> modification of imx8mp.dtsi in that branch. I'm basically looking for >>>> help to do the equivalent of >>>> >>>>    88775338cd58 - arm64: dts: imx8mm: Add MIPI DSI pipeline >>>>    f964f67dd6ee - arm64: dts: imx8mm: Add eLCDIF node support >>>> >>>> for imx8mp in order to test those patches on our boards (we have two >>>> variants). >>> >>> Marek, any help here, thanks. >> >> Try attached patch. > > Thanks. I removed the lcdif2 and ldb nodes I had added from Alexander's > patch (94e6197dadc9 in linux-next) in order to apply it. I get a couple > of errors during boot: > > clk: /soc@0/bus@32c00000/mipi_dsi@32e60000: failed to reparent > media_apb to sys_pll1_266m: -22 > > and enabling a pr_debug in clk_core_set_parent_nolock() shows that this > is because > > clk_core_set_parent_nolock: clk sys_pll1_266m can not be parent of clk > media_apb > > Further, the mipi_dsi fails to probe due to > > /soc@0/bus@32c00000/mipi_dsi@32e60000: failed to get > 'samsung,burst-clock-frequency' property > > All other .dtsi files seem to have those samsung,burst-clock-frequency > and samsung,esc-clock-frequency properties, so I suppose those should > also go into the imx8mp.dtsi and are not something that the board .dts > file should supply(?). No, that samsung,esc-clock-frequency (should be some 10-20 MHz, based on your panel/bridge) and samsung,burst-clock-frequency (that's the HS clock) should go into board DT, as those are property of the attached panel/bridge. > [There's also some differences between your patch and Alexander's > regarding the lcdif2 and ldb nodes, so while my lvds display still sorta > works, I get > > fsl-ldb 32ec0000.blk-ctrl:lvds-ldb: Configured LDB clock (297000000 > Hz) does not match requested LVDS clock: 346500000 Hz > > and the image is oddly distorted/shifted. But I suppose that's > orthogonal to getting the lcdif1 -> mipi-dsi -> ... pipeline working.] Alexander is right in the reply below, you have to configure the LVDS serializer clock in DT and they must match LCDIF2 pixel clock which are also configured in DT then, else you won't get the correct LVDS clock.