All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: airlied@gmail.com, alexander.deucher@amd.com, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, ltuikov89@gmail.com,
	matthew.brost@intel.com, pstanner@redhat.com,
	tvrtko.ursulin@igalia.com, stable-commits@vger.kernel.org
Subject: Re: Patch "drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job" has been added to the 6.10-stable tree
Date: Mon, 7 Oct 2024 20:23:54 +0200	[thread overview]
Message-ID: <dcd15de0-f2d7-45e1-bac0-1d600173465f@amd.com> (raw)
In-Reply-To: <2024100743-oozy-moving-59d4@gregkh>

Am 07.10.24 um 19:59 schrieb Greg KH:
> On Mon, Oct 07, 2024 at 07:53:26PM +0200, Christian König wrote:
>> Hi Greg,
>>
>> please drop this patch from all backports. It turned out to be broken and
>> the old handling has been restored by a revert.
>>
>> Sorry for the noise. The revert should show up in Linus tree by the end of
>> the week.
> What is the revert's git id?  I'd rather take that so we don't have any
> "why wasn't this patch applied" stuff later on.

Good point. I was also not 100% sure which ones of Tvrtko's patches we 
had to revert.

Here is the git Id from the drm-misc-fixes branch:

commit abf201f6ce14c4ceeccde5471bdf59614b83a3d8
Author: Christian König <christian.koenig@amd.com>
Date:   Mon Sep 30 15:07:49 2024 +0200

     drm/sched: revert "Always increment correct scheduler score"

     This reverts commit 087913e0ba2b3b9d7ccbafb2acf5dab9e35ae1d5.

     It turned out that the original code was correct since the rq can only
     change when there is no armed job for an entity.

     This change here broke the logic since we only incremented the counter
     for the first job, so revert it.

     Signed-off-by: Christian König <christian.koenig@amd.com>
     Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
     Link: 
https://patchwork.freedesktop.org/patch/msgid/20240930131451.536150-1-christian.koenig@amd.com

Sorry for the noise, we should have catched that during the review and 
put the stable tag on the revert as well.

Regards,
Christian.

>
> thanks,
>
> greg k-h


  reply	other threads:[~2024-10-07 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 17:50 Patch "drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job" has been added to the 6.10-stable tree gregkh
2024-10-07 17:53 ` Christian König
2024-10-07 17:54   ` Christian König
2024-10-07 17:59   ` Greg KH
2024-10-07 18:23     ` Christian König [this message]
2024-10-08  9:59       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcd15de0-f2d7-45e1-bac0-1d600173465f@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ltuikov89@gmail.com \
    --cc=matthew.brost@intel.com \
    --cc=pstanner@redhat.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.