Re: [PATCH 1/2] dt-bindings: input: pm8941-pwrkey: Document wakeup-source property

[Luca Weiss <luca@lucaweiss.eu>]

On 2025-09-09 16:33, Krzysztof Kozlowski wrote:
> On 09/09/2025 16:08, Dmitry Torokhov wrote:
>>>>    compatible:
>>>>      enum:
>>>> @@ -36,6 +33,11 @@ properties:
>>>>             pin should be configured for pull up.
>>>>      $ref: /schemas/types.yaml#/definitions/flag
>>>> 
>>>> +  wakeup-source:
>>>> +    description: |
>>>> +           Button can wake-up the system. Only applicable for 
>>>> 'resin',
>>>> +           'pwrkey' always wakes the system by default.
>>> 
>>> 
>>> I'll fix existing code, so don't repeat that style.
>> 
>> If you ack I can reformat on my side to match the patch you just sent.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for fixing that up Krzysztof! I noticed but didn't want to 
deviate
from the style just for this description. Of course better to fix the
formatting in the first place.

@Dmitry: Maybe give this patch some time (1-2 weeks?) to gather more 
feedback,
given the reasons outlined in the cover letter. Also on the driver 
patch.

Regards
Luca

> 
> Best regards,
> Krzysztof