From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B04C433FE for ; Wed, 16 Mar 2022 13:16:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.291190.494067 (Exim 4.92) (envelope-from ) id 1nUTVc-0005i8-Ep; Wed, 16 Mar 2022 13:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 291190.494067; Wed, 16 Mar 2022 13:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nUTVc-0005i1-Bu; Wed, 16 Mar 2022 13:16:12 +0000 Received: by outflank-mailman (input) for mailman id 291190; Wed, 16 Mar 2022 13:16:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nUTVa-0005hv-Sh for xen-devel@lists.xenproject.org; Wed, 16 Mar 2022 13:16:10 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ea3c16e-a52b-11ec-853b-5f4723681683; Wed, 16 Mar 2022 14:16:09 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id n33-20020a05600c3ba100b003832caf7f3aso2525389wms.0 for ; Wed, 16 Mar 2022 06:16:09 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id x3-20020a5d6b43000000b001e317fb86ecsm1699775wrw.57.2022.03.16.06.16.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 06:16:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ea3c16e-a52b-11ec-853b-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4JyIZgrE4P1Kn4wn07mmEvGGdYL63aqq7IDLnDUN0K4=; b=jU1+7OR0KHqAMwZSSC/AcyyfNbvez9kPQm09bYq4lrlWZsb0JAXV8pFTYoGRmngNft wJVP/QRVBGT+zv4eB7b9kU3ehp5LKO0WZ241yTPHIFn23dA8DNQyDwwq6TTIaAucarMx cCZEjICjiQ1nMgKmycyXt3ZIUCZ7jCx4yEFukj3M5rc2dCO1w1nqxGMYzD666z5c2biF AsVuyY0vGpjDnccH35/Y61O1IYfAkXZVlhVqWKvtWrHjwED0ttkaPnOgPke7EOw/tEzy O5DNRh+0bmuNwiDRZM4zCec1pjoaHyA2Fc8ZeODmMFP21dvx3i6g6cFJJDUN3+FiAJJv ZG4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4JyIZgrE4P1Kn4wn07mmEvGGdYL63aqq7IDLnDUN0K4=; b=ABNrlgB4g7+lIDnwqRrPAJCPy3KLhO0Blt0426hAEzFfU9eSf/SGoJvARAE6k4kqc2 lvp5FwJJCsyLnpfb5FxBltJd62t3m0lMws3YnNwNoWE9phgDQCFZtRqCeIicx5CB8pti 9T/ZYom7ofjbrpOzD0oTcBmu1gQYSJ71O56DyN7BKN/KYFl0n9EunkVUvhzguJro2WYu YFedP42aVz3FKSXh6IClM2yn+kURpKytzOOueX53PVgsZzeSAMU/ar4a0blYwDm4HpZw l+9dMezgmLhEZvsOqkq36RPe4/munZ53CV9nPswoR5bSXUcWpTdZvXMPGT7QvsjWogFq efNA== X-Gm-Message-State: AOAM531r86YX5vd7MTK46BJsrk0Nj2qxUJ61IzAQkYWLpOMNnB85HJmC DVUKM9Td6KqfmvmuNZM8jXg= X-Google-Smtp-Source: ABdhPJxZB6EkbrGbgbe1OHgAv3zK0P0DzBIxwvVRDujT7ZmPCtls8E9A1Qp3gQmydUuyyzx17yk30Q== X-Received: by 2002:a05:600c:35ce:b0:38c:7457:425 with SMTP id r14-20020a05600c35ce00b0038c74570425mr484570wmq.200.1647436569158; Wed, 16 Mar 2022 06:16:09 -0700 (PDT) Message-ID: Date: Wed, 16 Mar 2022 14:16:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF Content-Language: en-US To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: Gerd Hoffmann , Christian Schoenebeck , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Thomas Huth , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , "Richard W.M. Jones" , Warner Losh , Kyle Evans , Greg Kurz , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Huacai Chen , Jiaxun Yang , Aurelien Jarno , Jiri Pirko , Jason Wang , Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Markus Armbruster , Michael Roth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , "Dr. David Alan Gilbert" , Eric Blake , Vladimir Sementsov-Ogievskiy , Konstantin Kostiuk , Laurent Vivier , "open list:blkverify" , "open list:X86 Xen CPUs" References: <20220316095248.2613601-1-marcandre.lureau@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220316095248.2613601-1-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/3/22 10:52, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > One less qemu-specific macro. It also helps to make some headers/units > only depend on glib, and thus moved in standalone projects eventually. > > Signed-off-by: Marc-André Lureau > --- > audio/audio.h | 4 +-- > block/qcow2.h | 2 +- > bsd-user/qemu.h | 2 +- > hw/display/qxl.h | 2 +- > hw/net/rocker/rocker.h | 2 +- > hw/xen/xen_pt.h | 2 +- > include/chardev/char-fe.h | 2 +- > include/disas/dis-asm.h | 2 +- > include/hw/acpi/aml-build.h | 12 +++---- > include/hw/core/cpu.h | 2 +- > include/hw/hw.h | 2 +- > include/hw/virtio/virtio.h | 2 +- > include/hw/xen/xen-bus-helper.h | 4 +-- > include/hw/xen/xen-bus.h | 4 +-- > include/hw/xen/xen_common.h | 2 +- > include/hw/xen/xen_pvdev.h | 2 +- > include/monitor/monitor.h | 4 +-- > include/qapi/error.h | 20 ++++++------ > include/qapi/qmp/qjson.h | 8 ++--- > include/qemu/buffer.h | 2 +- > include/qemu/compiler.h | 11 ++----- > include/qemu/error-report.h | 24 +++++++------- > include/qemu/log-for-trace.h | 2 +- > include/qemu/log.h | 2 +- > include/qemu/qemu-print.h | 8 ++--- > include/qemu/readline.h | 2 +- > qga/guest-agent-core.h | 2 +- > qga/vss-win32/requester.h | 2 +- > scripts/cocci-macro-file.h | 2 +- > tests/qtest/libqos/libqtest.h | 42 ++++++++++++------------- > tests/qtest/libqtest-single.h | 2 +- > tests/qtest/migration-helpers.h | 6 ++-- > audio/alsaaudio.c | 4 +-- > audio/dsoundaudio.c | 4 +-- > audio/ossaudio.c | 4 +-- > audio/paaudio.c | 2 +- > audio/sdlaudio.c | 2 +- > block/blkverify.c | 2 +- > block/ssh.c | 4 +-- > fsdev/9p-marshal.c | 2 +- > fsdev/virtfs-proxy-helper.c | 2 +- > hw/9pfs/9p.c | 2 +- > hw/acpi/aml-build.c | 4 +-- > hw/mips/fuloong2e.c | 2 +- > hw/mips/malta.c | 2 +- > hw/net/rtl8139.c | 2 +- > hw/virtio/virtio.c | 2 +- > io/channel-websock.c | 2 +- > monitor/hmp.c | 4 +-- > nbd/server.c | 10 +++--- > qemu-img.c | 4 +-- > qemu-io.c | 2 +- > qobject/json-parser.c | 2 +- > softmmu/qtest.c | 4 +-- > tests/qtest/libqtest.c | 2 +- > tests/unit/test-qobject-input-visitor.c | 4 +-- > audio/coreaudio.m | 4 +-- > scripts/checkpatch.pl | 2 +- > 58 files changed, 130 insertions(+), 137 deletions(-) > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 3baa5e3790f7..f2bd050e3b9a 100644 > --- a/include/qemu/compiler.h > +++ b/include/qemu/compiler.h > @@ -79,19 +79,12 @@ > #define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)) - \ > sizeof(QEMU_BUILD_BUG_ON_STRUCT(x))) > > -#if defined(__clang__) > -/* clang doesn't support gnu_printf, so use printf. */ > -# define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) > -#else > -/* Use gnu_printf (qemu uses standard format strings). */ > -# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) > -# if defined(_WIN32) > +#if !defined(__clang__) && defined(_WIN32) > /* > * Map __printf__ to __gnu_printf__ because we want standard format strings even > * when MinGW or GLib include files use __printf__. > */ > -# define __printf__ __gnu_printf__ > -# endif > +# define __printf__ __gnu_printf__ > #endif Can we also poison GCC_FMT_ATTR? Maybe split in 2 patches, 1 converting and another removing unused & poisoning? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D471C433EF for ; Wed, 16 Mar 2022 13:30:26 +0000 (UTC) Received: from localhost ([::1]:32772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUTjN-0006Vs-LW for qemu-devel@archiver.kernel.org; Wed, 16 Mar 2022 09:30:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUTVg-0008F8-Hw; Wed, 16 Mar 2022 09:16:17 -0400 Received: from [2a00:1450:4864:20::334] (port=32771 helo=mail-wm1-x334.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUTVb-0002qI-6G; Wed, 16 Mar 2022 09:16:12 -0400 Received: by mail-wm1-x334.google.com with SMTP id n33-20020a05600c3ba100b003832caf7f3aso2525391wms.0; Wed, 16 Mar 2022 06:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4JyIZgrE4P1Kn4wn07mmEvGGdYL63aqq7IDLnDUN0K4=; b=jU1+7OR0KHqAMwZSSC/AcyyfNbvez9kPQm09bYq4lrlWZsb0JAXV8pFTYoGRmngNft wJVP/QRVBGT+zv4eB7b9kU3ehp5LKO0WZ241yTPHIFn23dA8DNQyDwwq6TTIaAucarMx cCZEjICjiQ1nMgKmycyXt3ZIUCZ7jCx4yEFukj3M5rc2dCO1w1nqxGMYzD666z5c2biF AsVuyY0vGpjDnccH35/Y61O1IYfAkXZVlhVqWKvtWrHjwED0ttkaPnOgPke7EOw/tEzy O5DNRh+0bmuNwiDRZM4zCec1pjoaHyA2Fc8ZeODmMFP21dvx3i6g6cFJJDUN3+FiAJJv ZG4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4JyIZgrE4P1Kn4wn07mmEvGGdYL63aqq7IDLnDUN0K4=; b=W3AbHmDjJ5UJ2WTdBiuZu6uRS7tvcgC8cSZd5qDHHvtCAr0r/+ynDl5Hj2BpFxZLn+ OqHoSgElkAiXGKLJ6NSDvgo9jAlUyCHa/qy/N1Uh5SNE640TphTU0jHh01gI63KgWY9e o3VyJwCJlGHf51TKZbRxoH8XdDuOgymXdC+gpKlBg4ZerZ6IEs/n7gePucxav5xtCico 1DTUqSm3obwDL3TtifyGyQp3O7FvODW2xhUdZBUz8I6yyE2JNJRL5Ed1ptJcPUr10RwX V7ph6vOhV8y9g/ffM/QrB5oS/upNSwYV7+c60j3OASUCO9HsTphhfCVWFp4pL0L+4Fj4 Z5kg== X-Gm-Message-State: AOAM532jmrIRttnmbd9NRVMkKhMRCL37p4UeLd6H04HW7OYo86Q1VtTb 1y08F4ozQ6JejhKKnogMwJU= X-Google-Smtp-Source: ABdhPJxZB6EkbrGbgbe1OHgAv3zK0P0DzBIxwvVRDujT7ZmPCtls8E9A1Qp3gQmydUuyyzx17yk30Q== X-Received: by 2002:a05:600c:35ce:b0:38c:7457:425 with SMTP id r14-20020a05600c35ce00b0038c74570425mr484570wmq.200.1647436569158; Wed, 16 Mar 2022 06:16:09 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id x3-20020a5d6b43000000b001e317fb86ecsm1699775wrw.57.2022.03.16.06.16.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 06:16:08 -0700 (PDT) Message-ID: Date: Wed, 16 Mar 2022 14:16:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF Content-Language: en-US To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org References: <20220316095248.2613601-1-marcandre.lureau@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220316095248.2613601-1-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::334 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , "Richard W.M. Jones" , Yanan Wang , Konstantin Kostiuk , Gerd Hoffmann , Ani Sinha , Eric Blake , Warner Losh , Stefano Stabellini , "open list:blkverify" , Huacai Chen , Markus Armbruster , Michael Roth , Anthony Perard , "open list:X86 Xen CPUs" , Laurent Vivier , Eduardo Habkost , Jiri Pirko , Kyle Evans , Greg Kurz , "Dr. David Alan Gilbert" , Paul Durrant , Stefan Hajnoczi , Paolo Bonzini , Kevin Wolf , Vladimir Sementsov-Ogievskiy , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Hanna Reitz , Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/3/22 10:52, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > One less qemu-specific macro. It also helps to make some headers/units > only depend on glib, and thus moved in standalone projects eventually. > > Signed-off-by: Marc-André Lureau > --- > audio/audio.h | 4 +-- > block/qcow2.h | 2 +- > bsd-user/qemu.h | 2 +- > hw/display/qxl.h | 2 +- > hw/net/rocker/rocker.h | 2 +- > hw/xen/xen_pt.h | 2 +- > include/chardev/char-fe.h | 2 +- > include/disas/dis-asm.h | 2 +- > include/hw/acpi/aml-build.h | 12 +++---- > include/hw/core/cpu.h | 2 +- > include/hw/hw.h | 2 +- > include/hw/virtio/virtio.h | 2 +- > include/hw/xen/xen-bus-helper.h | 4 +-- > include/hw/xen/xen-bus.h | 4 +-- > include/hw/xen/xen_common.h | 2 +- > include/hw/xen/xen_pvdev.h | 2 +- > include/monitor/monitor.h | 4 +-- > include/qapi/error.h | 20 ++++++------ > include/qapi/qmp/qjson.h | 8 ++--- > include/qemu/buffer.h | 2 +- > include/qemu/compiler.h | 11 ++----- > include/qemu/error-report.h | 24 +++++++------- > include/qemu/log-for-trace.h | 2 +- > include/qemu/log.h | 2 +- > include/qemu/qemu-print.h | 8 ++--- > include/qemu/readline.h | 2 +- > qga/guest-agent-core.h | 2 +- > qga/vss-win32/requester.h | 2 +- > scripts/cocci-macro-file.h | 2 +- > tests/qtest/libqos/libqtest.h | 42 ++++++++++++------------- > tests/qtest/libqtest-single.h | 2 +- > tests/qtest/migration-helpers.h | 6 ++-- > audio/alsaaudio.c | 4 +-- > audio/dsoundaudio.c | 4 +-- > audio/ossaudio.c | 4 +-- > audio/paaudio.c | 2 +- > audio/sdlaudio.c | 2 +- > block/blkverify.c | 2 +- > block/ssh.c | 4 +-- > fsdev/9p-marshal.c | 2 +- > fsdev/virtfs-proxy-helper.c | 2 +- > hw/9pfs/9p.c | 2 +- > hw/acpi/aml-build.c | 4 +-- > hw/mips/fuloong2e.c | 2 +- > hw/mips/malta.c | 2 +- > hw/net/rtl8139.c | 2 +- > hw/virtio/virtio.c | 2 +- > io/channel-websock.c | 2 +- > monitor/hmp.c | 4 +-- > nbd/server.c | 10 +++--- > qemu-img.c | 4 +-- > qemu-io.c | 2 +- > qobject/json-parser.c | 2 +- > softmmu/qtest.c | 4 +-- > tests/qtest/libqtest.c | 2 +- > tests/unit/test-qobject-input-visitor.c | 4 +-- > audio/coreaudio.m | 4 +-- > scripts/checkpatch.pl | 2 +- > 58 files changed, 130 insertions(+), 137 deletions(-) > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 3baa5e3790f7..f2bd050e3b9a 100644 > --- a/include/qemu/compiler.h > +++ b/include/qemu/compiler.h > @@ -79,19 +79,12 @@ > #define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)) - \ > sizeof(QEMU_BUILD_BUG_ON_STRUCT(x))) > > -#if defined(__clang__) > -/* clang doesn't support gnu_printf, so use printf. */ > -# define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) > -#else > -/* Use gnu_printf (qemu uses standard format strings). */ > -# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) > -# if defined(_WIN32) > +#if !defined(__clang__) && defined(_WIN32) > /* > * Map __printf__ to __gnu_printf__ because we want standard format strings even > * when MinGW or GLib include files use __printf__. > */ > -# define __printf__ __gnu_printf__ > -# endif > +# define __printf__ __gnu_printf__ > #endif Can we also poison GCC_FMT_ATTR? Maybe split in 2 patches, 1 converting and another removing unused & poisoning?