All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Łukasz Majewski" <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zynq: fb_mmc: Correct cast of address to u32
Date: Mon, 24 Jul 2017 15:28:50 +0200	[thread overview]
Message-ID: <dce5c1f5-ae15-6289-526e-722eadfe2530@denx.de> (raw)
In-Reply-To: <d3b1bfdb-7750-fdc9-65c4-3a92a2793c06@denx.de>

On 07/24/2017 02:53 PM, Marek Vasut wrote:
> On 07/24/2017 02:47 PM, Tom Rini wrote:
>> On Mon, Jul 24, 2017 at 02:09:56PM +0200, Marek Vasut wrote:
>>> On 07/23/2017 05:47 PM, Tom Rini wrote:
>>>> On Sun, Jul 23, 2017 at 09:05:31AM -0600, Simon Glass wrote:
>>>>
>>>>> This does not work on 64-bit machines. Update it to use ulong.
>>>>>
>>>>> This fixes the following warnings in some zynq boards;
>>>>>
>>>>> common/fb_mmc.c: In function 'fb_mmc_update_zimage':
>>>>> common/fb_mmc.c:188:13: warning: cast from pointer to integer of different
>>>>> 	size [-Wpointer-to-int-cast]
>>>>> common/fb_mmc.c:189:8: warning: cast to pointer from integer of different
>>>>> 	size [-Wint-to-pointer-cast]
>>>>>
>>>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>>>
>>>> I fixed this in a slightly different way a while ago and am waiting for
>>>> it to come in via the USB tree currently.
>>>
>>> MMC patch via USB ? Anyway, this should use uintptr_t I guess ?
>>
>> "fastboot" is USB gadget code, and comes via Lukasz.  Unless you want me
>> to pick it up directly?  Thanks!
>>
> The tags didn't indicate any such thing and I didn't see the entire
> patch since it was clipped, so ... anyway, if it's fastboot, it indeed
> goes via Lukasz.
>

The fb_mmc.c is a bit misleading.

I will take this patch when we fix issues with u-boot-usb tree.

-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

  reply	other threads:[~2017-07-24 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-23 15:05 [U-Boot] [PATCH] zynq: fb_mmc: Correct cast of address to u32 Simon Glass
2017-07-23 15:47 ` Tom Rini
2017-07-24 12:09   ` Marek Vasut
2017-07-24 12:47     ` Tom Rini
2017-07-24 12:53       ` Marek Vasut
2017-07-24 13:28         ` Łukasz Majewski [this message]
2017-07-24 13:34           ` Marek Vasut
2017-07-24 16:43   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dce5c1f5-ae15-6289-526e-722eadfe2530@denx.de \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.