RE: [bp:edac-cxl 2/5] drivers/edac/edac_device.c:705 edac_dev_register() error: uninitialized symbol 'ret'.

[Shiju Jose <shiju.jose@huawei.com>]

>-----Original Message-----
>From: Borislav Petkov <bp@alien8.de>
>Sent: 27 February 2025 10:37
>To: Shiju Jose <shiju.jose@huawei.com>
>Cc: Dan Carpenter <dan.carpenter@linaro.org>; oe-kbuild@lists.linux.dev;
>lkp@intel.com; oe-kbuild-all@lists.linux.dev; Jonathan Cameron
><jonathan.cameron@huawei.com>
>Subject: Re: [bp:edac-cxl 2/5] drivers/edac/edac_device.c:705
>edac_dev_register() error: uninitialized symbol 'ret'.
>
>On Tue, Feb 25, 2025 at 06:27:42PM +0000, Shiju Jose wrote:
>> Tested fine in the edac-cxl2 branch + following fix for the
>> allmodconfig-x86_64-clang build error reported in the other thread.
>>
>> diff --git a/drivers/edac/mem_repair.c b/drivers/edac/mem_repair.c
>> index cbe5a722715d..6f4a9dfcd7da 100755
>> --- a/drivers/edac/mem_repair.c
>> +++ b/drivers/edac/mem_repair.c
>> @@ -322,8 +322,8 @@ static int mem_repair_create_desc(struct device *dev,
>>                 return -ENOMEM;
>>
>>         for (i = 0; i < MR_MAX_ATTRS; i++) {
>> -               memcpy(&ctx->mem_repair_dev_attr[i].dev_attr,
>> -                      &dev_attr[i], sizeof(dev_attr[i]));
>> +               memcpy(&ctx->mem_repair_dev_attr[i], &dev_attr[i],
>> +                      sizeof(dev_attr[i]));
>>                 ctx->mem_repair_attrs[i] =
>>                         &ctx->mem_repair_dev_attr[i].dev_attr.attr;
>>         }
>>
>
>All fixes merged and branch pushed out.

Thanks Boris. Looks like the above fix in the drivers/edac/mem_repair.c is not yet in the
edac-cxl2 branch.

Thanks,
Shiju 
>
>Thx.
>
>--
>Regards/Gruss,
>    Boris.
>
>https://people.kernel.org/tglx/notes-about-netiquette