Re: [PATCH bpf-next v5 1/3] bpf: Prevent tailcall infinite loop caused by freplace

[Leon Hwang <leon.hwang@linux.dev>]

On 8/10/24 04:32, kernel test robot wrote:
> Hi Leon,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on bpf-next/master]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Leon-Hwang/bpf-Prevent-tailcall-infinite-loop-caused-by-freplace/20241006-210309
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> patch link:    https://lore.kernel.org/r/20241006130130.77125-2-leon.hwang%40linux.dev
> patch subject: [PATCH bpf-next v5 1/3] bpf: Prevent tailcall infinite loop caused by freplace
> config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20241008/202410080455.vy5GT8Vz-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241008/202410080455.vy5GT8Vz-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410080455.vy5GT8Vz-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from kernel/fork.c:53:
>    In file included from include/linux/security.h:35:
>>> include/linux/bpf.h:1392:5: warning: no previous prototype for function 'bpf_extension_link_prog' [-Wmissing-prototypes]
>     1392 | int bpf_extension_link_prog(struct bpf_tramp_link *link,
>          |     ^
>    include/linux/bpf.h:1392:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     1392 | int bpf_extension_link_prog(struct bpf_tramp_link *link,
>          | ^
>          | static 
>>> include/linux/bpf.h:1398:5: warning: no previous prototype for function 'bpf_extension_unlink_prog' [-Wmissing-prototypes]
>     1398 | int bpf_extension_unlink_prog(struct bpf_tramp_link *link,
>          |     ^
>    include/linux/bpf.h:1398:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     1398 | int bpf_extension_unlink_prog(struct bpf_tramp_link *link,
>          | ^
>          | static 
>    2 warnings generated.

Ack.

I'll add 'static' in patch v6.

Thanks,
Leon

[...]