From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Date: Sun, 28 Jun 2020 02:44:15 +0300 Message-ID: References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200627204338.GL5966-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart Cc: Thierry Reding , Sam Ravnborg , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 27.06.2020 23:43, Laurent Pinchart пишет: > Hi Dmitry, > > Thank you for the patch. > > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: >> This patch adds missing BUS fields to the display panel descriptions of >> the panels which are found on NVIDIA Tegra devices: >> >> 1. AUO B101AW03 >> 2. Chunghwa CLAA070WP03XG >> 3. Chunghwa CLAA101WA01A >> 4. Chunghwa CLAA101WB01 >> 5. Innolux N156BGE L21 >> 6. Samsung LTN101NT05 >> >> Suggested-by: Laurent Pinchart >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 87edd2bdf09a..986df9937650 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { >> .width = 223, >> .height = 125, >> }, >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? To be honest I don't know whether it make sense or not for LVDS. I saw that other LVDS panels in panel-simple.c use the PIXDATA flag and then looked at what timing diagrams in the datasheets show. > The rest looks good, except the Samsung panel for which I haven't been > able to locate a datasheet. > > Reviewed-by: Laurent Pinchart Thanks to you and Sam! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154B6C433DF for ; Sun, 28 Jun 2020 20:36:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9956206C3 for ; Sun, 28 Jun 2020 20:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ockKC02y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9956206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A54C66E3BC; Sun, 28 Jun 2020 20:36:53 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48B136E19A for ; Sat, 27 Jun 2020 23:44:18 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id q7so815528ljm.1 for ; Sat, 27 Jun 2020 16:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DsD7awmAZIv1K0t/HRUOLxMTKUOvG6ubHXppAfzr2+A=; b=ockKC02y8P4bF4ese89yysHA7TROKDspX0VPiNSFOxcxPv1bs5o4Ipzt77U6F/bToM Hi5GccIUp1bZi9B8t5Bea8vkAuA0LNa5bZQlODZAVq8wOSDdwwK079pGT1jls92QbPJ0 mJZcs6Si2zDMdlaKOgvh+jIstcSQBf3Qq7BMbljOEFNq2QrusldNPkAyay8JdIeW1yhl O5cdFlSsmQuSltOEMqr1kARitCHny0HzAZHwudX3LNX/nWaOUxxY2GRIVwNJ9IX2B9/l KXOHIMcXqRussDfLMZKqMbCM8gKdIBr/1Pa0A8ZubuZ1cBPDwRg5khPkSBSi5FzxpBwG HcDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DsD7awmAZIv1K0t/HRUOLxMTKUOvG6ubHXppAfzr2+A=; b=uE/z9I2jHPDaAM2zIfZVsFF3P8LgYaaxSUgFMWxMXir++/K3Z6P5H/f7EPpBEXNep4 wz8j6ECai8vajne0W5VDUqdsVJWshio9rSFG8WB3G9IUE+EVSQYmk4bu3X7oBHrOssyD z2K/o5b+d/SuEOew4ImvHxa/pROwGCc7BTqooGUgclv7gX0ut9Sy0G/UWReSQCklI8e1 wcCI7zlus8STYQwZ/XzQNIowFN8l3lky1P3DtauWVr10D5Y90xasDF9H/tzFtacxhOYC jX+acWOQjCJy3hEYWXn/wXN/g6pmCVWkdGnpBrOzG7DhcLdL5EHP5FG0SltE3luqnv9w I56w== X-Gm-Message-State: AOAM532T2+nH69aZuS26F/zkJz1gFVuACZbWpqd6r5srwdIu+12iYTz9 1+lgO/SAg5Y313cPBefsVIg= X-Google-Smtp-Source: ABdhPJydon2sdcY17f+37qAc3+Bk9DQ7NUVVnunr1D2iOWg1bSdqs9Wqpr8bbJ6Ewek0R4fAVsDI4Q== X-Received: by 2002:a2e:7601:: with SMTP id r1mr5117761ljc.111.1593301456651; Sat, 27 Jun 2020 16:44:16 -0700 (PDT) Received: from [192.168.2.145] (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.googlemail.com with ESMTPSA id e13sm6321404ljo.6.2020.06.27.16.44.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jun 2020 16:44:16 -0700 (PDT) Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels To: Laurent Pinchart References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> From: Dmitry Osipenko Message-ID: Date: Sun, 28 Jun 2020 02:44:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200627204338.GL5966@pendragon.ideasonboard.com> Content-Language: en-US X-Mailman-Approved-At: Sun, 28 Jun 2020 20:36:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjcuMDYuMjAyMCAyMzo0MywgTGF1cmVudCBQaW5jaGFydCDQv9C40YjQtdGCOgo+IEhpIERtaXRy eSwKPiAKPiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KPiAKPiBPbiBNb24sIEp1biAyMiwgMjAy MCBhdCAwMToyNzo0MkFNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IFRoaXMgcGF0 Y2ggYWRkcyBtaXNzaW5nIEJVUyBmaWVsZHMgdG8gdGhlIGRpc3BsYXkgcGFuZWwgZGVzY3JpcHRp b25zIG9mCj4+IHRoZSBwYW5lbHMgd2hpY2ggYXJlIGZvdW5kIG9uIE5WSURJQSBUZWdyYSBkZXZp Y2VzOgo+Pgo+PiAgIDEuIEFVTyBCMTAxQVcwMwo+PiAgIDIuIENodW5naHdhIENMQUEwNzBXUDAz WEcKPj4gICAzLiBDaHVuZ2h3YSBDTEFBMTAxV0EwMUEKPj4gICA0LiBDaHVuZ2h3YSBDTEFBMTAx V0IwMQo+PiAgIDUuIElubm9sdXggTjE1NkJHRSBMMjEKPj4gICA2LiBTYW1zdW5nIExUTjEwMU5U MDUKPj4KPj4gU3VnZ2VzdGVkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0 QGlkZWFzb25ib2FyZC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGln ZXR4QGdtYWlsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2lt cGxlLmMgfCAxMiArKysrKysrKysrKysKPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxl LmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPj4gaW5kZXggODdlZGQy YmRmMDlhLi45ODZkZjk5Mzc2NTAgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5l bC9wYW5lbC1zaW1wbGUuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2lt cGxlLmMKPj4gQEAgLTY5OCw2ICs2OTgsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rl c2MgYXVvX2IxMDFhdzAzID0gewo+PiAgCQkud2lkdGggPSAyMjMsCj4+ICAJCS5oZWlnaHQgPSAx MjUsCj4+ICAJfSwKPj4gKwkuYnVzX2Zvcm1hdCA9IE1FRElBX0JVU19GTVRfUkdCNjY2XzFYN1gz X1NQV0csCj4+ICsJLmJ1c19mbGFncyA9IERSTV9CVVNfRkxBR19ERV9ISUdIIHwgRFJNX0JVU19G TEFHX1BJWERBVEFfRFJJVkVfUE9TRURHRSwKPiAKPiBEb2VzIERSTV9CVVNfRkxBR19QSVhEQVRB X0RSSVZFXyogbWFrZSBzZW5zZSBmb3IgTFZEUyA/CgpUbyBiZSBob25lc3QgSSBkb24ndCBrbm93 IHdoZXRoZXIgaXQgbWFrZSBzZW5zZSBvciBub3QgZm9yIExWRFMuIEkgc2F3CnRoYXQgb3RoZXIg TFZEUyBwYW5lbHMgaW4gcGFuZWwtc2ltcGxlLmMgdXNlIHRoZSBQSVhEQVRBIGZsYWcgYW5kIHRo ZW4KbG9va2VkIGF0IHdoYXQgdGltaW5nIGRpYWdyYW1zIGluIHRoZSBkYXRhc2hlZXRzIHNob3cu Cgo+IFRoZSByZXN0IGxvb2tzIGdvb2QsIGV4Y2VwdCB0aGUgU2Ftc3VuZyBwYW5lbCBmb3Igd2hp Y2ggSSBoYXZlbid0IGJlZW4KPiBhYmxlIHRvIGxvY2F0ZSBhIGRhdGFzaGVldC4KPiAKPiBSZXZp ZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQu Y29tPgoKVGhhbmtzIHRvIHlvdSBhbmQgU2FtIQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF0AC433DF for ; Sat, 27 Jun 2020 23:44:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E982920706 for ; Sat, 27 Jun 2020 23:44:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ockKC02y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbgF0XoU (ORCPT ); Sat, 27 Jun 2020 19:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbgF0XoT (ORCPT ); Sat, 27 Jun 2020 19:44:19 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EB36C061794; Sat, 27 Jun 2020 16:44:18 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id h22so6883546lji.9; Sat, 27 Jun 2020 16:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DsD7awmAZIv1K0t/HRUOLxMTKUOvG6ubHXppAfzr2+A=; b=ockKC02y8P4bF4ese89yysHA7TROKDspX0VPiNSFOxcxPv1bs5o4Ipzt77U6F/bToM Hi5GccIUp1bZi9B8t5Bea8vkAuA0LNa5bZQlODZAVq8wOSDdwwK079pGT1jls92QbPJ0 mJZcs6Si2zDMdlaKOgvh+jIstcSQBf3Qq7BMbljOEFNq2QrusldNPkAyay8JdIeW1yhl O5cdFlSsmQuSltOEMqr1kARitCHny0HzAZHwudX3LNX/nWaOUxxY2GRIVwNJ9IX2B9/l KXOHIMcXqRussDfLMZKqMbCM8gKdIBr/1Pa0A8ZubuZ1cBPDwRg5khPkSBSi5FzxpBwG HcDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DsD7awmAZIv1K0t/HRUOLxMTKUOvG6ubHXppAfzr2+A=; b=Gc34Yvpy/BJDoutr5zMg1plloR2HBovES8fuDa0RsXkOX9fl49ykYBr/VJOf3e79c0 kNwScwUdVRuBhLi+vcPs+6+V0HFeyMusUIWoxG7teytpUdkIlKCOO3G41bHbJIG6t8Hu 0R1JbY7Wek9a2irskUCbeZCsemL+zBBtIT0t39ZC3u+UAkLLogU+hXvBf8d+d5JmUzQB +tMu0K4i0zhH7IQ3dQOXpjaoM9fzHZMTCwcTVN91ujrNsU3r4DLL0w3/JWbgy8uY7IRi DQvb0m1eQsNlOgaFLNtZyD7ALsPo34K4mrX1V3hbmNphyVzQr76a3ux1wtIAFNPZ4K+T CmDg== X-Gm-Message-State: AOAM533D4GncG9U3rNiCLJzO9wuE0gUVIQhkjha/t4X83xC4TPj/pWdA rRVCU0G9uLxXw7qTvasezmKTOLkFOK8= X-Google-Smtp-Source: ABdhPJydon2sdcY17f+37qAc3+Bk9DQ7NUVVnunr1D2iOWg1bSdqs9Wqpr8bbJ6Ewek0R4fAVsDI4Q== X-Received: by 2002:a2e:7601:: with SMTP id r1mr5117761ljc.111.1593301456651; Sat, 27 Jun 2020 16:44:16 -0700 (PDT) Received: from [192.168.2.145] (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.googlemail.com with ESMTPSA id e13sm6321404ljo.6.2020.06.27.16.44.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jun 2020 16:44:16 -0700 (PDT) Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels To: Laurent Pinchart Cc: Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> From: Dmitry Osipenko Message-ID: Date: Sun, 28 Jun 2020 02:44:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200627204338.GL5966@pendragon.ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.06.2020 23:43, Laurent Pinchart пишет: > Hi Dmitry, > > Thank you for the patch. > > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: >> This patch adds missing BUS fields to the display panel descriptions of >> the panels which are found on NVIDIA Tegra devices: >> >> 1. AUO B101AW03 >> 2. Chunghwa CLAA070WP03XG >> 3. Chunghwa CLAA101WA01A >> 4. Chunghwa CLAA101WB01 >> 5. Innolux N156BGE L21 >> 6. Samsung LTN101NT05 >> >> Suggested-by: Laurent Pinchart >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 87edd2bdf09a..986df9937650 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { >> .width = 223, >> .height = 125, >> }, >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? To be honest I don't know whether it make sense or not for LVDS. I saw that other LVDS panels in panel-simple.c use the PIXDATA flag and then looked at what timing diagrams in the datasheets show. > The rest looks good, except the Samsung panel for which I haven't been > able to locate a datasheet. > > Reviewed-by: Laurent Pinchart Thanks to you and Sam!