From: Ferry Toth <fntoth@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexander Kochetkov <al.kochet@gmail.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nishad Saraf" <nishads@amd.com>, "Lizhi Hou" <lizhi.hou@amd.com>,
"Jacky Huang" <ychuang3@nuvoton.com>,
"Shan-Chun Hung" <schung@nuvoton.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Paul Cercueil" <paul@crapouillou.net>,
"Eugeniy Paltsev" <Eugeniy.Paltsev@synopsys.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Zhou Wang" <wangzhou1@hisilicon.com>,
"Longfang Liu" <liulongfang@huawei.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Keguang Zhang" <keguang.zhang@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Andreas Färber" <afaerber@suse.de>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Samuel Holland" <samuel.holland@sifive.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Amélie Delaunay" <amelie.delaunay@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Peter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Dave Jiang" <dave.jiang@intel.com>,
"Amit Vadhavana" <av2082000@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Md Sadre Alam" <quic_mdalam@quicinc.com>,
"Casey Connolly" <casey.connolly@linaro.org>,
"Kees Cook" <kees@kernel.org>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Jyothi Kumar Seerapu" <quic_jseerapu@quicinc.com>
Subject: Re: [PATCH v2 1/2] dmaengine: virt-dma: convert tasklet to BH workqueue for callback invocation
Date: Wed, 2 Jul 2025 23:53:48 +0200 [thread overview]
Message-ID: <dd2b009a-cc8b-4f21-b248-64e909830bc0@gmail.com> (raw)
In-Reply-To: <aFku5QPf38JKlcPt@smile.fi.intel.com>
Op 23-06-2025 om 12:39 schreef Andy Shevchenko:
> On Mon, Jun 16, 2025 at 12:48:03PM +0000, Alexander Kochetkov wrote:
>> Currently DMA callbacks are called from tasklet. However the tasklet is
>> marked deprecated and must be replaced by BH workqueue. Tasklet callbacks
>> are executed either in the Soft IRQ context or from ksoftirqd thread. BH
>> workqueue work items are executed in the BH context. Changing tasklet to
>> BH workqueue improved DMA callback latencies.
>>
>> The commit changes virt-dma driver and all of its users:
>> - tasklet is replaced to work_struct, tasklet callback updated accordingly
>> - kill_tasklet() is replaced to cancel_work_sync()
>> - added include of linux/interrupt.h where necessary
>
> ...
>
>> drivers/dma/hsu/hsu.c | 2 +-
>> drivers/dma/idma64.c | 3 ++-
>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> for the above two.
With and without PREEMPT_RT (on Intel Edison) same 2 drivers.
Tested-by: Ferry Toth <fntoth@gmail.com> # for Merrifield
next prev parent reply other threads:[~2025-07-02 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 12:48 [PATCH v2 0/2] dmaengine: virt-dma: convert tasklet to BH workqueue for callback invocation Alexander Kochetkov
2025-06-16 12:48 ` [PATCH v2 1/2] " Alexander Kochetkov
2025-06-23 10:39 ` Andy Shevchenko
2025-07-02 21:53 ` Ferry Toth [this message]
2025-06-30 8:50 ` Keguang Zhang
2025-06-30 11:07 ` Amelie Delaunay
2025-08-25 17:39 ` Alexander Kochetkov
2025-06-16 12:48 ` [PATCH v2 2/2] !!! TESTING ONLY !!! Allow compile virt-dma users on ARM64 platform Alexander Kochetkov
2025-06-17 9:30 ` kernel test robot
2025-06-17 10:16 ` Alexander Kochetkov
2025-06-17 11:13 ` Andy Shevchenko
2025-06-17 10:32 ` kernel test robot
2025-06-17 13:00 ` kernel test robot
2025-06-17 13:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd2b009a-cc8b-4f21-b248-64e909830bc0@gmail.com \
--to=fntoth@gmail.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Frank.Li@nxp.com \
--cc=afaerber@suse.de \
--cc=al.kochet@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=av2082000@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=casey.connolly@linaro.org \
--cc=daniel@zonque.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=haojian.zhuang@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kees@kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=lizhi.hou@amd.com \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=nishads@amd.com \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul.walmsley@sifive.com \
--cc=paul@crapouillou.net \
--cc=peter.ujfalusi@gmail.com \
--cc=quic_jseerapu@quicinc.com \
--cc=quic_mdalam@quicinc.com \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=samuel.holland@sifive.com \
--cc=sbranden@broadcom.com \
--cc=schung@nuvoton.com \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=wens@csie.org \
--cc=ychuang3@nuvoton.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.