Re: [PATCH] tests/xe_pmu: Adjust assertion to account for potential RPe adjustments by GuC

["Koppuravuri, Ravi Kishore" <ravi.kishore.koppuravuri@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

Hi,

On 06-05-2025 20:36, sk.anirban@intel.com wrote:
> From: Sk Anirban<sk.anirban@intel.com>
>
> In scenarios where the GuC adjusts the RPe, the minimum frequency may align
> with the adjusted RPe frequency. The assertion has been updated to account
> for this scenario.
>
> Signed-off-by: Sk Anirban<sk.anirban@intel.com>
> ---
>   tests/intel/xe_pmu.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
> index 094dc0c6c..2e29a4056 100644
> --- a/tests/intel/xe_pmu.c
> +++ b/tests/intel/xe_pmu.c
> @@ -390,6 +390,7 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
>   	uint32_t gt = eci->gt_id;
>   	uint32_t orig_min = xe_gt_get_freq(fd, eci->gt_id, "min");
>   	uint32_t orig_max = xe_gt_get_freq(fd, eci->gt_id, "max");
> +	uint32_t orig_rpe;
>   	uint32_t vm;
>   	int pmu_fd[2];
>   
> @@ -438,7 +439,9 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
>   	 * Restore min/max.
>   	 */
>   	igt_assert(xe_gt_set_freq(fd, gt, "min", orig_min) > 0);
> -	igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_min);
> +	orig_rpe = xe_gt_get_freq(fd, gt, "rpe");
> +	igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_min ||
> +		   xe_gt_get_freq(fd, gt, "min") == orig_rpe);
>   
>   	igt_info("Minimum frequency: requested %.1f, actual %.1f\n",
>   		 min[0], min[1]);

Looks good to me.

Reviewed-by: Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>

[-- Attachment #2: Type: text/html, Size: 2813 bytes --]