From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe Mathieu-Daudé Date: Thu, 3 Nov 2022 08:25:37 +0100 Subject: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56931C43219 for ; Thu, 3 Nov 2022 16:58:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F2A024B64A; Thu, 3 Nov 2022 12:58:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linaro.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JQ9VxQIBJrvH; Thu, 3 Nov 2022 12:58:52 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C04294B731; Thu, 3 Nov 2022 12:58:46 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 43B7E4B63E for ; Thu, 3 Nov 2022 03:25:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XudF4D4vxHqt for ; Thu, 3 Nov 2022 03:25:43 -0400 (EDT) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 15C594B633 for ; Thu, 3 Nov 2022 03:25:42 -0400 (EDT) Received: by mail-wr1-f45.google.com with SMTP id g12so1290491wrs.10 for ; Thu, 03 Nov 2022 00:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=KBb4CRffvbqT8vCYmIjrzMCnn1vGDH3hTE8kztkuirWCWDx5vmnnhlY12+76G8HB+D zNMscqf1aWjU1jn9Q/+2qznV1nyjnfJgJejU0eBLDst+wEJ5JP32F9KCikAYwccYRz/4 CEoS+rbiQf+EK76mQ+O07yD4/kZHVOkQQ4sHVGI67dP7iLfCkYZsRk0ZykZuinHxGqnw VBepbg5NHi4yk+ONf1CC+WSt8MwwyKu83Az0OvU8HlQtsrRUhgNXczuxh+p9v62b1ye5 0/LNF3gKJJGGBQ4GVZwf3fHBWg9tW8pDxWcOYgxGkG6PYQEim2NR9gsO5CmPy3fAtv6n sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=u/1k5uTi5j7fNZABWNkt0tMWFpeQovPNgwiTaj+XJMsVuWiR1CQkM0tt3PN1nRcD31 E0F2Du5XwY3OEH7hbF1bZLuxMjgPFOeL9vLjIQt4DNJUu2Jo+TsjGObrDl5V99vOhBTb Xk6FsFL8m43I1r+2Vk+PEFtu69NCY11P6IM21KqtdZRB5qG6RwFTcIyhOmQeYDKWAeQ1 iG496QFMq8Sx1wC7bsLq3xuXPwSkRAcjkF9hZL62Dibb6j6K4zKnKbymUvVYzDUNXZCg vHoZXQSrg7sUPk3DsG/sU7p7xEgPrJc7Ee300qmwKYP1yd1o/QZBZt0MArm63oqK+TFB 7L2A== X-Gm-Message-State: ACrzQf2TARxwvsAfjHoOMFETDhQ7mcSEQmKy/O71/5rF8Jgl7ZF3yKFd IrRiWR+I6rX2f70zd+U7zdbo7A== X-Google-Smtp-Source: AMsMyM74HX/NoI0zgj7ni+fuzXHxAnM/kiJpMAz2sP8bktGhOQR4suw74I3bBM5aFs9fFpQjlVL3zA== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr17956880wrt.656.1667460341889; Thu, 03 Nov 2022 00:25:41 -0700 (PDT) Received: from [192.168.11.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id i10-20020a1c540a000000b003a3442f1229sm4408723wmb.29.2022.11.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 00:25:40 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:25:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> X-Mailman-Approved-At: Thu, 03 Nov 2022 12:58:44 -0400 Cc: kvm@vger.kernel.org, David Hildenbrand , Atish Patra , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Michael Ellerman , Chao Gao , Yuan Yao , kvmarm@lists.linux.dev, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Isaku Yamahata , Fabiano Rosas , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > } _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF970A31 for ; Thu, 3 Nov 2022 07:25:43 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id l14so1345076wrw.2 for ; Thu, 03 Nov 2022 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=KBb4CRffvbqT8vCYmIjrzMCnn1vGDH3hTE8kztkuirWCWDx5vmnnhlY12+76G8HB+D zNMscqf1aWjU1jn9Q/+2qznV1nyjnfJgJejU0eBLDst+wEJ5JP32F9KCikAYwccYRz/4 CEoS+rbiQf+EK76mQ+O07yD4/kZHVOkQQ4sHVGI67dP7iLfCkYZsRk0ZykZuinHxGqnw VBepbg5NHi4yk+ONf1CC+WSt8MwwyKu83Az0OvU8HlQtsrRUhgNXczuxh+p9v62b1ye5 0/LNF3gKJJGGBQ4GVZwf3fHBWg9tW8pDxWcOYgxGkG6PYQEim2NR9gsO5CmPy3fAtv6n sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=t4R39bSDJj5aBTDxNAJ4IlOofK47hZWbO2nlvYc5vRRryW2ODK07yAeSCjXsqPJMNF 7BM34/BP9ynsYc6aK848xgGOaQtLtDU4AO7s2QQvGHV1qin1Hnk6wwmFcDNuP77Ee4Mp FDcS2CLBnglAJLcGnbaJcUWZ78BuM9MQy+4wXL1yj1cIjRsbElvoVW8vDkv9qHleMRWa B3oUCTkNwQ3dGfxCFsZcmf1Sr/hyN8gPSyH/vEnYSxvP4zw0GK2j76HOvRifzn7PTNJk z3fIW04VMiwmoQaW3fAFHX84/snWROpt8upp43ObKFkQ3bslutaC/EthiMxspzPPNQa4 J03A== X-Gm-Message-State: ACrzQf0EL3WRlJ2ZS+8ieLtf+Czcg7C/oQYrIwPJIPJcy88vd32rUaAs 1HH+JZxJDvPvg350iBXHFF2z2QB0M/hWkw== X-Google-Smtp-Source: AMsMyM74HX/NoI0zgj7ni+fuzXHxAnM/kiJpMAz2sP8bktGhOQR4suw74I3bBM5aFs9fFpQjlVL3zA== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr17956880wrt.656.1667460341889; Thu, 03 Nov 2022 00:25:41 -0700 (PDT) Received: from [192.168.11.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id i10-20020a1c540a000000b003a3442f1229sm4408723wmb.29.2022.11.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 00:25:40 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:25:37 +0100 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Isaku Yamahata , Fabiano Rosas , Michael Ellerman , Chao Gao , Thomas Gleixner , Yuan Yao References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID: <20221103072537.jDAZcULp4tAdEuOFWBn01U9Z7P4km7DRxHmCTQSGMNU@z> Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C440C4332F for ; Thu, 3 Nov 2022 07:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KJ8ynbYn4Hj4bddPFgj5WzRkts76pi/25WVg7DCKV4w=; b=M003P/FFlLQ7Xe LEqBx0jwB/hNLAWvSQT3OJ5+EcWjjhJhDIp4HsSNPjcBEerFpNa3fXIteieUMezIC5z7UTtisZ9FT EEWpnH2YYvFwh+UGduXpzDhysoZUWxt5h0nmhB9wtFXUkYESP2hzzsm5rJxAnWJ4I390dM0YS7Mhn vYJO3H6xjPhr7hvlDqhraXBYdYKAYKCYUWUzb9SCCKEWGLXIPYNw7pQFa4G+f7Zlrv6VQzxpV2vHW mWclpDlS8p+zTOhTfNsxFzD3NpSPu8VwbpsLCYy6KQoDh/6DIxZ38QC46vntVM3OiTbkfoqYhCXX+ gXghE97Xl+VZVgBp+hAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqUbh-00GSJT-Kq; Thu, 03 Nov 2022 07:25:45 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqUbf-00GSIE-MV for linux-riscv@lists.infradead.org; Thu, 03 Nov 2022 07:25:45 +0000 Received: by mail-wr1-x429.google.com with SMTP id y16so1282428wrt.12 for ; Thu, 03 Nov 2022 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=KBb4CRffvbqT8vCYmIjrzMCnn1vGDH3hTE8kztkuirWCWDx5vmnnhlY12+76G8HB+D zNMscqf1aWjU1jn9Q/+2qznV1nyjnfJgJejU0eBLDst+wEJ5JP32F9KCikAYwccYRz/4 CEoS+rbiQf+EK76mQ+O07yD4/kZHVOkQQ4sHVGI67dP7iLfCkYZsRk0ZykZuinHxGqnw VBepbg5NHi4yk+ONf1CC+WSt8MwwyKu83Az0OvU8HlQtsrRUhgNXczuxh+p9v62b1ye5 0/LNF3gKJJGGBQ4GVZwf3fHBWg9tW8pDxWcOYgxGkG6PYQEim2NR9gsO5CmPy3fAtv6n sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=s26b/tWVRYn1Ex6EOcpmfYKrIebHOO5+SZ9BumTQ3R4BJ5xFvtOm6qA4kOZ0yYd8sj pwkf+gnz8VbnE94X3jd0EKZcgSUPQt2YonoXItdf7iXNeCIyapX9W3/KxtejHPaKDiqJ xDFmA3M1wgxGhGF9zLSZcdRkBX3WsMHX0EvVoWKxAx4kFVWFjejarTQsc32u57zn46f3 J4LjO3xYX/cTaaJlzBrvemRFAZFciKKvSHsgw2nCEmR0Tog0PaZqd2vO+Sc3oPh+mIAo gb4FQyRNLhV2FDopkXssoXdydMxSgdx7RjNB8X/icIRyxLgO2vMDVCERbI3UV47rrGpu cgHQ== X-Gm-Message-State: ACrzQf1KUgwlAiGNVB3x8aHXGq/SbSM0bvD5kfFpoX3dFqIJl8PTqxD+ weTpvIKCujWXL2agGgJPtxoTWw== X-Google-Smtp-Source: AMsMyM74HX/NoI0zgj7ni+fuzXHxAnM/kiJpMAz2sP8bktGhOQR4suw74I3bBM5aFs9fFpQjlVL3zA== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr17956880wrt.656.1667460341889; Thu, 03 Nov 2022 00:25:41 -0700 (PDT) Received: from [192.168.11.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id i10-20020a1c540a000000b003a3442f1229sm4408723wmb.29.2022.11.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 00:25:40 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:25:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Isaku Yamahata , Fabiano Rosas , Michael Ellerman , Chao Gao , Thomas Gleixner , Yuan Yao References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_002543_780491_F5631936 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > } _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29D09C4332F for ; Thu, 3 Nov 2022 07:26:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4N2wL75lQjz3c16 for ; Thu, 3 Nov 2022 18:26:39 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KBb4CRff; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::42e; helo=mail-wr1-x42e.google.com; envelope-from=philmd@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KBb4CRff; dkim-atps=neutral Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4N2wK83nnFz2yMj for ; Thu, 3 Nov 2022 18:25:45 +1100 (AEDT) Received: by mail-wr1-x42e.google.com with SMTP id z14so1311861wrn.7 for ; Thu, 03 Nov 2022 00:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=KBb4CRffvbqT8vCYmIjrzMCnn1vGDH3hTE8kztkuirWCWDx5vmnnhlY12+76G8HB+D zNMscqf1aWjU1jn9Q/+2qznV1nyjnfJgJejU0eBLDst+wEJ5JP32F9KCikAYwccYRz/4 CEoS+rbiQf+EK76mQ+O07yD4/kZHVOkQQ4sHVGI67dP7iLfCkYZsRk0ZykZuinHxGqnw VBepbg5NHi4yk+ONf1CC+WSt8MwwyKu83Az0OvU8HlQtsrRUhgNXczuxh+p9v62b1ye5 0/LNF3gKJJGGBQ4GVZwf3fHBWg9tW8pDxWcOYgxGkG6PYQEim2NR9gsO5CmPy3fAtv6n sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=y7ZfAFNrB/PYCfK1PrGgYArS6JerkOq4EYggZYtWGIQMSt6ufVBEwGmjRQoVqBh1PG WlmNfmAKJTqHk5DGHp7fDfm6lmC3QaGJt2B1n1isOHQxj18pK9rPrDI6s39VEZzGJBwP L62i0mQDOqJeEx+uwVrDogBURdCK1TFrc5J+91EYHwNczcW82/errALv1maBdRFDBaSF Y8bXp3xREiu/ZXxHUw3PPzP6o+npWkiGZR1D561NbE+YofrChIbLuytS0I6fb8gqqISw 5vJnhvD/Gm45wZM6MJx4bP8O/vJMRwLx4NcU44wooeMScZmNqnkElOhlcPVYm6Lk0+gz ZcXA== X-Gm-Message-State: ACrzQf0WBI6JVUBMKoU6dmlGVpBs8tC1jRK/Yt5Z5sQRUnfc9uCU4OjO 4ll4VieUSjJN90bLN7V9iuK8lA== X-Google-Smtp-Source: AMsMyM74HX/NoI0zgj7ni+fuzXHxAnM/kiJpMAz2sP8bktGhOQR4suw74I3bBM5aFs9fFpQjlVL3zA== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr17956880wrt.656.1667460341889; Thu, 03 Nov 2022 00:25:41 -0700 (PDT) Received: from [192.168.11.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id i10-20020a1c540a000000b003a3442f1229sm4408723wmb.29.2022.11.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 00:25:40 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:25:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , Atish Patra , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Chao Gao , Suzuki K Poulose , Yuan Yao , kvmarm@lists.linux.dev, Thomas Gleixner , Alexandru Elisei , linux-arm-kernel@lists.infradead.org, Isaku Yamahata , Fabiano Rosas , linux-mips@vger.kernel.org, Oliver Upton , James Morse , kvm-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93A66C433FE for ; Thu, 3 Nov 2022 07:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=958zdGosbtrjtwgNTIMga3lREbbsoHkwzsKVXrp38dw=; b=27881d/oZ7vUxr 39zkuK582fdYo7dcZIRS5d483qqBRyaumjvJtYHAUtYbIPazYxRLcTF5HFxqw6fri8jff8ghv2He5 KxiQOtp2fWJ8algyaXh2lDQ0eTxjvQzZT27eKJV/Ca+dgWG1RTTnxTwQf8Ej4s0TTF4Hzz76eFynl 1o81VQgBJGBbKLp2HQzXHYOuGREElWZjlCtGLSdOdD+aRDVI3yMQusd+fY+j4kQEd7Fvs8bdp0fas KkBqin2YiwmPcWA4eLt+HzYB8AQTNlKckgYUYUq9YKvG68rRuc6+lz1Nuf0fyLW8cD3mmBm8c0VMW CDFEN7UdH1Nzz9B2fWrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqUbj-00GSK9-Rz; Thu, 03 Nov 2022 07:25:48 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqUbf-00GSID-MV for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 07:25:44 +0000 Received: by mail-wr1-x435.google.com with SMTP id cl5so1294988wrb.9 for ; Thu, 03 Nov 2022 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=KBb4CRffvbqT8vCYmIjrzMCnn1vGDH3hTE8kztkuirWCWDx5vmnnhlY12+76G8HB+D zNMscqf1aWjU1jn9Q/+2qznV1nyjnfJgJejU0eBLDst+wEJ5JP32F9KCikAYwccYRz/4 CEoS+rbiQf+EK76mQ+O07yD4/kZHVOkQQ4sHVGI67dP7iLfCkYZsRk0ZykZuinHxGqnw VBepbg5NHi4yk+ONf1CC+WSt8MwwyKu83Az0OvU8HlQtsrRUhgNXczuxh+p9v62b1ye5 0/LNF3gKJJGGBQ4GVZwf3fHBWg9tW8pDxWcOYgxGkG6PYQEim2NR9gsO5CmPy3fAtv6n sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=VAdKQpYlY5ffAL+tL3HEp4QLd7KszqQNMdVzOThdIndMEvwqcoByX1VRznXiWAARhV iEf4taDLpqWuz6g/jtUH6dcV/rgFd/ICUBZlebjdgLRU7cgRdAWzL88LomNEEi7D96+8 4JZgaN3EWkI4x0IU/oqGeWbaE3tdDkAHeEfkQY9TNrH7vd6BJfK9LkoYbB2IrpsaQhe2 XEVFEglOheyMPH9Rj6FbMDaf4QjXrq75Mxev1JMegzPUgIvTVM0jrt6jffi2pro396xK A08nd1AArnJruEnQyAM/eAq+wZZyrVzSNyFXW7A6fYVy757rG+CcLf016bqhQJ/OY3CS Cycw== X-Gm-Message-State: ACrzQf1MiFL6gp3ygtaLvnZyosK1aXge+FbTGwyfVFqN14wsdrNrerpk Iy+r06eDtQ/lYV7m0JWk5MGI9A== X-Google-Smtp-Source: AMsMyM74HX/NoI0zgj7ni+fuzXHxAnM/kiJpMAz2sP8bktGhOQR4suw74I3bBM5aFs9fFpQjlVL3zA== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr17956880wrt.656.1667460341889; Thu, 03 Nov 2022 00:25:41 -0700 (PDT) Received: from [192.168.11.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id i10-20020a1c540a000000b003a3442f1229sm4408723wmb.29.2022.11.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 00:25:40 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:25:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Isaku Yamahata , Fabiano Rosas , Michael Ellerman , Chao Gao , Thomas Gleixner , Yuan Yao References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_002543_780866_4B6F0DF1 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel