From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D60ACEB64DC for ; Tue, 11 Jul 2023 06:28:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AEAE88677B; Tue, 11 Jul 2023 08:28:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="iyNyHHX0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B62E5867EE; Tue, 11 Jul 2023 08:28:40 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20607.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8d::607]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2F6A286778 for ; Tue, 11 Jul 2023 08:28:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YEu+i25BNincs0N8jAwG/FzI5SQS/OC3o3GTt0tebAMVxAZhOHeevRo2mbi9z4sxdO3FMHM+e9Wi3yppFHqFa5HJ5szW+B/6XVkmGSLjzQ48f5hKkHvjYGLspvXjrTE2ve3XzHq+INIy8HrEM3BqQILza01O5xShBmVN/BqrZmE/zULLQtOqyhf2joAkIlP1UF+4r/4VC3Anacl+BEHweBrhfwawZ400RU+vXxYCIpGTF4/2pBppIlDXjsuIyrZTJrkfZ+m9ESqiKncKgqPKMi5Thynt/pO65s5NkRfaPa1Nr3supI4EbNMnGXv1+/xy5r8EUxinZT0/r8k50cktrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M0yvcSnXL6KxwP92nmVhQOr5sCtyxFqqL5tW6RbjFDw=; b=OQrOulGh0HhWoqJehv5rZ8ESLonSCD+/xwPDSHyo8kCz/udPYKnnkvPGGD3G82Y4fw3oAKG/LJow1/iiDpT1+byEKRssj2y/GOLos1DLgxoa6rfKg3aKxDQGUSapIcmYm/kphbxobl8GIQwJTmTwJ1SaQK8N72un7MnNLInp1OCm51GRUqkZTpjwjr3L88ZkDRq1C9aUEQHwvSRJFnYmGvDHq2XEM+FseMv2HqCe21o3zffhSRi99OU1lamA31G+5a4j8QJ1NljYer276GBcMSw2DznqxN6K7JX7MkwFwfijFxX0A5HVF7CxuIdXhU1wD6OQmhtVFt7O1GHn/anSnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0yvcSnXL6KxwP92nmVhQOr5sCtyxFqqL5tW6RbjFDw=; b=iyNyHHX0TCL5x97MyyxS/Xv/vYpeWqfufZ87i9sTG8KU7xv2Lfb+g8WfxMGdyf6rI5N/K+JslT8SHmrqPg5zOpfvTRfCcgW19bCcmU9wx6KkGtK4pWen7YtVQ29qo2dAAYg5zIY/S8CtPkFqqgVqBD/Wo2YXdKkZpTuyWxkI89g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by PH7PR12MB6000.namprd12.prod.outlook.com (2603:10b6:510:1dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Tue, 11 Jul 2023 06:28:34 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::bb94:8eb4:943:d955]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::bb94:8eb4:943:d955%7]) with mapi id 15.20.6565.028; Tue, 11 Jul 2023 06:28:34 +0000 Message-ID: Date: Tue, 11 Jul 2023 08:28:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Jaehoon Chung , u-boot@lists.denx.de, git@xilinx.com Cc: 'Ashok Reddy Soma' , 'Peng Fan' References: <000001d9b3b4$9064a360$b12dea20$@samsung.com> From: Michal Simek Subject: Re: [PATCH] mmc: zynq_sdhci: Dll reset only for ZynqMP platform In-Reply-To: <000001d9b3b4$9064a360$b12dea20$@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::21) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|PH7PR12MB6000:EE_ X-MS-Office365-Filtering-Correlation-Id: a6ebde66-6e14-4636-2ee5-08db81d80d39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yqQ/toOYfGtGmcUaxgyE289Rg3ptELNcRFAdR0rgIMc5l0vehfQw6kzTauunbOR30bVCOK3UEhQ2zmy7QqOX93T353GmwsSebct7GP9ke+nWF6dV18cxMC5zO9JMckdm9jIb9iTqqRVydnJMAO5t3CZMCUa16U9LxcsxRVPuwfjAGaoY9Al396rBcHZR0IxDVGxyFebs2MXs0rHUVyu3Mfng6Us5NbovHR5F1rQuhWMCNAsrSurf1FQ6wjoRuyP2Ogk/KCZ0u3X0sbwdXU0hWcXfSTVtrPRdl6YdQSTDFAcgGXild/9Ys34wekt6n8bYybHJHA/Z0AXnRulZwD/KCeqa4Sxc7HYS98o2db63kGzqpvoEx6NE7Hdf5akndU3zTOORev9ClV10WW8Ja4NKxOL13Tdha4/nTlfnN6I8bJKD0vwZmp8EqAgCaaBWGQV5mTxMMD77vIzoXIyKZnmMEZa3p+Vkoefet40QR5Y2XJXEGbfUlCd4celn+/NYYkz2omJRCsMCTsr/w0S+a4zBXX9vt2iSMDG9wL7SFdknVgihBWTXdyqCmJzgXnoUF9fovU89azdyQipXWRfXzG+5EE/PTd59JCinehVAGWPkqSt5ChXpkbdxJG6cFMs9x6xrb1U7+iS1JvlrqoOXVaLnFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199021)(86362001)(31696002)(38100700002)(31686004)(36756003)(6666004)(6486002)(54906003)(6506007)(26005)(186003)(6512007)(53546011)(2616005)(5660300002)(66556008)(316002)(2906002)(66946007)(44832011)(8936002)(8676002)(66476007)(83380400001)(4326008)(478600001)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDJ1UnFlNzNpVkV1elZuU3YrbHBrNUtRdG9mcGpEQkE0K1BRcWhtTVVoRkVx?= =?utf-8?B?N2pmOWlnYzBBakw0YklTc2h2Z0RmT0xoeHJsQ09OYnZuY2llY3JkdnJXWXR3?= =?utf-8?B?N1UyeXlhM1g0VWxlSVpUbkcyWkxOR0FrMUliTitHUXNLVldPZTgxNVNxRFJF?= =?utf-8?B?NEZFaS9sTlorRkFleWNwOWtEcWNyYktmYm0zVnQycHFGdzV1a1p3cy9HUUxa?= =?utf-8?B?a0dYTEdEWjIvUFJDdHdFdFpSWXY2S3hna0xiVjh1ZzQzTzhPb3dicEs5R2d5?= =?utf-8?B?Uml4c1Q0MjNOTVoySk4zbWFQOCttYkZsbGRrWE82ellyNkNDV1NIdFdqUDgz?= =?utf-8?B?cXhDS3hTYUlGVHhGSFc4RUthWHhLOHJVSlA1R2t1a091ditYTWVEYXJUUlJW?= =?utf-8?B?S0psZ3lBUTJTUXEvanNHQXo0M3BmQ0xuQXRISDhscGFnUGUzM253KzNKYkN1?= =?utf-8?B?YXZuWVRwekVFRXJvMjhXcitaM0UzWXJjeHRzUTJGVStBYnVtd2FWejF4OWhJ?= =?utf-8?B?dU5vU2lqUWNCdS81RGFVSVc1a0trbVhqY0NzOEtaYjhaNGZETFJpNUdkaEM3?= =?utf-8?B?TlBncS8wUk5YbTFTTk5qcXpVazRqaWhpNm5KMjAzSjk4Ym9hdVd1RnV0MFdq?= =?utf-8?B?MVVPOXRJMHR0Ymg3SEdGYXpMbGc3dWdpSFZhMU5GS3RRdGxtaFdxSnk0aFF5?= =?utf-8?B?RmhtcUwrMjRHWUYrMkZVNUdyUmR6R1VtNlhDUThkeXZ5dURKZjBvZ2FTNUZu?= =?utf-8?B?WWdsUUMreFVZblorVllJWTlzakpYUVhUVE5KVU9kbzk4Q2VnUlBocVNyUXQz?= =?utf-8?B?anN6Q0lKY0U4bmlBY1pwV3JnWWcyeFRmaHkraElMNG1kbTZxWXk3TnVnRXJ4?= =?utf-8?B?TG9qZnZtbkIybjNHR1JLdXQzQmYyUGFWdDBRRCtNYmVWdncvdmZLcmU2WU5Y?= =?utf-8?B?M1NhaUlybUNRZTROSGxxQjZkUzd3aURxVFZRUjhMMTBEQ0s4RWN1MzNLSUNG?= =?utf-8?B?Tit5NUVwUERoWk83REZtR0RlRzhDSkdiWlgwTEU3K0h5c1V6THF0YUpmZnF2?= =?utf-8?B?NytubXdxT3k0T2ovWW4rbWFpa0YwbkxWeGQydE5VUlNpS3c0WTRrRjY3YktW?= =?utf-8?B?SzhUQWluL0lRd21iVzIzN3BXYjR0bWF1TmNPUG4wdDRMMUxnOWhPUzU2TEM1?= =?utf-8?B?RnRsSnEyTGxQcmgwcEdaL3VMTHJpZWdHM1htY2JITENVb2dEQlhjYm9tT1dX?= =?utf-8?B?d0RCcFpKTjhwUjZGbExUZU1OTXBWOWdaRkxGbGNVb3JPckVuRCt3aVZqYzFX?= =?utf-8?B?UXVtd2NlV3lYVUhLbmxKQ1BWeDY5SHdJOTczVU15cDd2MWMxNnk4NEVnRGxV?= =?utf-8?B?aWhRdkhKMEpQTTlkOGluNDFCZ1NWZEpEVUdpZEk0ajdIWERzTkYvRmZ4VUVw?= =?utf-8?B?a2hzeFhOS1dVRVpia3Z4dDA0WkdKMzhaOGFRVUQxcXRwdDVCbzJ2Q1VVR1Bi?= =?utf-8?B?TXc3WnJDYXBCZ0cxNFN6MXNtWmlWL29ETllwYytBaDliQWl6bkZ3dkRhdVhX?= =?utf-8?B?cS9ZUUJ2aDVQdnRmVU1qbW5qZ29kQ2pYWTJ3T0NZMzFDdnppMHh1VnEvS1M2?= =?utf-8?B?Y01WUytrK1dPUU5wazlLM2FBWW1jc2ZVc29XY1ZIVjdoVnpnblNNczh1SCsr?= =?utf-8?B?OVMybkY2SG50T1F6YzQza3R0TEE2S3E3U0dhN3ZtN0REODBtSTB0MElBU285?= =?utf-8?B?NGNGRjM2MGxjUTJPaTNYMUtORFFQTUR4N0RKZ0xsTzlKWktOM0NKWFRKcDJK?= =?utf-8?B?SFVabmoxN0NTK1FxOU0zTTJQVSt3SjROMGtLL3NBTGNIUXcySVU1bHNaaFBW?= =?utf-8?B?ZFRuVVdzZ2RGdDdmSUJpMUsxbXpnTnpydXg0Z1BFbjRGcllYeXRLSEtiYWI3?= =?utf-8?B?WmMzTkRpYUJlcHVDdEJyUXpnMVVrc1Urd2VGeithSGVFQ0VKWWF0bDJuSEto?= =?utf-8?B?aDFJbitrWjl6ai8zOTkzdnhXcWlQNWcyTHNWM2RPS01jKzh3S0p5QjA1ZkxY?= =?utf-8?B?YnJJUG1pZVhsK2hWVkIzQXNEK3QxRDhNOEIvejRwbE5iT3UvZVl3L1ZjUUtt?= =?utf-8?Q?zHGf82pkI6IppUt4S2E5B1hCr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6ebde66-6e14-4636-2ee5-08db81d80d39 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 06:28:34.0163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3KplWe4Y1FPpKQCxqa4BUbLiVjTX3f34wz6yw7blyBsub9jOZuCAOlPregO+HlpF X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6000 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On 7/11/23 07:00, Jaehoon Chung wrote: > Hi, > >> -----Original Message----- >> From: Michal Simek >> Sent: Monday, July 10, 2023 9:12 PM >> To: u-boot@lists.denx.de; git@xilinx.com >> Cc: Ashok Reddy Soma ; Jaehoon Chung ; Peng Fan >> >> Subject: [PATCH] mmc: zynq_sdhci: Dll reset only for ZynqMP platform >> >> From: Ashok Reddy Soma >> >> Dll reset is needed only for ZynqMP platforms, add condition in tuning >> to call arasan_zynqmp_dll_reset() just for ZynqMP platforms. >> >> On other platforms like Versal NET, If this condition is not added, we >> see PLM error messages when dll reset smc is called. >> >> Signed-off-by: Ashok Reddy Soma >> Signed-off-by: Michal Simek >> --- >> >> drivers/mmc/zynq_sdhci.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c >> index e779251ce34f..935540d17194 100644 >> --- a/drivers/mmc/zynq_sdhci.c >> +++ b/drivers/mmc/zynq_sdhci.c >> @@ -422,7 +422,8 @@ static int arasan_sdhci_execute_tuning(struct mmc *mmc, u8 opcode) >> >> mdelay(1); >> >> - arasan_zynqmp_dll_reset(host, priv->node_id); >> + if (device_is_compatible(mmc->dev, "xlnx,zynqmp-8.9a")) >> + arasan_zynqmp_dll_reset(host, priv->node_id); > > How about using local variable to check whether it needs to reset or not? > It's not efficient to call device_is_compatible() everytime. > (I'm not sure that it will be added more in future.) > > e.g) > bool reset = device_is_compatible(mmc->dev, "xlx,zynmp-8.8a"); > > if (reset) > arasan_zynqmp_dll_reset(host, priv->node_id); > > .. > > If (reset) > arasan_zynqmp_dll_reset(host, priv->node_id); This is very valid request and TBH I have already added this to our TODO list to convert all device_is_compatible() to flags because over time the driver was extended and this construct is used more than it should be. This is going to be the last device_is_compatible() patch. Is it fine for you? Thanks, Michal