From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EF6330317 for ; Tue, 8 Sep 2026 02:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788834488; cv=none; b=GRc92p0Ib0vx0vtUnhhLIt4IFVTspxAWRGytwIFt8Ai69BT1KHNdz/AZw6GKY3dnfotHs6QYC/GK7iRTdbl0Xh0169LilsgPEyiNedk+/oyXddl78rxNAGPOsWP6NDLHFxTTqmrZUYV4/dyPY/h1e+FtXdFhdJqnfxqiUJmnj10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788834488; c=relaxed/simple; bh=xYnBMto8rvMbCeRYM848J6cSC7ZIBWCqaDb3Q9LcAuA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QR4hJTo4a5YP40PC0dIE8asvV8+B1Pxruv3Aw7DWtPcGex8I4VQD39ZGd5pNwr6Dpc1k3yCqJXmPtrdPPsyDPzoKxq1IzN2JT+hyFwifBrZYM5zWbQygg5pGux9CWiuAc65EvmQD4ARZ8yo/Pf0lKZFHfHvlW/zjxqXiCVKyi40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JvA5m2Vd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fD0jMoIE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JvA5m2Vd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fD0jMoIE" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687NmNRU1868451 for ; Tue, 8 Sep 2026 02:28:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jmXnlHUi4LLtLAOdsHmNQhDdyaOor2/XKd/6FC92eGQ=; b=JvA5m2Vdfcw3HEyg xV4P03lYk4P/HMW4zF3AQVlcJZ+BSwSPjQCrfboz/I+7ctavqu2N0QbWrVm6hpLL wWHIf9UJ773PQNWxsZQetdYiFPCSGerTSWaKsBu1ES+ZaVsDe7Iz5aXb0bsOx5RE zOmntix5xGmWHqmkT/Wt5zkCV0wGL/KosWrgRdSXRi9Ar002Ph1rlClRdpCuoRRh y5/6cRaTDE8FVbkKwE/6fuuNqzOTpwjnTZyeJn3nQTXgsEdBqDiUL5zeSbNUwVSG 9hO0fv5pVOK6GEpyx8RRIexcdTBLCOXDOT8hagMXZ4GVhz2vaxFBl7/8tc8oFnSY vW+K6Q== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghtdqk1jy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 02:28:05 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-398fe469aa0so6521875a91.2 for ; Mon, 07 Sep 2026 19:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788834485; x=1789439285; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jmXnlHUi4LLtLAOdsHmNQhDdyaOor2/XKd/6FC92eGQ=; b=fD0jMoIEQUffreailUhHHiB8mWmzKRLtm1Lc5zPFa7mX3bUi+VONzk47WORCMDMNK5 Ci2sw7MA6G4FwvS/4QQpjqPwYLXKNtAODz8oOGpM0AzeBROUps0eqAq4rGzK96Ubro4r 1BfzyQS3jNcLBpcezQSczqKbh4GetjUB0yU3igTQnUApcz2MoJLgpSxuaDv1aTH9Zubb c9+43NFf6NOkNmtuN1OIOWdczljvnCXoA7ZaOYX3r4zYzh+VXMSpjW3qt+g9rixZAtOc +x4McXfbtUbqDa2y/4p9pADlDRV5GzmKwmWoBb/Khjp5XwmdMFuBd0ZatdtpHCn7dwD/ 9+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788834485; x=1789439285; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jmXnlHUi4LLtLAOdsHmNQhDdyaOor2/XKd/6FC92eGQ=; b=WyitQ32RI6QHHHzBTY+wOfb2DYJcQStKjFy4Zzr8EkFZPunTOdxci5k+veQNpwzkCX 8r7xDPoz6bNt4B+KoFKwHW6qokxcGl+DTJQAIfEo647R46V5qET/JC/k7ZeVmtslvhBd b6e1Ut59LFIMXMzJFBLz9FE6m54fw7rBoE9lFmlzPVJyQnpVOitWCEscknQFegi3f2IP Y3pBCAMiCu5adSFcctDBnA6pE5fMM6g05a9a0SnmMDsfvsbfODMhvJp7CA0h+G94ykDg 40ivYnyJyt9cztCRapAtOzDvj5eIwEj8wk5Pb9gr9rWIb1VB7ExiIhi8oEutuz5LMsgR WGZA== X-Forwarded-Encrypted: i=1; AKwUvBz0NAnBFULjZG6wgmu9l6Cdu9JpP2Qyeh8o6CSNZiTZML7UUeJTKrI03qlBYXxQ+38dJpUXpb+q1fB7@vger.kernel.org X-Gm-Message-State: AFuF++lLFE0/pR9PCEFNlZB0xGLGdx7+TrnFeZJlw7s/Tl6+toUe1CWY Fy5mEfkttw19uf4aDG8HixIPA7rPP7J4Ys3eTLSryEg3dDuD7j4Bq+djRU5oQQPciDrVAj0acnW ODro/RdUmyYtrvn+389Vtle55KZA8Ksae5B4jC4a9Pcwkv1aiSpm5wHG5EdsFM9Qb X-Gm-Gg: AYBFou0uuUUIgt2ic5Akp4o6b8QYeThp4I6bN4bmTZ57CyaAPa1jElsbDi9gk3lJKQM 2v7lha/AVOhucUBO1bbgf0D5lHKIh+YBbpzjKINgGW8HB97Z96O1chAulkvKZzQDsZEXX+S/kkG dCiuTxubsFiRP9eu2UjLyW4Oy4It7Itcs8YX0bztZVcoVSlvqr8evyi8mKBqtCDz174QXBg6JwV /vPi1yPBGJ8EnSzAHpNfgdYvJ7ZfSa0WgJ8gDHfgajK17ASPk6BBiYqtMVUzIOVO/4TLTm4ZPIx F0hcgZjsNUoB+nECHBplrhiAE3CeKbevZrxFZmHxGIQlIlupaGo8gLHKFIqylfwdlfg6qbFqXex vXH43bBTTJxRs0fxgDvEI0QpgnQ== X-Received: by 2002:a17:90b:4ad1:b0:396:635a:9b10 with SMTP id 98e67ed59e1d1-39b2616ef8amr37057488a91.11.1788834484659; Mon, 07 Sep 2026 19:28:04 -0700 (PDT) X-Received: by 2002:a17:90b:4ad1:b0:396:635a:9b10 with SMTP id 98e67ed59e1d1-39b2616ef8amr37057434a91.11.1788834484196; Mon, 07 Sep 2026 19:28:04 -0700 (PDT) Received: from [10.239.155.28] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08bcd243sm30538730a91.5.2026.09.07.19.28.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Sep 2026 19:28:03 -0700 (PDT) Message-ID: Date: Tue, 8 Sep 2026 10:27:59 +0800 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] leds: rgb: leds-qcom-lpg: Add PWM frequency mode support To: Lee Jones Cc: linux-arm-msm@vger.kernel.org, Pavel Machek , David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260827-lpg-pwm-fm-support-v3-1-88ae5208c57b@oss.qualcomm.com> <20260903153028.GU2133376@google.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: <20260903153028.GU2133376@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDAyMyBTYWx0ZWRfX/NkOd49ARGDX UNxBCvmZRH2TI9tpkB5bfxEFZ/1+CJjI0CMtE6LvfqUgIWMqVonwXxTd1Veo3xkXT9GBWZDQgSX Y2RBBs4iSC1RVO0RnzAsjqnlGBVUNovwofXtHWIxAjwQKmR+i50K63JF+rgFqkBn7DrwitnRmGs AsfzHMIecrlAGznm4Sk2Ti1G7PasgOxAecPgFRkdVY9u54B+DKp2LRMmShMhwvWbK2USHyz9GUz AINz1M2rPh6PWMoG9X/ux0mQx59Wc8Ie3YtY2rNTg/1CWPAYoMdzdbOabiVtNy1w7XuwHT49LrP qS1jTDrwvMl65SJfAIQ25cUAWraimLK9+/ZniGOKXrlm+JSoHI6eTudDkLFEuA+7Cgo5pmA9nXW d34DpcOMG/C/vbM5ayifLzrtBpZ0Q7Pf3tF/GmieHN3EPVLDnJd1UsG9Jmldz9IEbPYmDcTjwDv a5nPfKg6qs2L672rkgA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDAyMyBTYWx0ZWRfX5gWmNnToVJFH ixKZiMxZmVacH+Wp0DRcyMK5n1+k3pXiSuww/NBaqMLXwM1gmG6NOrcgMDk5sBmFZ+bVj0KP4EQ zx5YJop3ixsqnT9SCkYnch5lwDdIX2c= X-Proofpoint-ORIG-GUID: 7DfO2rDuDGbW0gk0LngbZnhvkFS4oxVH X-Authority-Analysis: v=2.4 cv=U6aiy+ru c=1 sm=1 tr=0 ts=6a9f72b5 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=nP8d1w5hKBWq8GbY02kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 7DfO2rDuDGbW0gk0LngbZnhvkFS4oxVH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_07,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080023 On 9/3/2026 11:30 PM, Lee Jones wrote: >> Certain PWM channels on a PMIC (e.g. PM8350C PWM4) support a Frequency >> Mode (FM) that can generate waveforms with more frequency points than >> the standard LPG PWM mode. The trade-off is that the duty cycle can >> only be fixed at 50%. Add the FM support. When the PWM channel is >> requested to set a duty cycle to exactly 50%, use FM mode by default >> as it provides a finer-grained frequency resolution in that case. >> >> Also, guard mutex lock at the top of lpg_pwm_get_state(), to make the >> register read atomic against the register write in lpg_pwm_apply(). > Would it be better to split this submission into two separate patches? One to > address the locking in 'lpg_pwm_get_state()' and another to introduce the new > Frequency Mode support. > Sure, thanks. I’ll split them out and submit them as a series. Do you think if I need to combine below change in the same series, even though they are not functionally dependent? https://lore.kernel.org/linux-leds/20260716-lpg-rgb-color-balance-fix-v6-1-b49d51528f61@oss.qualcomm.com/