From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <keith.busch@intel.com>, wenxiong@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, bjking@linux.vnet.ibm.com, hch@lst.de
Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled
Date: Wed, 28 Jun 2017 11:51:30 -0600 [thread overview]
Message-ID: <dd97c68b-687e-df44-8dce-cd8e93e41d7c@kernel.dk> (raw)
In-Reply-To: <20170628171031.GC2650@localhost.localdomain>
On 06/28/2017 11:10 AM, Keith Busch wrote:
> On Wed, Jun 28, 2017 at 11:32:51AM -0500, wenxiong@linux.vnet.ibm.com wrote:
>> diff --git a/fs/block_dev.c b/fs/block_dev.c
>> index 519599d..e871444 100644
>> --- a/fs/block_dev.c
>> +++ b/fs/block_dev.c
>> @@ -264,6 +264,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
>>
>> if (unlikely(bio.bi_error))
>> return bio.bi_error;
>> +
>> + if (bio_integrity(&bio))
>> + bio_integrity_free(&bio);
>> +
>> return ret;
>> }
>
> We don't want to leak the integrity payload in case of bi_error either.
Yep, see my follow up email on this.
--
Jens Axboe
next prev parent reply other threads:[~2017-06-28 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 16:32 [PATCH] fs: System memory leak when running HTX with T10 DIF enabled wenxiong
2017-06-28 17:10 ` Keith Busch
2017-06-28 17:51 ` Jens Axboe [this message]
2017-06-28 18:31 ` Christoph Hellwig
2017-06-28 18:34 ` Jens Axboe
2017-06-28 18:38 ` Christoph Hellwig
2017-06-28 18:44 ` Jens Axboe
2017-06-28 18:52 ` Christoph Hellwig
2017-06-28 18:57 ` Jens Axboe
2017-06-28 21:10 ` Christoph Hellwig
2017-06-28 21:11 ` Shaohua Li
2017-06-28 21:25 ` Christoph Hellwig
2017-06-28 17:42 ` Jens Axboe
2017-06-28 17:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd97c68b-687e-df44-8dce-cd8e93e41d7c@kernel.dk \
--to=axboe@kernel.dk \
--cc=bjking@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.