From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63EA7C43334 for ; Tue, 19 Jul 2022 19:00:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 94C7983FEE; Tue, 19 Jul 2022 21:00:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="f5uqivKA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4994184051; Tue, 19 Jul 2022 21:00:06 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C1801839F6 for ; Tue, 19 Jul 2022 21:00:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1658257194; bh=k0B08R+1VF0gnBjxL/OxqXE4vXu29+QWHbHpxCFC7SA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=f5uqivKARCjz/+LrzYyNaYtiS354fZGwYkGUNX3AqmCWNl62VQil0cZo9RAEEOC4p 1UqQT7Y22F6kt+0YxnV188gguI6hk1q+Dr9QVQwKS4vYOKDfvID1+7S3aU7EK4Wjoa r3rlMy+y+Nz2PZ4eRbSNo9/LNj8w/9GbuR2X1UhA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [172.25.0.188] ([62.143.94.109]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mn2aD-1nlvPZ2tFv-00k4kg; Tue, 19 Jul 2022 20:59:54 +0200 Message-ID: Date: Tue, 19 Jul 2022 20:59:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH 1/2] tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls To: Heiko Thiery Cc: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Stefan Roese , Simon Glass , Chris Packham , =?UTF-8?Q?Marek_Beh=c3=ban?= , AKASHI Takahiro , Samuel Holland , u-boot@lists.denx.de References: <20220719183837.536343-1-heiko.thiery@gmail.com> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: <20220719183837.536343-1-heiko.thiery@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:I/LrhOdzJlYMgu1J/g8w/EQFblse917aN2qLz9OlvNWAS+vcE/b OEkmnST+VRGiDV6uCouX26n1fFRDuxSMWromr6WKZUTiMQoxUQccfvQ09KGMvaRZ2dA+XyN acwi6yVRGgxVaFVSF5sukWD965h8dnR3eFXXDWUS3MUiIEwREZl2bunoi/Pia55Y2s8wl9G vscpOnJcOww9+33+3/E3g== X-UI-Out-Filterresults: notjunk:1;V03:K0:HsvppDS9qrA=:+EPe8aLrdjN5IZ+ogwlzgL tzZ0DhNOTSvtZ9dUHpZc3BlVYSMbsdwIxGoJwd9AAk3dzoO/wASnG36826tGJuj0Ti1Jgh29V b4TEoEEoZ3W4l3wwSJZiZLRM2QUXl8lyE3dT+ANHLZuV8XdmfN4MRKySPWFhk78DpyC8hgCFO R049mnaiT/Lsbdd11eT6y3Ikd99ugmQMqaPXjkkcal58a5TqtFLb58WhXNUdT5lIYA3LQyHt5 bl/qnfe3aYwC3ZcMTL0nvklcINpN8UtJ7aU80ZW+036a8LmBHF8yYQmpeLsv47Ccrhqx0o5YM j+emUNblWNb+NZQE5LLR7N+6HGGccJlVE+fyECqdrvYAaW5UQ4pUOg/8thfHQwXYknAlsWXoI uLSCpfrg41cYc0xuHEkkzVWa3Q4FNE6r/Ke+WH4Iq2exAFJwYzxnJtWGX3zKNv8EVwsQ70B0M UxQAacNQ/Lbxm3MBYBx93yT+mRrRfO2LluopZjlIwNOlMr5nwhtNQcem0HLefutfeD8emTf+U t2rCASapVdVXBwW0PZukR8N9pznnE4/4vOqVKHcW7s67d8p/GDCxNqEk6rrTFEYvgmK82vins t3VQ2C+hjNvwdjzVbRBfjFtg7gjaJP8xNvT9skmw3qcpzfgYOxAhMXQ0WDVtR/p1d+PEEtLrZ aegYn+tOkGCTJ6TaT+GJEctblN23b5C7Mtd33gujoCk39Iv0I9Lhsu2rTt7cXYeghmeI+9MnX /e6TnTOsrwypjBjlm0m7X87XNmvKiWMeH0YdTU/S+5B+SS8zQn5gSHllWe0RkbaEQg4yM8J5x fc9qa3wb0/ybfYc2/dSmCR5RlMyIWoSF2pT5A/YzrkzfxWtWPKKaZkqTnltVRJRD+PK+02Fy3 E6K4+XapjhDsMuDpBTwasfKdoPD8Vat9Kmj2dIlIIf+tD6YeRuAfMw+js6/FavhtqnpIjiZkA hxu4wrhcYmz2+eyYcpY7EG7YXe7+xU7WM3bV198eiHf2pxU5MpyL9bsJZ0o3+sskVJu1ozsMb VFELy7gVqAeg99tVa6LFThQX37q5ieN8mcW3oR2/XlvE+tkFxVawAvnyRz8JSSIlDzkQhPug3 MRZmQ6KxDF04lJAwKnqnK3JG9tSit95JyadBOAfdGjl5dc1Hhv+vZ8cmw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 7/19/22 20:38, Heiko Thiery wrote: > Instead of hardcoding -luuid -lgnutls as the flags needed to build > mkeficapsule, use pkg-config when available. > > We gracefully fallback on the previous behavior of hardcoding -luuid > -lgnutls if pkg-config is not available or fails with an error. > > Signed-off-by: Heiko Thiery > --- > tools/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/Makefile b/tools/Makefile > index 9f2339666a..9f6b282ad8 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -242,7 +242,8 @@ hostprogs-$(CONFIG_MIPS) +=3D mips-relocs > hostprogs-$(CONFIG_ASN1_COMPILER) +=3D asn1_compiler > HOSTCFLAGS_asn1_compiler.o =3D -idirafter $(srctree)/include > > -HOSTLDLIBS_mkeficapsule +=3D -lgnutls -luuid > +HOSTLDLIBS_mkeficapsule +=3D \ > + $(shell pkg-config --libs gnutls uuid 2> /dev/null || echo "-lgnutls -= luuid") > hostprogs-$(CONFIG_TOOLS_MKEFICAPSULE) +=3D mkeficapsule > > # We build some files with extra pedantic flags to try to minimize thi= ngs We already do the same for mkimage build flags. Reviewed-by: Heinrich Schuchardt