From: Sergey Samoylenko <s.samoylenko@yadro.com>
To: Bart Van Assche <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"michael.christie@oracle.com" <michael.christie@oracle.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux@yadro.com" <linux@yadro.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Konstantin Shelekhin <k.shelekhin@yadro.com>
Subject: RE: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
Date: Thu, 24 Jun 2021 17:27:20 +0000 [thread overview]
Message-ID: <ddf079075d234fc09e524e5485b84ec7@yadro.com> (raw)
In-Reply-To: <5981680f-96ad-3c4e-6640-c3cca709a57c@acm.org>
Thank you Bart,
I used API (target_complete_cmd_with_sense) which is not in
mainline kernel. I need to change the patch.
Sorry, this is my mistake.
Sergey.
>On 6/24/21 4:19 AM, Sergey Samoylenko wrote:
>> + pr_warn_ratelimited("target_xcopy_do_work: rc: %d, sense: %u,"
>> + " XCOPY operation failed\n", rc, sense_rc);
>
>Please do not split format strings across multiple lines. Checkpatch
>should have complained about this.
>
>Thanks,
>
>Bart.
next prev parent reply other threads:[~2021-06-24 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 11:19 [PATCH 0/1] scsi: target: core: Fix sense key for invalid XCOPY request Sergey Samoylenko
2021-06-24 11:19 ` [PATCH 1/1] " Sergey Samoylenko
2021-06-24 15:49 ` kernel test robot
2021-06-24 15:49 ` kernel test robot
2021-06-24 15:57 ` Bart Van Assche
2021-06-24 17:27 ` Sergey Samoylenko [this message]
2021-07-21 21:45 ` [PATCH 0/1] " David Disseldorp
2021-07-22 11:03 ` Sergey Samoylenko
2021-07-22 13:27 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddf079075d234fc09e524e5485b84ec7@yadro.com \
--to=s.samoylenko@yadro.com \
--cc=bvanassche@acm.org \
--cc=k.shelekhin@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.