All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, hkallweit1@gmail.com, linux@armlinux.org.uk,
	shaojijie@huawei.com, horms@kernel.org, runyu.xiao@seu.edu.cn,
	mmyangfl@gmail.com, hvr@gnu.org, jeff@garzik.org,
	danny.kukawka@bisect.de, mugunthanvnm@ti.com,
	sebastian.hesselbarth@gmail.com, linux-kernel@vger.kernel.org,
	manuel.lauss@gmail.com
Subject: Re: [PATCH net v2 11/12] net: au1000: keep the MAC stopped until the PHY link is ready
Date: Tue, 17 Nov 2026 11:18:13 -0800	[thread overview]
Message-ID: <ddf29c30-de9f-486e-b6f1-42f06200eb55@gmail.com> (raw)
In-Reply-To: <179483704995.3136.5707920157509018990@kernel.org>

On 11/16/26 05:50, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
> 
> Low priority / nit picks for your consideration:
> 
> - [Low] The commit message and comments in this patch don't match the
>    code.
> 
> --
> 
> net: au1000: keep the MAC stopped until the PHY link is ready
> 
> This patch stops the MAC when the PHY reports link-down. On open, it now
> calls phy_resume() before au1000_init(). It also keeps MAC RX/TX disabled
> in au1000_init() until au1000_adjust_link() has seen a link-up.
> 
>> diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c
>> index 8b7a88ceb3c5e..d60430a3795ed 100644
>> --- a/drivers/net/ethernet/amd/au1000_eth.c
>> +++ b/drivers/net/ethernet/amd/au1000_eth.c
> 
> [ ... ]
> 
>> @@ -691,8 +692,8 @@ static u32 au1000_rx_mode(struct net_device *dev, u32 reg);
>>    * When the device powers up, the clocks are disabled and the
>>    * mac is in reset state.  When the interface is closed, we
>>    * do the same -- reset the device and disable the clocks to
>> - * conserve power. Thus, whenever au1000_init() is called,
>> - * the device should already be in reset state.
>> + * conserve power. The device must be stopped before au1000_init() is
>> + * called, but may be out of reset for MDIO accesses while resuming the PHY.
>>    */
>>   static int au1000_init(struct net_device *dev)
>>   {
> 
> [ ... ]
> 
>> @@ -928,11 +934,25 @@ static int au1000_open(struct net_device *dev)
>>   		return retval;
>>   	}
>>   
> 
> [ ... ]
> 
>> +	/* Restore the MII clocks without starting the PHY state machine. */
>> +	if (dev->phydev) {
>> +		retval = phy_resume(dev->phydev);
>> +		if (retval)
>> +			goto err_reset;
>> +	}
>> +
>>   	retval = au1000_init(dev);
>>   	if (retval) {
>>   		netdev_err(dev, "error in au1000_init\n");
>> -		free_irq(dev->irq, dev);
>> -		return retval;
>> +		if (dev->phydev)
>> +			phy_suspend(dev->phydev);
>> +		goto err_reset;
>>   	}
> 
> [Severity: Low]
> 
> Can this error branch in au1000_open() ever run? au1000_init() has only
> one return statement:
> 
> drivers/net/ethernet/amd/au1000_eth.c:au1000_init() {
> 	...
> 	spin_unlock_irqrestore(&aup->lock, flags);
> 	netif_addr_unlock_bh(dev);
> 	return 0;
> }
> 
> au1000_enable_mac() returns void, so nothing in au1000_init() can fail.
> That makes the new phy_suspend() rollback look like dead code, even
> though the commit message describes it as:
> 
>      if initialization fails, suspend the PHY again before cleanup.
> 
> The commit message also says:
> 
>      Initialize the MAC before phy_start() so the PHY worker cannot access
>      MDIO or enable traffic during setup.
> 
> Didn't au1000_open() already call au1000_init() before phy_start() before
> this patch? The diff shows that order as unchanged context.
> 
> The actual changes seem to be the new phy_resume() call before
> au1000_init(), and making RX/TX depend on aup->old_link. Could the commit
> message describe those changes instead?
> 
> Separately, the au1000_init() header comment now says the device "may be
> out of reset for MDIO accesses while resuming the PHY". The comment in
> au1000_probe() was not changed and still says:
> 
> 	/*
> 	 * The boot code uses the ethernet controller, so reset it to start
> 	 * fresh.  au1000_init() expects that the device is in reset state.
> 	 */
> 
> Should these two comments be reconciled? They now give conflicting
> preconditions for au1000_init(). Neither is strictly accurate, because
> au1000_init() always forces a reset itself through
> au1000_enable_mac(dev, 1).

Agreed on all three points. In the respin I have:

• Removed the unreachable initialization-error branch, including the new 
phy_suspend() rollback, since au1000_init() always returns zero.

• Updated the commit message to describe the new synchronous 
phy_resume() before MAC initialization, while preserving the existing 
initialization-before-phy_start() ordering.

• Reconciled the comments to explain that au1000_init() forces a reset 
itself and that preceding MDIO accesses may already have enabled the MAC.

pw-bot: cr
-- 
Florian

  reply	other threads:[~2026-11-17 19:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  4:52 [PATCH net v2 00/12] net: au1000: Bug fixes Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 01/12] net: au1000: recycle RX descriptors on allocation failure Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 02/12] net: au1000: clear all-multicast mode when restoring hash filtering Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 03/12] net: au1000: disconnect the PHY before freeing the MDIO bus Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 04/12] net: au1000: report MDIO transaction timeouts Florian Fainelli
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-17 19:09     ` Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 05/12] net: au1000: serialize TX completion with packet submission Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 06/12] net: au1000: assign a valid MAC address without platform data Florian Fainelli
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-17 19:11     ` Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 07/12] net: au1000: fix buffer descriptor free list insertion Florian Fainelli
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-17 19:13     ` Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 08/12] net: au1000: restore receive filtering before enabling RX Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 09/12] net: au1000: restore RX buffer addresses when restarting the MAC Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 10/12] net: phy: smsc: wait for LAN83C183 power-down recovery Florian Fainelli
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-17 19:15     ` Florian Fainelli
2026-11-12  4:52 ` [PATCH net v2 11/12] net: au1000: keep the MAC stopped until the PHY link is ready Florian Fainelli
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-17 19:18     ` Florian Fainelli [this message]
2026-11-12  4:52 ` [PATCH net v2 12/12] net: au1000: reject frames larger than the TX bounce buffer Florian Fainelli
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-17 19:19     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddf29c30-de9f-486e-b6f1-42f06200eb55@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=danny.kukawka@bisect.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=hvr@gnu.org \
    --cc=jeff@garzik.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=manuel.lauss@gmail.com \
    --cc=mmyangfl@gmail.com \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=runyu.xiao@seu.edu.cn \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=shaojijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.