From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10136C83001 for ; Tue, 28 Apr 2020 14:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDB0F206E2 for ; Tue, 28 Apr 2020 14:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727838AbgD1OKR (ORCPT ); Tue, 28 Apr 2020 10:10:17 -0400 Received: from mga06.intel.com ([134.134.136.31]:3285 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727837AbgD1OKR (ORCPT ); Tue, 28 Apr 2020 10:10:17 -0400 IronPort-SDR: ZcHSO9sHC6SOOiltka4d4wNib/U5kpjWgqotIDRlEbkAlwiUNxzO0/13ZsHgXlWoBUt6mKRcvL jFDrNYj0pjjw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 07:10:00 -0700 IronPort-SDR: Mm9J+5XFNoyA68jB0F0HKKpD1YU7fQMOY9LqQIoJEGkYRAY5YaN7vXK//ElU6ngpEs2/VLIDk9 vVCiz+6MyA+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="247720032" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 28 Apr 2020 07:09:59 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.7.201.137]) by linux.intel.com (Postfix) with ESMTP id 0B6675802C8; Tue, 28 Apr 2020 07:10:00 -0700 (PDT) Message-ID: Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: Christoph Hellwig Cc: rjw@rjwysocki.net, lenb@kernel.org, bhelgaas@google.com, kbusch@kernel.org, axboe@fb.com, sagi@grimberg.me, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 28 Apr 2020 07:09:59 -0700 In-Reply-To: <20200428051312.GB17146@lst.de> References: <20200428003214.3764-1-david.e.box@linux.intel.com> <20200428051312.GB17146@lst.de> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, 2020-04-28 at 07:13 +0200, Christoph Hellwig wrote: > On Mon, Apr 27, 2020 at 05:32:12PM -0700, David E. Box wrote: > > NVMe storage power management during suspend-to-idle, particularly > > on > > laptops, has been inconsistent with some devices working with D3 > > while > > others must rely on NVMe APST in order for power savings to be > > realized. > > Currently the default is to use APST unless quirked to do > > otherwise. > > However newer platforms, like Intel Comet Lake systems, may require > > NVMe > > drives to use D3 in order for the PCIe ports to be properly power > > managed. > > To make it easier for drivers to choose, these platforms may supply > > a > > special "StorageD3Enable" _DSD property under the root port that > > the device > > is attached to. If supplied, the driver must use D3 in order for > > the > > platform to realize the deepest power savings in suspend-to-idle. > > > > The first patch adds the new _DSD GUID and fowards the property > > through the > > pci/acpi layer to the pci device. > > > > The second patch adds support for the property to the nvme driver. > > I'm not sure who came up with the idea to put this into ACPI, but it > belongs into NVMe. Please talk to the NVMe technical working group > instead of trying to overrules them in an unrelated group that > doesn't > apply to all of PCIe. Agreed that this is not ideal since it does not apply to all of PCIe. But as the property already exists on shipping systems, we need to be able to read it in the NVMe driver and the patch is consitent with the way properties under PCI ports are read. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E71C83000 for ; Tue, 28 Apr 2020 14:10:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0FA8206C0 for ; Tue, 28 Apr 2020 14:10:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CllUXUCn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0FA8206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6YG28P1rr6lC3DgOUF13IN3d9qNsbTZQiNrecxawP04=; b=CllUXUCnuQ0G7k umbiV5mNg9eAVLG6wwzEa55zoVDxkvu+waRWS5m44/BtuGAK/8yVQ/XUBwdWbu63QBM8SkvgXYuhT XELeKBT8MrTMW8iqfs1WC9Hn31yiJkUfo+O6kygGtRcy7Vc+B2v8jveqx4nlDf/ZOqvy4MK08CtTe 6hb8QH/FNLLFTKYNRYT8EghLhAzd/v80Pl/PyBfXYtgKO0BeHA1JWhqlcRm74x10pKTN6lTYbmEKA qenUoY7NVc2OiEmmmTu8FPRCfWnw7hmVYwpykmCDOuQ05o9//S4bxjkKxhHjHgqk3X9N2JjFI2smC 0LoRDRSDR0EYSclxwxBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTQvz-0002j5-T5; Tue, 28 Apr 2020 14:10:03 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTQvx-0002Nv-1H for linux-nvme@lists.infradead.org; Tue, 28 Apr 2020 14:10:02 +0000 IronPort-SDR: 2JjBMR1PHMW41JcSvVAAbmrDR+aAIur0MF4qeQQzNwsVOK16o9pPmQdm35hvJLJhELZyahOgAp MrgN9Wc7AEFg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 07:10:00 -0700 IronPort-SDR: Mm9J+5XFNoyA68jB0F0HKKpD1YU7fQMOY9LqQIoJEGkYRAY5YaN7vXK//ElU6ngpEs2/VLIDk9 vVCiz+6MyA+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="247720032" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 28 Apr 2020 07:09:59 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.7.201.137]) by linux.intel.com (Postfix) with ESMTP id 0B6675802C8; Tue, 28 Apr 2020 07:10:00 -0700 (PDT) Message-ID: Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property From: "David E. Box" To: Christoph Hellwig Date: Tue, 28 Apr 2020 07:09:59 -0700 In-Reply-To: <20200428051312.GB17146@lst.de> References: <20200428003214.3764-1-david.e.box@linux.intel.com> <20200428051312.GB17146@lst.de> Organization: David E. Box User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_071001_125717_CB9E8CB5 X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: david.e.box@linux.intel.com Cc: sagi@grimberg.me, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org, bhelgaas@google.com, lenb@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, 2020-04-28 at 07:13 +0200, Christoph Hellwig wrote: > On Mon, Apr 27, 2020 at 05:32:12PM -0700, David E. Box wrote: > > NVMe storage power management during suspend-to-idle, particularly > > on > > laptops, has been inconsistent with some devices working with D3 > > while > > others must rely on NVMe APST in order for power savings to be > > realized. > > Currently the default is to use APST unless quirked to do > > otherwise. > > However newer platforms, like Intel Comet Lake systems, may require > > NVMe > > drives to use D3 in order for the PCIe ports to be properly power > > managed. > > To make it easier for drivers to choose, these platforms may supply > > a > > special "StorageD3Enable" _DSD property under the root port that > > the device > > is attached to. If supplied, the driver must use D3 in order for > > the > > platform to realize the deepest power savings in suspend-to-idle. > > > > The first patch adds the new _DSD GUID and fowards the property > > through the > > pci/acpi layer to the pci device. > > > > The second patch adds support for the property to the nvme driver. > > I'm not sure who came up with the idea to put this into ACPI, but it > belongs into NVMe. Please talk to the NVMe technical working group > instead of trying to overrules them in an unrelated group that > doesn't > apply to all of PCIe. Agreed that this is not ideal since it does not apply to all of PCIe. But as the property already exists on shipping systems, we need to be able to read it in the NVMe driver and the patch is consitent with the way properties under PCI ports are read. David _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme